Upates for new release

Updated requirements for gdrive and gmail
Updated teststatus
2022-01-24 19:18:40 +01:00 · 2022-01-24 18:47:34 +01:00 · 2022-01-24 18:47:34 +01:00 · 2022-01-24 18:47:34 +01:00 · 2022-01-24 18:47:34 +01:00 · 2022-01-24 12:37:15 +01:00
872 changed files with 158232 additions and 112590 deletions
@@ -6,6 +6,7 @@ labels: ''
 assignees: ''
 ---
 <!-- Please have a look at our [Contributing Guidelines](https://github.com/janeczku/calibre-web/blob/master/CONTRIBUTING.md) -->
 **Describe the bug/problem**
 A clear and concise description of what the bug is. If you are asking for support, please check our [Wiki](https://github.com/janeczku/calibre-web/wiki) if your question is already answered there.
@@ -27,12 +28,12 @@ A clear and concise description of what you expected to happen.
 If applicable, add screenshots to help explain your problem.
 **Environment (please complete the following information):**
- - OS: [e.g. Windows 10/raspian]
+ - OS: [e.g. Windows 10/Raspberry Pi OS]
- - Python version [e.g. python2.7]
+ - Python version: [e.g. python2.7]
- - Calibre-Web version [e.g. 0.6.5 or master@16.02.20, 19:55 ]:
+ - Calibre-Web version: [e.g. 0.6.8 or 087c4c59 (git rev-parse --short HEAD)]:
- - Docker container [ None/Technosoft2000/Linuxuser]:
+ - Docker container: [None/LinuxServer]:
- - Special Hardware [e.g. Rasperry Pi Zero]
+ - Special Hardware: [e.g. Rasperry Pi Zero]
- - Browser [e.g. chrome, safari]
+ - Browser: [e.g. Chrome 83.0.4103.97, Safari 13.3.7, Firefox 68.0.1 ESR]
 **Additional context**
-Add any other context about the problem here. [e.g. access via reverse proxy]
+Add any other context about the problem here. [e.g. access via reverse proxy, database background sync, special database location]
@@ -0,0 +1 @@
 blank_issues_enabled: false
@@ -7,6 +7,8 @@ assignees: ''
 ---
 <!-- Please have a look at our [Contributing Guidelines](https://github.com/janeczku/calibre-web/blob/master/CONTRIBUTING.md) -->
 **Is your feature request related to a problem? Please describe.**
 A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
@@ -6,10 +6,12 @@ __pycache__/
 # Distribution / packaging
 .Python
 .python-version
 env/
 venv/
 eggs/
 dist/
 executable/
 build/
 vendor/
 .eggs/
@@ -29,4 +31,4 @@ vendor/
 settings.yaml
 gdrive_credentials
 client_secrets.json
-
+gmail.json
@@ -1,49 +1,46 @@
 ## How to contribute to Calibre-Web
-First of all, we would like to thank you for reading this text. we are happy you are willing to contribute to Calibre-Web
+First of all, we would like to thank you for reading this text. We are happy you are willing to contribute to Calibre-Web.
 ### **General**
-**Communication language** is english. Google translated texts are not as bad as you might think, they are usually understandable, so don't worry if you generate your post that way.
+**Communication language** is English. Google translated texts are not as bad as you might think, they are usually understandable, so don't worry if you generate your post that way.
 **Calibre-Web** is not **Calibre**. If you are having a question regarding Calibre please post this at their [repository](https://github.com/kovidgoyal/calibre).
-**Docker-Containers** of Calibre-Web are maintained by different persons than the people who drive Calibre-Web. If we come to the conclusion during our analysis that the problem is related to Docker, we might ask you to open a new issue at the reprository of the Docker Container.
+**Docker-Containers** of Calibre-Web are maintained by different persons than the people who drive Calibre-Web. If we come to the conclusion during our analysis that the problem is related to Docker, we might ask you to open a new issue at the repository of the Docker Container.
-If you are having **Basic Installation Problems** with python or it's dependencies, please consider using your favorite search engine to find a solution. In case you can't find a solution, we are happy to help you.
+If you are having **Basic Installation Problems** with python or its dependencies, please consider using your favorite search engine to find a solution. In case you can't find a solution, we are happy to help you.
-We can offer only very limited support regarding configuration of **Reverse-Proxy Installations**, **OPDS-Reader** or other programs in combination with Calibre-Web. 
+We can offer only very limited support regarding configuration of **Reverse-Proxy Installations**, **OPDS-Reader** or other programs in combination with Calibre-Web.
 ### **Translation**
-Some of the user languages in Calibre-Web having missing translations. We are happy to add the missing texts if you are translate them. Create a Pull Request, create an issue with the .po file attached, or write an email to "ozzie.fernandez.isaacs@googlemail.com" with attached translation file. To display all book languages in your native language an additional file is used (iso_language_names.py). The content of this file is autogenerated with the corresponding translations of Calibre, please do not edit this file on your own. 
+Some of the user languages in Calibre-Web having missing translations. We are happy to add the missing texts if you translate them. Create a Pull Request, create an issue with the .po file attached, or write an email to "ozzie.fernandez.isaacs@googlemail.com" with attached translation file. To display all book languages in your native language an additional file is used (iso_language_names.py). The content of this file is auto-generated with the corresponding translations of Calibre, please do not edit this file on your own.
 ### **Documentation**
-The Calibre-Web documentation is hosted in the Github [Wiki](https://github.com/janeczku/calibre-web/wiki). The Wiki is open to everybody, if you find a problem, feel free to correct it. If information is missing, you are welcome to add it. The content will be reviewed time by time. Please try to be consitent with the form with the other Wiki pages (e.g. the project name is Calibre-Web with 2 capital letters and a dash in between).
+The Calibre-Web documentation is hosted in the Github [Wiki](https://github.com/janeczku/calibre-web/wiki). The Wiki is open to everybody, if you find a problem, feel free to correct it. If information is missing, you are welcome to add it. The content will be reviewed time by time. Please try to be consistent with the form with the other Wiki pages (e.g. the project name is Calibre-Web with 2 capital letters and a dash in between).
 ### **Reporting a bug**
-Do not open up a GitHub issue if the bug is a **security vulnerability** in Calibre-Web. Please write intead an email to "ozzie.fernandez.isaacs@googlemail.com".
+Do not open up a GitHub issue if the bug is a **security vulnerability** in Calibre-Web. Instead, please write an email to "ozzie.fernandez.isaacs@googlemail.com".
 Ensure the ***bug was not already reported** by searching on GitHub under [Issues](https://github.com/janeczku/calibre-web/issues). Please also check if a solution for your problem can be found in the [wiki](https://github.com/janeczku/calibre-web/wiki).
-If you're unable to find an **open issue** addressing the problem, open a [new one](https://github.com/janeczku/calibre-web/issues/new?assignees=&labels=&template=bug_report.md&title=). Be sure to include a **title** and **clear description**, as much relevant information as possible, the **issue form** helps you providing the right information. Deleting the form and just pasting the stack trace doesn't speed up fixing the problem. If your issue could be resolved, consider closing the issue. 
+If you're unable to find an **open issue** addressing the problem, open a [new one](https://github.com/janeczku/calibre-web/issues/new?assignees=&labels=&template=bug_report.md&title=). Be sure to include a **title** and **clear description**, as much relevant information as possible, the **issue form** helps you providing the right information. Deleting the form and just pasting the stack trace doesn't speed up fixing the problem. If your issue could be resolved, consider closing the issue.
 ### **Feature Request**
-If there is afeature missing in Calibre-Web and you can't find a feature request in the [Issues](https://github.com/janeczku/calibre-web/issues) section, you could create a [feature request](https://github.com/janeczku/calibre-web/issues/new?assignees=&labels=&template=feature_request.md&title=). 
+If there is a feature missing in Calibre-Web and you can't find a feature request in the [Issues](https://github.com/janeczku/calibre-web/issues) section, you could create a [feature request](https://github.com/janeczku/calibre-web/issues/new?assignees=&labels=&template=feature_request.md&title=).
-We will not extend Calibre-Web with any more login abilitys or add further files storages, or file syncing ability. Furthermore Calibre-Web is made for home usage for company inhouse usage, so requests regarding any sorts of social interaction capability, payment routines, search engine or web site analytics integration will not be implemeted. 
+We will not extend Calibre-Web with any more login abilities or add further files storages, or file syncing ability. Furthermore Calibre-Web is made for home usage for company in-house usage, so requests regarding any sorts of social interaction capability, payment routines, search engine or web site analytics integration will not be implemented.
 ### **Contributing code to Calibre-Web**
 Open a new GitHub pull request with the patch. Ensure the PR description clearly describes the problem and solution. Include the relevant issue number if applicable.
-In case your code enhances features of Calibre-Web: Create your pull request for the development branch if your enhancement consits of more than some lines of code in a local section of Calibre-Webs code. This makes it easier to test it and check all implication before it's made public. 
+In case your code enhances features of Calibre-Web: Create your pull request for the development branch if your enhancement consists of more than some lines of code in a local section of Calibre-Webs code. This makes it easier to test it and check all implication before it's made public.
 Please check if your code runs on Python 2.7 (still necessary in 2020) and mainly on python 3. If possible and the feature is related to operating system functions, try to check it on Windows and Linux. 
 Calibre-Web is automatically tested on Linux in combination with python 3.7. The code for testing is in a [seperate repo](https://github.com/OzzieIsaacs/calibre-web-test) on Github. It uses unittest and performs real system tests with selenium, would be great if you could consider also writing some tests. 
 A static code analysis is done by Codacy, but it's partly broken and doesn't run automatically. You could check your code with ESLint before contributing, a configuration file can be found in the projects root folder. 
 Please check if your code runs with python 3, python 2 is no longer supported. If possible and the feature is related to operating system functions, try to check it on Windows and Linux.
 Calibre-Web is automatically tested on Linux in combination with python 3.8. The code for testing is in a [separate repo](https://github.com/OzzieIsaacs/calibre-web-test) on Github. It uses unit tests and performs real system tests with selenium; it would be great if you could consider also writing some tests.
 A static code analysis is done by Codacy, but it's partly broken and doesn't run automatically. You could check your code with ESLint before contributing, a configuration file can be found in the projects root folder.
@@ -2,6 +2,13 @@
 Calibre-Web is a web app providing a clean interface for browsing, reading and downloading eBooks using an existing [Calibre](https://calibre-ebook.com) database.
 [![GitHub License](https://img.shields.io/github/license/janeczku/calibre-web?style=flat-square)](https://github.com/janeczku/calibre-web/blob/master/LICENSE)
 [![GitHub commit activity](https://img.shields.io/github/commit-activity/w/janeczku/calibre-web?logo=github&style=flat-square&label=commits)]()
 [![GitHub all releases](https://img.shields.io/github/downloads/janeczku/calibre-web/total?logo=github&style=flat-square)](https://github.com/janeczku/calibre-web/releases)
 [![PyPI](https://img.shields.io/pypi/v/calibreweb?logo=pypi&logoColor=fff&style=flat-square)](https://pypi.org/project/calibreweb/)
 [![PyPI - Downloads](https://img.shields.io/pypi/dm/calibreweb?logo=pypi&logoColor=fff&style=flat-square)](https://pypi.org/project/calibreweb/)
 [![Discord](https://img.shields.io/discord/838810113564344381?label=Discord&logo=discord&style=flat-square)](https://discord.gg/h2VsJ2NEfB)
 *This software is a fork of [library](https://github.com/mutschler/calibreserver) and licensed under the GPL v3 License.*
 ![Main screen](https://github.com/janeczku/calibre-web/wiki/images/main_screen.png)
@@ -12,7 +19,7 @@ Calibre-Web is a web app providing a clean interface for browsing, reading and d
 - full graphical setup
 - User management with fine-grained per-user permissions
 - Admin interface
- User Interface in czech, dutch, english, finnish, french, german, hungarian, italian, japanese, khmer, polish, russian, simplified chinese, spanish, swedish, turkish, ukrainian
+- User Interface in brazilian, czech, dutch, english, finnish, french, german, greek, hungarian, italian, japanese, khmer, korean, polish, russian, simplified and traditional chinese, spanish, swedish, turkish, ukrainian
 - OPDS feed for eBook reader apps 
 - Filter and search by titles, authors, tags, series and language
 - Create a custom book collection (shelves)
@@ -22,7 +29,7 @@ Calibre-Web is a web app providing a clean interface for browsing, reading and d
 - Support for public user registration
 - Send eBooks to Kindle devices with the click of a button
 - Sync your Kobo devices through Calibre-Web with your Calibre library
- Support for reading eBooks directly in the browser (.txt, .epub, .pdf, .cbr, .cbt, .cbz)
+- Support for reading eBooks directly in the browser (.txt, .epub, .pdf, .cbr, .cbt, .cbz, .djvu)
 - Upload new books in many formats, including audio formats (.mp3, .m4a, .m4b)
 - Support for Calibre Custom Columns
 - Ability to hide content based on categories and Custom Column content per user
@@ -30,47 +37,48 @@ Calibre-Web is a web app providing a clean interface for browsing, reading and d
 - "Magic Link" login to make it easy to log on eReaders
 - Login via LDAP, google/github oauth and via proxy authentication
 ## Installation
 #### Installation via pip (recommended)
 1. Install calibre web via pip with the command `pip install calibreweb` (Depending on your OS and or distro the command could also be `pip3`). 
 2. Optional features can also be installed via pip, please refer to [this page](https://github.com/janeczku/calibre-web/wiki/Dependencies-in-Calibre-Web-Linux-Windows) for details 
 3. Calibre-Web can be started afterwards by typing `cps` or `python3 -m cps` 
 #### Manual installation
 1. Install dependencies by running `pip3 install --target vendor -r requirements.txt` (python3.x). Alternativly set up a python virtual environment.
 2. Execute the command: `python3 cps.py` (or `nohup python3 cps.py` - recommended if you want to exit the terminal window)
 Issues with Ubuntu:
 Please note that running the above install command can fail on some versions of Ubuntu, saying `"can't combine user with prefix"`. This is a [known bug](https://github.com/pypa/pip/issues/3826) and can be remedied by using the command `pip install --system --target vendor -r requirements.txt` instead.
 ## Quick start
-1. Install dependencies by running `pip3 install --target vendor -r requirements.txt` (python3.x) or `pip install --target vendor -r requirements.txt` (python2.7).
+Point your browser to `http://localhost:8083` or `http://localhost:8083/opds` for the OPDS catalog
-2. Execute the command: `python cps.py` (or `nohup python cps.py` - recommended if you want to exit the terminal window)
+Set `Location of Calibre database` to the path of the folder where your Calibre library (metadata.db) lives, push "submit" button\
-3. Point your browser to `http://localhost:8083` or `http://localhost:8083/opds` for the OPDS catalog
+Optionally a Google Drive can be used to host the calibre library [-> Using Google Drive integration](https://github.com/janeczku/calibre-web/wiki/Configuration#using-google-drive-integration)
-4. Set `Location of Calibre database` to the path of the folder where your Calibre library (metadata.db) lives, push "submit" button\
+Go to Login page
   Optionally a Google Drive can be used to host the calibre library [-> Using Google Drive integration](https://github.com/janeczku/calibre-web/wiki/Configuration#using-google-drive-integration)
 5. Go to Login page
-**Default admin login:**\
+#### Default admin login:
 *Username:* admin\
 *Password:* admin123
 **Issues with Ubuntu:**
 Please note that running the above install command can fail on some versions of Ubuntu, saying `"can't combine user with prefix"`. This is a [known bug](https://github.com/pypa/pip/issues/3826) and can be remedied by using the command `pip install --system --target vendor -r requirements.txt` instead.
 ## Requirements
-python 3.x+, (Python 2.7+)
+python 3.5+
 Optionally, to enable on-the-fly conversion from one ebook format to another when using the send-to-kindle feature, or during editing of ebooks metadata:
 [Download and install](https://calibre-ebook.com/download) the Calibre desktop program for your platform and enter the folder including program name (normally /opt/calibre/ebook-convert, or C:\Program Files\calibre\ebook-convert.exe) in the field "calibre's converter tool" on the setup page.
-\*** DEPRECATED \*** Support will be removed in future releases
+[Download](https://github.com/pgaskin/kepubify/releases/latest) Kepubify tool for your platform and place the binary starting with `kepubify` in Linux: `\opt\kepubify` Windows: `C:\Program Files\kepubify`.
 [Download](http://www.amazon.com/gp/feature.html?docId=1000765211) Amazon's KindleGen tool for your platform and place the binary named `kindlegen` in the `vendor` folder.
 ## Docker Images
-Pre-built Docker images are available in these Docker Hub repositories:
+A pre-built Docker image is available in these Docker Hub repository (maintained by the LinuxServer team):
 #### **Technosoft2000 - x64**
 + Docker Hub - [https://hub.docker.com/r/technosoft2000/calibre-web/](https://hub.docker.com/r/technosoft2000/calibre-web/)
 + Github - [https://github.com/Technosoft2000/docker-calibre-web](https://github.com/Technosoft2000/docker-calibre-web) 
    Includes the Calibre `ebook-convert` binary.
    + The "path to convertertool" should be set to `/opt/calibre/ebook-convert`
 #### **LinuxServer - x64, armhf, aarch64**
-+ Docker Hub - [https://hub.docker.com/r/linuxserver/calibre-web/](https://hub.docker.com/r/linuxserver/calibre-web/)
+ Docker Hub - [https://hub.docker.com/r/linuxserver/calibre-web](https://hub.docker.com/r/linuxserver/calibre-web)
 + Github - [https://github.com/linuxserver/docker-calibre-web](https://github.com/linuxserver/docker-calibre-web)
 + Github - (Optional Calibre layer) - [https://github.com/linuxserver/docker-calibre-web/tree/calibre](https://github.com/linuxserver/docker-calibre-web/tree/calibre) 
@@ -82,6 +90,12 @@ Pre-built Docker images are available in these Docker Hub repositories:
   + The "path to convertertool" should be set to `/usr/bin/ebook-convert`
   + The "path to unrar" should be set to `/usr/bin/unrar`
-# Wiki
+# Contact
 Just reach us out on [Discord](https://discord.gg/h2VsJ2NEfB)
 For further information, How To's and FAQ please check the [Wiki](https://github.com/janeczku/calibre-web/wiki)
 # Contributing to Calibre-Web
 Please have a look at our [Contributing Guidelines](https://github.com/janeczku/calibre-web/blob/master/CONTRIBUTING.md) 
@@ -0,0 +1,39 @@
 # Security Policy
 ## Reporting a Vulnerability
 Please report security issues to ozzie.fernandez.isaacs@googlemail.com
 ## Supported Versions
 To receive fixes for security vulnerabilities it is required to always upgrade to the latest version of Calibre-Web. See https://github.com/janeczku/calibre-web/releases/latest for the latest release.
 ## History
 | Fixed in      | Description                                                                                                        |CVE number |
 |---------------|--------------------------------------------------------------------------------------------------------------------|---------|
 | 3rd July 2018 | Guest access acts as a backdoor                                                                                    ||
 | V 0.6.7       | Hardcoded secret key for sessions                                                                                  |CVE-2020-12627 |
 | V 0.6.13      | Calibre-Web Metadata cross site scripting                                                                          |CVE-2021-25964|
 | V 0.6.13      | Name of Shelves are only visible to users who can access the corresponding shelf Thanks to @ibarrionuevo           ||
 | V 0.6.13      | JavaScript could get executed in the description field. Thanks to @ranjit-git  and Hagai Wechsler (WhiteSource)    ||
 | V 0.6.13      | JavaScript could get executed in a custom column of type "comment" field                                           ||
 | V 0.6.13      | JavaScript could get executed after converting a book to another format with a title containing javascript code    ||
 | V 0.6.13      | JavaScript could get executed after converting a book to another format with a username containing javascript code ||
 | V 0.6.13      | JavaScript could get executed in the description series, categories or publishers title                            ||
 | V 0.6.13      | JavaScript could get executed  in the shelf title                                                                  ||
 | V 0.6.13      | Login with the old session cookie after logout. Thanks to @ibarrionuevo                                            ||
 | V 0.6.14      | CSRF was possible. Thanks to @mik317 and Hagai Wechsler (WhiteSource)                                              |CVE-2021-25965|
 | V 0.6.14      | Migrated some routes to POST-requests (CSRF protection). Thanks to @scara31                                        ||
 | V 0.6.15      | Fix for "javascript:" script links in identifier. Thanks to @scara31                                               ||
 | V 0.6.15      | Cross-Site Scripting vulnerability on uploaded cover file names. Thanks to @ibarrionuevo                           ||
 | V 0.6.15      | Creating public shelfs is now denied if user is missing the edit public shelf right. Thanks to @ibarrionuevo       ||
 | V 0.6.15      | Changed error message in case of trying to delete a shelf unauthorized. Thanks to @ibarrionuevo                    ||
 | V 0.6.16      | JavaScript could get executed on authors page. Thanks to @alicaz                                                   ||
 | V 0.6.16      | Localhost can no longer be used to upload covers. Thanks to @scara31                                               ||
 | V 0.6.16      | Another case where public shelfs could be created without permission is prevented. Thanks to @ibarrionuevo         ||
 ## Staement regarding Log4j (CVE-2021-44228 and related)
 Calibre-web is not affected by bugs related to Log4j. Calibre-Web is a python program, therefore not using Java, and not using the Java logging feature log4j. 
@@ -17,18 +17,13 @@
 #  You should have received a copy of the GNU General Public License
 #  along with this program. If not, see <http://www.gnu.org/licenses/>.
 from __future__ import absolute_import, division, print_function, unicode_literals
 import sys
 import os
 # Insert local directories into path
-if sys.version_info < (3, 0):
+sys.path.append(os.path.dirname(os.path.abspath(__file__)))
-    sys.path.append(os.path.dirname(os.path.abspath(__file__.decode('utf-8'))))
+sys.path.append(os.path.join(os.path.dirname(os.path.abspath(__file__)), 'vendor'))
    sys.path.append(os.path.join(os.path.dirname(os.path.abspath(__file__.decode('utf-8'))), 'vendor'))
 else:
    sys.path.append(os.path.dirname(os.path.abspath(__file__)))
    sys.path.append(os.path.join(os.path.dirname(os.path.abspath(__file__)), 'vendor'))
 from cps import create_app
@@ -41,12 +36,15 @@ from cps.shelf import shelf
 from cps.admin import admi
 from cps.gdrive import gdrive
 from cps.editbooks import editbook
 from cps.remotelogin import remotelogin
 from cps.search_metadata import meta
 from cps.error_handler import init_errorhandler
 try:
    from cps.kobo import kobo, get_kobo_activated
    from cps.kobo_auth import kobo_auth
    kobo_available = get_kobo_activated()
-except ImportError:
+except (ImportError, AttributeError):   # Catch also error for not installed flask-WTF (missing csrf decorator)
    kobo_available = False
 try:
@@ -58,12 +56,17 @@ except ImportError:
 def main():
    app = create_app()
    init_errorhandler()
    app.register_blueprint(web)
    app.register_blueprint(opds)
    app.register_blueprint(jinjia)
    app.register_blueprint(about)
    app.register_blueprint(shelf)
    app.register_blueprint(admi)
    app.register_blueprint(remotelogin)
    app.register_blueprint(meta)
    app.register_blueprint(gdrive)
    app.register_blueprint(editbook)
    if kobo_available:
@@ -0,0 +1,34 @@
 # -*- coding: utf-8 -*-
 #  This file is part of the Calibre-Web (https://github.com/janeczku/calibre-web)
 #    Copyright (C) 2018-2019 OzzieIsaacs, cervinko, jkrehm, bodybybuddha, ok11,
 #                            andy29485, idalin, Kyosfonica, wuqi, Kennyl, lemmsh,
 #                            falgh1, grunjol, csitko, ytils, xybydy, trasba, vrabe,
 #                            ruben-herold, marblepebble, JackED42, SiphonSquirrel,
 #                            apetresc, nanu-c, mutschler, GammaC0de, vuolter
 #
 #  This program is free software: you can redistribute it and/or modify
 #  it under the terms of the GNU General Public License as published by
 #  the Free Software Foundation, either version 3 of the License, or
 #  (at your option) any later version.
 #
 #  This program is distributed in the hope that it will be useful,
 #  but WITHOUT ANY WARRANTY; without even the implied warranty of
 #  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 #  GNU General Public License for more details.
 #
 #  You should have received a copy of the GNU General Public License
 #  along with this program. If not, see <http://www.gnu.org/licenses/>.
 from flask_login import LoginManager
 from flask import session
 class MyLoginManager(LoginManager):
    def _session_protection_failed(self):
        sess = session._get_current_object()
        ident = self._session_identifier_generator()
        if(sess and not (len(sess) == 1 and sess.get('csrf_token', None))) and ident != sess.get('_id', None):
            return super(). _session_protection_failed()
        return False
@@ -19,8 +19,8 @@
 #
 #  You should have received a copy of the GNU General Public License
 #  along with this program. If not, see <http://www.gnu.org/licenses/>.
 __package__ = "cps"
 from __future__ import division, print_function, unicode_literals
 import sys
 import os
 import mimetypes
@@ -29,13 +29,26 @@ from babel import Locale as LC
 from babel import negotiate_locale
 from babel.core import UnknownLocaleError
 from flask import Flask, request, g
-from flask_login import LoginManager
+from .MyLoginManager import MyLoginManager
 from flask_babel import Babel
 from flask_principal import Principal
 from . import config_sql, logger, cache_buster, cli, ub, db
 from .reverseproxy import ReverseProxied
 from .server import WebServer
 from .dep_check import dependency_check
 try:
    import lxml
    lxml_present = True
 except ImportError:
    lxml_present = False
 try:
    from flask_wtf.csrf import CSRFProtect
    wtf_present = True
 except ImportError:
    wtf_present = False
 mimetypes.init()
 mimetypes.add_type('application/xhtml+xml', '.xhtml')
@@ -44,6 +57,7 @@ mimetypes.add_type('application/fb2+zip', '.fb2')
 mimetypes.add_type('application/x-mobipocket-ebook', '.mobi')
 mimetypes.add_type('application/x-mobipocket-ebook', '.prc')
 mimetypes.add_type('application/vnd.amazon.ebook', '.azw')
 mimetypes.add_type('application/x-mobi8-ebook', '.azw3')
 mimetypes.add_type('application/x-cbr', '.cbr')
 mimetypes.add_type('application/x-cbz', '.cbz')
 mimetypes.add_type('application/x-cbt', '.cbt')
@@ -54,18 +68,33 @@ mimetypes.add_type('application/mp4', '.m4a')
 mimetypes.add_type('application/mp4', '.m4b')
 mimetypes.add_type('application/ogg', '.ogg')
 mimetypes.add_type('application/ogg', '.oga')
 mimetypes.add_type('text/css', '.css')
 mimetypes.add_type('text/javascript; charset=UTF-8', '.js')
 app = Flask(__name__)
 app.config.update(
    SESSION_COOKIE_HTTPONLY=True,
    SESSION_COOKIE_SAMESITE='Lax',
    REMEMBER_COOKIE_SAMESITE='Lax',  # will be available in flask-login 0.5.1 earliest
    WTF_CSRF_SSL_STRICT=False
 )
-lm = LoginManager()
+
 lm = MyLoginManager()
 lm.login_view = 'web.login'
 lm.anonymous_user = ub.Anonymous
 lm.session_protection = 'strong'
 if wtf_present:
    csrf = CSRFProtect()
    csrf.init_app(app)
 else:
    csrf = None
 ub.init_db(cli.settingspath)
 # pylint: disable=no-member
 config = config_sql.load_configuration(ub.session)
 searched_ids = {}
 web_server = WebServer()
 babel = Babel()
@@ -73,25 +102,49 @@ _BABEL_TRANSLATIONS = set()
 log = logger.create()
 from . import services
 db.CalibreDB.update_config(config)
 db.CalibreDB.setup_db(config.config_calibre_dir, cli.settingspath)
 calibre_db = db.CalibreDB()
 def create_app():
    app.wsgi_app = ReverseProxied(app.wsgi_app)
    # For python2 convert path to unicode
    if sys.version_info < (3, 0):
-        app.static_folder = app.static_folder.decode('utf-8')
+        log.info(
-        app.root_path = app.root_path.decode('utf-8')
+            '*** Python2 is EOL since end of 2019, this version of Calibre-Web is no longer supporting Python2, please update your installation to Python3 ***')
-        app.instance_path = app.instance_path .decode('utf-8')
+        print(
-
+            '*** Python2 is EOL since end of 2019, this version of Calibre-Web is no longer supporting Python2, please update your installation to Python3 ***')
-    cache_buster.init_cache_busting(app)
+        web_server.stop(True)
        sys.exit(5)
    if not lxml_present:
        log.info('*** "lxml" is needed for calibre-web to run. Please install it using pip: "pip install lxml" ***')
        print('*** "lxml" is needed for calibre-web to run. Please install it using pip: "pip install lxml" ***')
        web_server.stop(True)
        sys.exit(6)
    if not wtf_present:
        log.info('*** "flask-WTF" is needed for calibre-web to run. Please install it using pip: "pip install flask-WTF" ***')
        print('*** "flask-WTF" is needed for calibre-web to run. Please install it using pip: "pip install flask-WTF" ***')
        web_server.stop(True)
        sys.exit(7)
    for res in dependency_check() + dependency_check(True):
        log.info('*** "{}" version does not fit the requirements. Should: {}, Found: {}, please consider installing required version ***'
            .format(res['name'],
                 res['target'],
                 res['found']))
    app.wsgi_app = ReverseProxied(app.wsgi_app)
    if os.environ.get('FLASK_DEBUG'):
        cache_buster.init_cache_busting(app)
    log.info('Starting Calibre Web...')
    Principal(app)
    lm.init_app(app)
    app.secret_key = os.getenv('SECRET_KEY', config_sql.get_flask_session_key(ub.session))
    web_server.init_app(app, config)
    db.setup_db(config)
    babel.init_app(app)
    _BABEL_TRANSLATIONS.update(str(item) for item in babel.list_translations())
@@ -110,9 +163,8 @@ def create_app():
 def get_locale():
    # if a user is logged in, use the locale from the user settings
    user = getattr(g, 'user', None)
    # user = None
    if user is not None and hasattr(user, "locale"):
-        if user.nickname != 'Guest':   # if the account is the guest account bypass the config lang settings
+        if user.name != 'Guest':   # if the account is the guest account bypass the config lang settings
            return user.locale
    preferred = list()
@@ -131,6 +183,7 @@ def get_timezone():
    user = getattr(g, 'user', None)
    return user.timezone if user else None
 from .updater import Updater
 updater_thread = Updater()
 updater_thread.start()
@@ -20,7 +20,6 @@
 #  You should have received a copy of the GNU General Public License
 #  along with this program. If not, see <http://www.gnu.org/licenses/>.
 from __future__ import division, print_function, unicode_literals
 import sys
 import platform
 import sqlite3
@@ -29,14 +28,20 @@ from collections import OrderedDict
 import babel, pytz, requests, sqlalchemy
 import werkzeug, flask, flask_login, flask_principal, jinja2
 from flask_babel import gettext as _
 try:
    from flask_wtf import __version__ as flaskwtf_version
 except ImportError:
    flaskwtf_version = _(u'not installed')
 from . import db, calibre_db, converter, uploader, server, isoLanguages, constants, gdriveutils, dep_check
 from .render_template import render_title_template
 from . import db, converter, uploader, server, isoLanguages, constants
 from .web import render_title_template
 try:
    from flask_login import __version__ as flask_loginVersion
 except ImportError:
    from flask_login.__about__ import __version__ as flask_loginVersion
 try:
    # pylint: disable=unused-import
    import unidecode
    # _() necessary to make babel aware of string for translation
    unidecode_version = _(u'installed')
@@ -48,47 +53,93 @@ try:
 except ImportError:
    flask_danceVersion = None
 try:
    from greenlet import __version__ as greenlet_Version
 except ImportError:
    greenlet_Version = None
 try:
    from scholarly import scholarly
    scholarly_version = _(u'installed')
 except ImportError:
    scholarly_version = _(u'not installed')
 from . import services
 about = flask.Blueprint('about', __name__)
 ret = dict()
 req = dep_check.load_dependencys(False)
 opt = dep_check.load_dependencys(True)
 for i in (req + opt):
    ret[i[1]] = i[0]
-_VERSIONS = OrderedDict(
+if constants.NIGHTLY_VERSION[0] == "$Format:%H$":
-    Platform = '{0[0]} {0[2]} {0[3]} {0[4]} {0[5]}'.format(platform.uname()),
+    calibre_web_version = constants.STABLE_VERSION['version']
-    Python=sys.version,
+else:
-    Calibre_Web=constants.STABLE_VERSION['version'] + ' - '
+    calibre_web_version = (constants.STABLE_VERSION['version'] + ' - '
-                + constants.NIGHTLY_VERSION[0].replace('%','%%') + ' - '
+                    + constants.NIGHTLY_VERSION[0].replace('%','%%') + ' - '
-                + constants.NIGHTLY_VERSION[1].replace('%','%%'),
+                    + constants.NIGHTLY_VERSION[1].replace('%','%%'))
-    WebServer=server.VERSION,
+if getattr(sys, 'frozen', False):
-    Flask=flask.__version__,
+    calibre_web_version += " - Exe-Version"
-    Flask_Login=flask_loginVersion,
+elif constants.HOME_CONFIG:
-    Flask_Principal=flask_principal.__version__,
+    calibre_web_version += " - pyPi"
    Werkzeug=werkzeug.__version__,
    Babel=babel.__version__,
    Jinja2=jinja2.__version__,
    Requests=requests.__version__,
    SqlAlchemy=sqlalchemy.__version__,
    pySqlite=sqlite3.version,
    SQLite=sqlite3.sqlite_version,
    iso639=isoLanguages.__version__,
    pytz=pytz.__version__,
    Unidecode = unidecode_version,
    Flask_SimpleLDAP =  u'installed' if bool(services.ldap) else None,
    python_LDAP = services.ldapVersion if bool(services.ldapVersion) else None,
    Goodreads = u'installed' if bool(services.goodreads_support) else None,
    jsonschema = services.SyncToken.__version__  if bool(services.SyncToken) else None,
    flask_dance = flask_danceVersion
 )
 _VERSIONS.update(uploader.get_versions())
 if not ret:
    _VERSIONS = OrderedDict(
        Platform = '{0[0]} {0[2]} {0[3]} {0[4]} {0[5]}'.format(platform.uname()),
        Python=sys.version,
        Calibre_Web=calibre_web_version,
        WebServer=server.VERSION,
        Flask=flask.__version__,
        Flask_Login=flask_loginVersion,
        Flask_Principal=flask_principal.__version__,
        Flask_WTF=flaskwtf_version,
        Werkzeug=werkzeug.__version__,
        Babel=babel.__version__,
        Jinja2=jinja2.__version__,
        Requests=requests.__version__,
        SqlAlchemy=sqlalchemy.__version__,
        pySqlite=sqlite3.version,
        SQLite=sqlite3.sqlite_version,
        iso639=isoLanguages.__version__,
        pytz=pytz.__version__,
        Unidecode=unidecode_version,
        Scholarly=scholarly_version,
        Flask_SimpleLDAP=u'installed' if bool(services.ldap) else None,
        python_LDAP=services.ldapVersion if bool(services.ldapVersion) else None,
        Goodreads=u'installed' if bool(services.goodreads_support) else None,
        jsonschema=services.SyncToken.__version__ if bool(services.SyncToken) else None,
        flask_dance=flask_danceVersion,
        greenlet=greenlet_Version
    )
    _VERSIONS.update(gdriveutils.get_versions())
    _VERSIONS.update(uploader.get_versions(True))
 else:
    _VERSIONS = OrderedDict(
        Platform = '{0[0]} {0[2]} {0[3]} {0[4]} {0[5]}'.format(platform.uname()),
        Python = sys.version,
        Calibre_Web=calibre_web_version,
        Werkzeug = werkzeug.__version__,
        Jinja2=jinja2.__version__,
        pySqlite = sqlite3.version,
        SQLite = sqlite3.sqlite_version,
    )
    _VERSIONS.update(ret)
    _VERSIONS.update(uploader.get_versions(False))
 def collect_stats():
    _VERSIONS['ebook converter'] = _(converter.get_calibre_version())
    _VERSIONS['unrar'] = _(converter.get_unrar_version())
    _VERSIONS['kepubify'] = _(converter.get_kepubify_version())
    return _VERSIONS
@about.route("/stats")
@flask_login.login_required
 def stats():
-    counter = db.session.query(db.Books).count()
+    counter = calibre_db.session.query(db.Books).count()
-    authors = db.session.query(db.Authors).count()
+    authors = calibre_db.session.query(db.Authors).count()
-    categorys = db.session.query(db.Tags).count()
+    categorys = calibre_db.session.query(db.Tags).count()
-    series = db.session.query(db.Series).count()
+    series = calibre_db.session.query(db.Series).count()
-    _VERSIONS['ebook converter'] = _(converter.get_version())
+    return render_title_template('stats.html', bookcounter=counter, authorcounter=authors, versions=collect_stats(),
    return render_title_template('stats.html', bookcounter=counter, authorcounter=authors, versions=_VERSIONS,
                                 categorycounter=categorys, seriecounter=series, title=_(u"Statistics"), page="stat")
@@ -19,7 +19,6 @@
 # Inspired by https://github.com/ChrisTM/Flask-CacheBust
 # Uses query strings so CSS font files are found without having to resort to absolute URLs
 from __future__ import division, print_function, unicode_literals
 import os
 import hashlib
@@ -49,7 +48,7 @@ def init_cache_busting(app):
            # compute version component
            rooted_filename = os.path.join(dirpath, filename)
            with open(rooted_filename, 'rb') as f:
-                file_hash = hashlib.md5(f.read()).hexdigest()[:7]
+                file_hash = hashlib.md5(f.read()).hexdigest()[:7] # nosec
            # save version to tables
            file_path = rooted_filename.replace(static_folder, "")
@@ -64,6 +63,7 @@ def init_cache_busting(app):
        return filename.split("?", 1)[0]
    @app.url_defaults
    # pylint: disable=unused-variable
    def reverse_to_cache_busted_url(endpoint, values):
        """
        Make `url_for` produce busted filenames when using the 'static' endpoint.
@@ -16,7 +16,6 @@
 #   You should have received a copy of the GNU General Public License
 #   along with this program. If not, see <http://www.gnu.org/licenses/>.
 from __future__ import division, print_function, unicode_literals
 import sys
 import os
 import argparse
@@ -45,21 +44,10 @@ parser.add_argument('-v', '--version', action='version', help='Shows version num
                    version=version_info())
 parser.add_argument('-i', metavar='ip-address', help='Server IP-Address to listen')
 parser.add_argument('-s', metavar='user:pass', help='Sets specific username to new password')
 parser.add_argument('-f', action='store_true', help='Flag is depreciated and will be removed in next version')
 parser.add_argument('-l', action='store_true', help='Allow loading covers from localhost')
 args = parser.parse_args()
 if sys.version_info < (3, 0):
    if args.p:
        args.p = args.p.decode('utf-8')
    if args.g:
        args.g = args.g.decode('utf-8')
    if args.k:
        args.k = args.k.decode('utf-8')
    if args.c:
        args.c = args.c.decode('utf-8')
    if args.s:
        args.s = args.s.decode('utf-8')
 settingspath = args.p or os.path.join(_CONFIG_DIR, "app.db")
 gdpath       = args.g or os.path.join(_CONFIG_DIR, "gdrive.db")
@@ -70,7 +58,7 @@ if args.c:
    if os.path.isfile(args.c):
        certfilepath = args.c
    else:
-        print("Certfilepath is invalid. Exiting...")
+        print("Certfile path is invalid. Exiting...")
        sys.exit(1)
 if args.c == "":
@@ -80,7 +68,7 @@ if args.k:
    if os.path.isfile(args.k):
        keyfilepath = args.k
    else:
-        print("Keyfilepath is invalid. Exiting...")
+        print("Keyfile path is invalid. Exiting...")
        sys.exit(1)
 if (args.k and not args.c) or (not args.k and args.c):
@@ -90,23 +78,31 @@ if (args.k and not args.c) or (not args.k and args.c):
 if args.k == "":
    keyfilepath = ""
-# handle and check ipadress argument
+# load covers from localhost
-ipadress = args.i or None
+allow_localhost = args.l or None
-if ipadress:
+# handle and check ip address argument
 ip_address = args.i or None
 if ip_address:
    try:
        # try to parse the given ip address with socket
        if hasattr(socket, 'inet_pton'):
-            if ':' in ipadress:
+            if ':' in ip_address:
-                socket.inet_pton(socket.AF_INET6, ipadress)
+                socket.inet_pton(socket.AF_INET6, ip_address)
            else:
-                socket.inet_pton(socket.AF_INET, ipadress)
+                socket.inet_pton(socket.AF_INET, ip_address)
        else:
            # on windows python < 3.4, inet_pton is not available
            # inet_atom only handles IPv4 addresses
-            socket.inet_aton(ipadress)
+            socket.inet_aton(ip_address)
    except socket.error as err:
-        print(ipadress, ':', err)
+        print(ip_address, ':', err)
        sys.exit(1)
 # handle and check user password argument
-user_password = args.s or None
+user_credentials = args.s or None
 if user_credentials and ":" not in user_credentials:
    print("No valid 'username:password' format")
    sys.exit(3)
 if args.f:
    print("Warning: -f flag is depreciated and will be removed in next version")
@@ -16,7 +16,6 @@
 #   You should have received a copy of the GNU General Public License
 #   along with this program. If not, see <http://www.gnu.org/licenses/>.
 from __future__ import division, print_function, unicode_literals
 import os
 from . import logger, isoLanguages
@@ -26,80 +25,109 @@ from .constants import BookMeta
 log = logger.create()
 try:
    from wand.image import Image
    use_IM = True
 except (ImportError, RuntimeError) as e:
    use_IM = False
 try:
    from comicapi.comicarchive import ComicArchive, MetaDataStyle
    use_comic_meta = True
-except ImportError as e:
+    try:
-    log.debug('cannot import comicapi, extracting comic metadata will not work: %s', e)
+        from comicapi import __version__ as comic_version
    except ImportError:
        comic_version = ''
 except (ImportError, LookupError) as e:
    log.debug('Cannot import comicapi, extracting comic metadata will not work: %s', e)
    import zipfile
    import tarfile
    try:
        import rarfile
        use_rarfile = True
-    except ImportError as e:
+    except (ImportError, SyntaxError) as e:
-        log.debug('cannot import rarfile, extracting cover files from rar files will not work: %s', e)
+        log.debug('Cannot import rarfile, extracting cover files from rar files will not work: %s', e)
        use_rarfile = False
    use_comic_meta = False
 NO_JPEG_EXTENSIONS = ['.png', '.webp', '.bmp']
 COVER_EXTENSIONS = ['.png', '.webp', '.bmp', '.jpg', '.jpeg']
-def _extractCover(tmp_file_name, original_file_extension, rarExceutable):
+def _cover_processing(tmp_file_name, img, extension):
    tmp_cover_name = os.path.join(os.path.dirname(tmp_file_name), 'cover.jpg')
    if extension in NO_JPEG_EXTENSIONS:
        if use_IM:
            with Image(blob=img) as imgc:
                imgc.format = 'jpeg'
                imgc.transform_colorspace('rgb')
                imgc.save(filename=tmp_cover_name)
                return tmp_cover_name
        else:
            return None
    if img:
        with open(tmp_cover_name, 'wb') as f:
            f.write(img)
        return tmp_cover_name
    else:
        return None
 def _extract_Cover_from_archive(original_file_extension, tmp_file_name, rarExecutable):
    cover_data = extension = None
-    if use_comic_meta:
+    if original_file_extension.upper() == '.CBZ':
-        archive = ComicArchive(tmp_file_name)
+        cf = zipfile.ZipFile(tmp_file_name)
-        for index, name in enumerate(archive.getPageNameList()):
+        for name in cf.namelist():
            ext = os.path.splitext(name)
            if len(ext) > 1:
                extension = ext[1].lower()
-                if extension == '.jpg' or extension == '.jpeg':
+                if extension in COVER_EXTENSIONS:
-                    cover_data = archive.getPage(index)
+                    cover_data = cf.read(name)
                    break
-    else:
+    elif original_file_extension.upper() == '.CBT':
-        if original_file_extension.upper() == '.CBZ':
+        cf = tarfile.TarFile(tmp_file_name)
-            cf = zipfile.ZipFile(tmp_file_name)
+        for name in cf.getnames():
-            for name in cf.namelist():
+            ext = os.path.splitext(name)
-                ext = os.path.splitext(name)
+            if len(ext) > 1:
-                if len(ext) > 1:
+                extension = ext[1].lower()
-                    extension = ext[1].lower()
+                if extension in COVER_EXTENSIONS:
-                    if extension == '.jpg' or extension == '.jpeg':
+                    cover_data = cf.extractfile(name).read()
-                        cover_data = cf.read(name)
+                    break
-                        break
+    elif original_file_extension.upper() == '.CBR' and use_rarfile:
-        elif original_file_extension.upper() == '.CBT':
+        try:
-            cf = tarfile.TarFile(tmp_file_name)
+            rarfile.UNRAR_TOOL = rarExecutable
            cf = rarfile.RarFile(tmp_file_name)
            for name in cf.getnames():
                ext = os.path.splitext(name)
                if len(ext) > 1:
                    extension = ext[1].lower()
-                    if extension == '.jpg' or extension == '.jpeg':
+                    if extension in COVER_EXTENSIONS:
-                        cover_data = cf.extractfile(name).read()
+                        cover_data = cf.read(name)
                        break
-        elif original_file_extension.upper() == '.CBR' and use_rarfile:
+        except Exception as ex:
-            try:
+            log.debug('Rarfile failed with error: %s', ex)
-                rarfile.UNRAR_TOOL = rarExceutable
+    return cover_data, extension
                cf = rarfile.RarFile(tmp_file_name)
                for name in cf.getnames():
                    ext = os.path.splitext(name)
                    if len(ext) > 1:
                        extension = ext[1].lower()
                        if extension == '.jpg' or extension == '.jpeg':
                            cover_data = cf.read(name)
                            break
            except Exception as e:
                log.debug('Rarfile failed with error: %s', e)
    prefix = os.path.dirname(tmp_file_name)
    if cover_data:
        tmp_cover_name = prefix + '/cover' + extension
        image = open(tmp_cover_name, 'wb')
        image.write(cover_data)
        image.close()
    else:
        tmp_cover_name = None
    return tmp_cover_name
-def get_comic_info(tmp_file_path, original_file_name, original_file_extension, rarExceutable):
+def _extractCover(tmp_file_name, original_file_extension, rarExecutable):
    cover_data = extension = None
    if use_comic_meta:
-        archive = ComicArchive(tmp_file_path, rar_exe_path=rarExceutable)
+        archive = ComicArchive(tmp_file_name, rar_exe_path=rarExecutable)
        for index, name in enumerate(archive.getPageNameList()):
            ext = os.path.splitext(name)
            if len(ext) > 1:
                extension = ext[1].lower()
                if extension in COVER_EXTENSIONS:
                    cover_data = archive.getPage(index)
                    break
    else:
        cover_data, extension = _extract_Cover_from_archive(original_file_extension, tmp_file_name, rarExecutable)
    return _cover_processing(tmp_file_name, cover_data, extension)
 def get_comic_info(tmp_file_path, original_file_name, original_file_extension, rarExecutable):
    if use_comic_meta:
        archive = ComicArchive(tmp_file_path, rar_exe_path=rarExecutable)
        if archive.seemsToBeAComicArchive():
            if archive.hasMetadata(MetaDataStyle.CIX):
                style = MetaDataStyle.CIX
@@ -111,35 +139,32 @@ def get_comic_info(tmp_file_path, original_file_name, original_file_extension, r
            # if style is not None:
            loadedMetadata = archive.readMetadata(style)
-            lang = loadedMetadata.language
+            lang = loadedMetadata.language or ""
-            if lang:
+            loadedMetadata.language = isoLanguages.get_lang3(lang)
                if len(lang) == 2:
                     loadedMetadata.language = isoLanguages.get(part1=lang).name
                elif len(lang) == 3:
                     loadedMetadata.language = isoLanguages.get(part3=lang).name
            else:
                 loadedMetadata.language = ""
            return BookMeta(
                file_path=tmp_file_path,
                extension=original_file_extension,
                title=loadedMetadata.title or original_file_name,
-                author=" & ".join([credit["person"] for credit in loadedMetadata.credits if credit["role"] == "Writer"]) or u'Unknown',
+                author=" & ".join([credit["person"]
-                cover=_extractCover(tmp_file_path, original_file_extension, rarExceutable),
+                                   for credit in loadedMetadata.credits if credit["role"] == "Writer"]) or u'Unknown',
                cover=_extractCover(tmp_file_path, original_file_extension, rarExecutable),
                description=loadedMetadata.comments or "",
                tags="",
                series=loadedMetadata.series or "",
                series_id=loadedMetadata.issue or "",
-                languages=loadedMetadata.language)
+                languages=loadedMetadata.language,
                publisher="")
    return BookMeta(
        file_path=tmp_file_path,
        extension=original_file_extension,
        title=original_file_name,
        author=u'Unknown',
-        cover=_extractCover(tmp_file_path, original_file_extension, rarExceutable),
+        cover=_extractCover(tmp_file_path, original_file_extension, rarExecutable),
        description="",
        tags="",
        series="",
        series_id="",
-        languages="")
+        languages="",
        publisher="")
@@ -16,16 +16,20 @@
 #   You should have received a copy of the GNU General Public License
 #   along with this program. If not, see <http://www.gnu.org/licenses/>.
 from __future__ import division, print_function, unicode_literals
 import os
 import json
 import sys
 import json
-from sqlalchemy import exc, Column, String, Integer, SmallInteger, Boolean, BLOB
+from sqlalchemy import Column, String, Integer, SmallInteger, Boolean, BLOB, JSON
-from sqlalchemy.ext.declarative import declarative_base
+from sqlalchemy.exc import OperationalError
 from sqlalchemy.sql.expression import text
 try:
    # Compatibility with sqlalchemy 2.0
    from sqlalchemy.orm import declarative_base
 except ImportError:
    from sqlalchemy.ext.declarative import declarative_base
-from . import constants, cli, logger, ub
+from . import constants, cli, logger
 log = logger.create()
@@ -35,7 +39,7 @@ class _Flask_Settings(_Base):
    __tablename__ = 'flask_settings'
    id = Column(Integer, primary_key=True)
-    flask_session_key = Column(BLOB, default="")
+    flask_session_key = Column(BLOB, default=b"")
    def __init__(self, key):
        self.flask_session_key = key
@@ -53,18 +57,22 @@ class _Settings(_Base):
    mail_login = Column(String, default='mail@example.com')
    mail_password = Column(String, default='mypassword')
    mail_from = Column(String, default='automailer <mail@example.com>')
    mail_size = Column(Integer, default=25*1024*1024)
    mail_server_type = Column(SmallInteger, default=0)
    mail_gmail_token = Column(JSON, default={})
    config_calibre_dir = Column(String)
    config_port = Column(Integer, default=constants.DEFAULT_PORT)
    config_external_port = Column(Integer, default=constants.DEFAULT_PORT)
    config_certfile = Column(String)
    config_keyfile = Column(String)
-
+    config_trustedhosts = Column(String,default='')
    config_calibre_web_title = Column(String, default=u'Calibre-Web')
    config_books_per_page = Column(Integer, default=60)
    config_random_books = Column(Integer, default=4)
    config_authors_max = Column(Integer, default=0)
    config_read_column = Column(Integer, default=0)
-    config_title_regex = Column(String, default=u'^(A|The|An|Der|Die|Das|Den|Ein|Eine|Einen|Dem|Des|Einem|Eines)\s+')
+    config_title_regex = Column(String, default=r'^(A|The|An|Der|Die|Das|Den|Ein|Eine|Einen|Dem|Des|Einem|Eines)\s+')
    config_mature_content_tags = Column(String, default='')
    config_theme = Column(Integer, default=0)
@@ -81,6 +89,8 @@ class _Settings(_Base):
    config_default_role = Column(SmallInteger, default=0)
    config_default_show = Column(SmallInteger, default=constants.ADMIN_USER_SIDEBAR)
    config_default_language = Column(String(3), default="all")
    config_default_locale = Column(String(2), default="en")
    config_columns_to_ignore = Column(String)
    config_denied_tags = Column(String, default="")
@@ -91,35 +101,39 @@ class _Settings(_Base):
    config_use_google_drive = Column(Boolean, default=False)
    config_google_drive_folder = Column(String)
-    config_google_drive_watch_changes_response = Column(String)
+    config_google_drive_watch_changes_response = Column(JSON, default={})
    config_use_goodreads = Column(Boolean, default=False)
    config_goodreads_api_key = Column(String)
    config_goodreads_api_secret = Column(String)
-
+    config_register_email = Column(Boolean, default=False)
    config_login_type = Column(Integer, default=0)
    config_kobo_proxy = Column(Boolean, default=False)
    config_ldap_provider_url = Column(String, default='example.org')
    config_ldap_port = Column(SmallInteger, default=389)
    config_ldap_authentication = Column(SmallInteger, default=constants.LDAP_AUTH_SIMPLE)
    config_ldap_serv_username = Column(String, default='cn=admin,dc=example,dc=org')
    config_ldap_serv_password = Column(String, default="")
    config_ldap_encryption = Column(SmallInteger, default=0)
    config_ldap_cacert_path = Column(String, default="")
    config_ldap_cert_path = Column(String, default="")
    config_ldap_key_path = Column(String, default="")
    config_ldap_dn = Column(String, default='dc=example,dc=org')
    config_ldap_user_object = Column(String, default='uid=%s')
    config_ldap_member_user_object = Column(String, default='') #
    config_ldap_openldap = Column(Boolean, default=True)
    config_ldap_group_object_filter = Column(String, default='(&(objectclass=posixGroup)(cn=%s))')
    config_ldap_group_members_field = Column(String, default='memberUid')
    config_ldap_group_name = Column(String, default='calibreweb')
-    config_ebookconverter = Column(Integer, default=0)
+    config_kepubifypath = Column(String, default=None)
-    config_converterpath = Column(String)
+    config_converterpath = Column(String, default=None)
    config_calibre = Column(String)
-    config_rarfile_location = Column(String)
+    config_rarfile_location = Column(String, default=None)
    config_upload_formats = Column(String, default=','.join(constants.EXTENSIONS_UPLOAD))
    config_unicode_filename =Column(Boolean, default=False)
    config_updatechannel = Column(Integer, default=constants.UPDATE_STABLE)
@@ -140,6 +154,23 @@ class _ConfigSQL(object):
        self.config_calibre_dir = None
        self.load()
        change = False
        if self.config_converterpath == None:  # pylint: disable=access-member-before-definition
            change = True
            self.config_converterpath = autodetect_calibre_binary()
        if self.config_kepubifypath == None:  # pylint: disable=access-member-before-definition
            change = True
            self.config_kepubifypath = autodetect_kepubify_binary()
        if self.config_rarfile_location == None:  # pylint: disable=access-member-before-definition
            change = True
            self.config_rarfile_location = autodetect_unrar_binary()
        if change:
            self.save()
    def _read_from_storage(self):
        if self._settings is None:
            log.debug("_ConfigSQL._read_from_storage")
@@ -160,8 +191,9 @@ class _ConfigSQL(object):
            return None
        return self.config_keyfile
-    def get_config_ipaddress(self):
+    @staticmethod
-        return cli.ipadress or ""
+    def get_config_ipaddress():
        return cli.ip_address or ""
    def _has_role(self, role_flag):
        return constants.has_flag(self.config_default_role, role_flag)
@@ -197,20 +229,20 @@ class _ConfigSQL(object):
        return self.show_element_new_user(constants.DETAIL_RANDOM)
    def list_denied_tags(self):
-        mct = self.config_denied_tags.split(",")
+        mct = self.config_denied_tags or ""
-        return [t.strip() for t in mct]
+        return [t.strip() for t in mct.split(",")]
    def list_allowed_tags(self):
-        mct = self.config_allowed_tags.split(",")
+        mct = self.config_allowed_tags or ""
-        return [t.strip() for t in mct]
+        return [t.strip() for t in mct.split(",")]
    def list_denied_column_values(self):
-        mct = self.config_denied_column_value.split(",")
+        mct = self.config_denied_column_value or ""
-        return [t.strip() for t in mct]
+        return [t.strip() for t in mct.split(",")]
    def list_allowed_column_values(self):
-        mct = self.config_allowed_column_value.split(",")
+        mct = self.config_allowed_column_value or ""
-        return [t.strip() for t in mct]
+        return [t.strip() for t in mct.split(",")]
    def get_log_level(self):
        return logger.get_level_name(self.config_log_level)
@@ -219,18 +251,18 @@ class _ConfigSQL(object):
        return {k:v for k, v in self.__dict__.items() if k.startswith('mail_')}
    def get_mail_server_configured(self):
-        return not bool(self.mail_server == constants.DEFAULT_MAIL_SERVER)
+        return bool((self.mail_server != constants.DEFAULT_MAIL_SERVER and self.mail_server_type == 0)
                    or (self.mail_gmail_token != {} and self.mail_server_type == 1))
    def set_from_dictionary(self, dictionary, field, convertor=None, default=None, encode=None):
-        '''Possibly updates a field of this object.
+        """Possibly updates a field of this object.
        The new value, if present, is grabbed from the given dictionary, and optionally passed through a convertor.
        :returns: `True` if the field has changed value
-        '''
+        """
        new_value = dictionary.get(field, default)
        if new_value is None:
            # log.debug("_ConfigSQL set_from_dictionary field '%s' not found", field)
            return False
        if field not in self.__dict__:
@@ -247,10 +279,17 @@ class _ConfigSQL(object):
        if current_value == new_value:
            return False
        # log.debug("_ConfigSQL set_from_dictionary '%s' = %r (was %r)", field, new_value, current_value)
        setattr(self, field, new_value)
        return True
    def toDict(self):
        storage = {}
        for k, v in self.__dict__.items():
            if k[0] != '_' and not k.endswith("password") and not k.endswith("secret"):
                storage[k] = v
        return storage
    def load(self):
        '''Load all configuration values from the underlying storage.'''
        s = self._read_from_storage()  # type: _Settings
@@ -263,17 +302,27 @@ class _ConfigSQL(object):
                        v = column.default.arg
                setattr(self, k, v)
        if self.config_google_drive_watch_changes_response:
            self.config_google_drive_watch_changes_response = json.loads(self.config_google_drive_watch_changes_response)
        have_metadata_db = bool(self.config_calibre_dir)
        if have_metadata_db:
            if not self.config_use_google_drive:
                db_file = os.path.join(self.config_calibre_dir, 'metadata.db')
                have_metadata_db = os.path.isfile(db_file)
        self.db_configured = have_metadata_db
-
+        constants.EXTENSIONS_UPLOAD = [x.lstrip().rstrip().lower() for x in self.config_upload_formats.split(',')]
-        logger.setup(self.config_logfile, self.config_log_level)
+        if os.environ.get('FLASK_DEBUG'):
            logfile = logger.setup(logger.LOG_TO_STDOUT, logger.logging.DEBUG)
        else:
            # pylint: disable=access-member-before-definition
            logfile = logger.setup(self.config_logfile, self.config_log_level)
        if logfile != self.config_logfile:
            log.warning("Log path %s not valid, falling back to default", self.config_logfile)
            self.config_logfile = logfile
            self._session.merge(s)
            try:
                self._session.commit()
            except OperationalError as e:
                log.error('Database error: %s', e)
                self._session.rollback()
    def save(self):
        '''Apply all configuration values to the underlying storage.'''
@@ -287,7 +336,11 @@ class _ConfigSQL(object):
        log.debug("_ConfigSQL updating storage")
        self._session.merge(s)
-        self._session.commit()
+        try:
            self._session.commit()
        except OperationalError as e:
            log.error('Database error: %s', e)
            self._session.rollback()
        self.load()
    def invalidate(self, error=None):
@@ -295,7 +348,7 @@ class _ConfigSQL(object):
            log.error(error)
        log.warning("invalidating configuration")
        self.db_configured = False
-        self.config_calibre_dir = None
+        # self.config_calibre_dir = None
        self.save()
@@ -306,41 +359,71 @@ def _migrate_table(session, orm_class):
        if column_name[0] != '_':
            try:
                session.query(column).first()
-            except exc.OperationalError as err:
+            except OperationalError as err:
                log.debug("%s: %s", column_name, err.args[0])
                if column.default is not None:
                    if sys.version_info < (3, 0):
                        if isinstance(column.default.arg, unicode):
                            column.default.arg = column.default.arg.encode('utf-8')
                if column.default is None:
                    column_default = ""
                else:
                    if isinstance(column.default.arg, bool):
-                        column_default = ("DEFAULT %r" % int(column.default.arg))
+                        column_default = "DEFAULT {}".format(int(column.default.arg))
                    else:
-                        column_default = ("DEFAULT %r" % column.default.arg)
+                        column_default = "DEFAULT `{}`".format(column.default.arg)
-                alter_table = "ALTER TABLE %s ADD COLUMN `%s` %s %s" % (orm_class.__tablename__,
+                if isinstance(column.type, JSON):
                    column_type = "JSON"
                else:
                    column_type = column.type
                alter_table = text("ALTER TABLE %s ADD COLUMN `%s` %s %s" % (orm_class.__tablename__,
                                                                        column_name,
-                                                                        column.type,
+                                                                        column_type,
-                                                                        column_default)
+                                                                        column_default))
                log.debug(alter_table)
                session.execute(alter_table)
                changed = True
            except json.decoder.JSONDecodeError as e:
                log.error("Database corrupt column: {}".format(column_name))
                log.debug(e)
    if changed:
-        session.commit()
+        try:
            session.commit()
        except OperationalError:
            session.rollback()
 def autodetect_calibre_binary():
    if sys.platform == "win32":
-        calibre_path = ["C:\\program files\calibre\calibre-convert.exe",
+        calibre_path = ["C:\\program files\\calibre\\ebook-convert.exe",
-                        "C:\\program files(x86)\calibre\calibre-convert.exe"]
+                        "C:\\program files(x86)\\calibre\\ebook-convert.exe",
                        "C:\\program files(x86)\\calibre2\\ebook-convert.exe",
                        "C:\\program files\\calibre2\\ebook-convert.exe"]
    else:
        calibre_path = ["/opt/calibre/ebook-convert"]
    for element in calibre_path:
        if os.path.isfile(element) and os.access(element, os.X_OK):
            return element
-    return None
+    return ""
 def autodetect_unrar_binary():
    if sys.platform == "win32":
        calibre_path = ["C:\\program files\\WinRar\\unRAR.exe",
                        "C:\\program files(x86)\\WinRar\\unRAR.exe"]
    else:
        calibre_path = ["/usr/bin/unrar"]
    for element in calibre_path:
        if os.path.isfile(element) and os.access(element, os.X_OK):
            return element
    return ""
 def autodetect_kepubify_binary():
    if sys.platform == "win32":
        calibre_path = ["C:\\program files\\kepubify\\kepubify-windows-64Bit.exe",
                        "C:\\program files(x86)\\kepubify\\kepubify-windows-64Bit.exe"]
    else:
        calibre_path = ["/opt/kepubify/kepubify-linux-64bit", "/opt/kepubify/kepubify-linux-32bit"]
    for element in calibre_path:
        if os.path.isfile(element) and os.access(element, os.X_OK):
            return element
    return ""
 def _migrate_database(session):
    # make sure the table is created, if it does not exist
@@ -357,12 +440,12 @@ def load_configuration(session):
        session.commit()
    conf = _ConfigSQL(session)
    # Migrate from global restrictions to user based restrictions
-    if bool(conf.config_default_show & constants.MATURE_CONTENT) and conf.config_denied_tags == "":
+    #if bool(conf.config_default_show & constants.MATURE_CONTENT) and conf.config_denied_tags == "":
-        conf.config_denied_tags = conf.config_mature_content_tags
+    #    conf.config_denied_tags = conf.config_mature_content_tags
-        conf.save()
+    #    conf.save()
-        session.query(ub.User).filter(ub.User.mature_content != True). \
+    #    session.query(ub.User).filter(ub.User.mature_content != True). \
-            update({"denied_tags": conf.config_mature_content_tags}, synchronize_session=False)
+    #        update({"denied_tags": conf.config_mature_content_tags}, synchronize_session=False)
-        session.commit()
+    #    session.commit()
    return conf
 def get_flask_session_key(session):
@@ -16,20 +16,21 @@
 #   You should have received a copy of the GNU General Public License
 #   along with this program. If not, see <http://www.gnu.org/licenses/>.
 from __future__ import division, print_function, unicode_literals
 import sys
 import os
 from collections import namedtuple
 from sqlalchemy import __version__ as sql_version
-HOME_CONFIG = False
+sqlalchemy_version2 = ([int(x) for x in sql_version.split('.')] >= [2,0,0])
 # if installed via pip this variable is set to true (empty file with name .HOMEDIR present)
 HOME_CONFIG = os.path.isfile(os.path.join(os.path.dirname(os.path.abspath(__file__)), '.HOMEDIR'))
 #In executables updater is not available, so variable is set to False there
 UPDATER_AVAILABLE = True
 # Base dir is parent of current file, necessary if called from different folder
-if sys.version_info < (3, 0):
+BASE_DIR            = os.path.abspath(os.path.join(os.path.dirname(os.path.abspath(__file__)),os.pardir))
    BASE_DIR            = os.path.abspath(os.path.join(
        os.path.dirname(os.path.abspath(__file__)),os.pardir)).decode('utf-8')
 else:
    BASE_DIR            = os.path.abspath(os.path.join(
        os.path.dirname(os.path.abspath(__file__)),os.pardir))
 STATIC_DIR          = os.path.join(BASE_DIR, 'cps', 'static')
 TEMPLATES_DIR       = os.path.join(BASE_DIR, 'cps', 'templates')
 TRANSLATIONS_DIR    = os.path.join(BASE_DIR, 'cps', 'translations')
@@ -40,7 +41,7 @@ if HOME_CONFIG:
        os.makedirs(home_dir)
    CONFIG_DIR = os.environ.get('CALIBRE_DBPATH', home_dir)
 else:
-    CONFIG_DIR      = os.environ.get('CALIBRE_DBPATH', BASE_DIR)
+    CONFIG_DIR = os.environ.get('CALIBRE_DBPATH', BASE_DIR)
 ROLE_USER               = 0 << 0
@@ -81,9 +82,31 @@ SIDEBAR_PUBLISHER       = 1 << 12
 SIDEBAR_RATING          = 1 << 13
 SIDEBAR_FORMAT          = 1 << 14
 SIDEBAR_ARCHIVED        = 1 << 15
 SIDEBAR_DOWNLOAD        = 1 << 16
 SIDEBAR_LIST            = 1 << 17
 sidebar_settings = {
                "detail_random": DETAIL_RANDOM,
                "sidebar_language": SIDEBAR_LANGUAGE,
                "sidebar_series": SIDEBAR_SERIES,
                "sidebar_category": SIDEBAR_CATEGORY,
                "sidebar_random": SIDEBAR_RANDOM,
                "sidebar_author": SIDEBAR_AUTHOR,
                "sidebar_best_rated": SIDEBAR_BEST_RATED,
                "sidebar_read_and_unread": SIDEBAR_READ_AND_UNREAD,
                "sidebar_recent": SIDEBAR_RECENT,
                "sidebar_sorted": SIDEBAR_SORTED,
                "sidebar_publisher": SIDEBAR_PUBLISHER,
                "sidebar_rating": SIDEBAR_RATING,
                "sidebar_format": SIDEBAR_FORMAT,
                "sidebar_archived": SIDEBAR_ARCHIVED,
                "sidebar_download": SIDEBAR_DOWNLOAD,
                "sidebar_list": SIDEBAR_LIST,
            }
 ADMIN_USER_ROLES        = sum(r for r in ALL_ROLES.values()) & ~ROLE_ANONYMOUS
-ADMIN_USER_SIDEBAR      = (SIDEBAR_ARCHIVED << 1) - 1
+ADMIN_USER_SIDEBAR      = (SIDEBAR_LIST << 1) - 1
 UPDATE_STABLE       = 0 << 0
 AUTO_UPDATE_STABLE  = 1 << 0
@@ -100,7 +123,7 @@ LDAP_AUTH_SIMPLE         = 0
 DEFAULT_MAIL_SERVER = "mail.example.org"
-DEFAULT_PASSWORD    = "admin123"
+DEFAULT_PASSWORD    = "admin123"  # nosec
 DEFAULT_PORT        = 8083
 env_CALIBRE_PORT = os.environ.get("CALIBRE_PORT", DEFAULT_PORT)
 try:
@@ -110,12 +133,11 @@ except ValueError:
 del env_CALIBRE_PORT
-EXTENSIONS_AUDIO    = {'mp3', 'm4a', 'm4b'}
+EXTENSIONS_AUDIO    = {'mp3', 'mp4', 'ogg', 'opus', 'wav', 'flac', 'm4a', 'm4b'}
-EXTENSIONS_CONVERT  = {'pdf', 'epub', 'mobi', 'azw3', 'docx', 'rtf', 'fb2', 'lit', 'lrf', 'txt', 'htmlz', 'rtf', 'odt'}
+EXTENSIONS_CONVERT_FROM  = ['pdf', 'epub', 'mobi', 'azw3', 'docx', 'rtf', 'fb2', 'lit', 'lrf', 'txt', 'htmlz', 'rtf', 'odt','cbz','cbr']
-EXTENSIONS_UPLOAD   = {'txt', 'pdf', 'epub', 'mobi', 'azw', 'azw3', 'cbr', 'cbz', 'cbt', 'djvu', 'prc', 'doc', 'docx',
+EXTENSIONS_CONVERT_TO  = ['pdf', 'epub', 'mobi', 'azw3', 'docx', 'rtf', 'fb2', 'lit', 'lrf', 'txt', 'htmlz', 'rtf', 'odt']
-                       'fb2', 'html', 'rtf', 'lit', 'odt', 'mp3',  'm4a', 'm4b'}
+EXTENSIONS_UPLOAD   = {'txt', 'pdf', 'epub', 'kepub', 'mobi', 'azw', 'azw3', 'cbr', 'cbz', 'cbt', 'djvu', 'prc', 'doc', 'docx',
-# EXTENSIONS_READER = set(['txt', 'pdf', 'epub', 'zip', 'cbz', 'tar', 'cbt'] +
+                       'fb2', 'html', 'rtf', 'lit', 'odt', 'mp3', 'mp4', 'ogg', 'opus', 'wav', 'flac', 'm4a', 'm4b'}
 #                         (['rar','cbr'] if feature_support['rar'] else []))
 def has_flag(value, bit_flag):
@@ -127,9 +149,9 @@ def selected_roles(dictionary):
 # :rtype: BookMeta
 BookMeta = namedtuple('BookMeta', 'file_path, extension, title, author, cover, description, tags, series, '
-                                  'series_id, languages')
+                                  'series_id, languages, publisher')
-STABLE_VERSION = {'version': '0.6.7'}
+STABLE_VERSION = {'version': '0.6.16'}
 NIGHTLY_VERSION = {}
 NIGHTLY_VERSION[0] = '$Format:%H$'
@@ -16,7 +16,6 @@
 #  You should have received a copy of the GNU General Public License
 #  along with this program. If not, see <http://www.gnu.org/licenses/>.
 from __future__ import division, print_function, unicode_literals
 import os
 import re
 from flask_babel import gettext as _
@@ -29,8 +28,8 @@ log = logger.create()
 # _() necessary to make babel aware of string for translation
 _NOT_CONFIGURED = _('not configured')
-_NOT_INSTALLED = 'not installed'
+_NOT_INSTALLED = _('not installed')
-_EXECUTION_ERROR = 'Execution permissions missing'
+_EXECUTION_ERROR = _('Execution permissions missing')
 def _get_command_version(path, pattern, argument=None):
@@ -39,19 +38,24 @@ def _get_command_version(path, pattern, argument=None):
        if argument:
            command.append(argument)
        try:
-            for line in process_wait(command):
+            match = process_wait(command, pattern=pattern)
-                if re.search(pattern, line):
+            if isinstance(match, re.Match):
-                    return line
+                return match.string
        except Exception as ex:
            log.warning("%s: %s", path, ex)
            return _EXECUTION_ERROR
    return _NOT_INSTALLED
-def get_version():
+def get_calibre_version():
-    version = None
+    return _get_command_version(config.config_converterpath, r'ebook-convert.*\(calibre', '--version') \
-    if config.config_ebookconverter == 1:
+           or _NOT_CONFIGURED
-        version = _get_command_version(config.config_converterpath, r'Amazon kindlegen\(')
+
-    elif config.config_ebookconverter == 2:
+
-        version = _get_command_version(config.config_converterpath, r'ebook-convert.*\(calibre', '--version')
+def get_unrar_version():
-    return version or _NOT_CONFIGURED
+    return _get_command_version(config.config_rarfile_location, r'UNRAR.*\d') or _NOT_CONFIGURED
 def get_kepubify_version():
    return _get_command_version(config.config_kepubifypath, r'kepubify\s','--version') or _NOT_CONFIGURED
@@ -0,0 +1,72 @@
 # -*- coding: utf-8 -*-
 #  This file is part of the Calibre-Web (https://github.com/janeczku/calibre-web)
 #    Copyright (C) 2012-2019 cervinko, idalin, SiphonSquirrel, ouzklcn, akushsky,
 #                            OzzieIsaacs, bodybybuddha, jkrehm, matthazinski, janeczku
 #
 #  This program is free software: you can redistribute it and/or modify
 #  it under the terms of the GNU General Public License as published by
 #  the Free Software Foundation, either version 3 of the License, or
 #  (at your option) any later version.
 #
 #  This program is distributed in the hope that it will be useful,
 #  but WITHOUT ANY WARRANTY; without even the implied warranty of
 #  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 #  GNU General Public License for more details.
 #
 #  You should have received a copy of the GNU General Public License
 #  along with this program. If not, see <http://www.gnu.org/licenses/>.
 import shutil
 import glob
 import zipfile
 import json
 from io import BytesIO
 import os
 from flask import send_file, __version__
 from . import logger, config
 from .about import collect_stats
 log = logger.create()
 def assemble_logfiles(file_name):
    log_list = sorted(glob.glob(file_name + '*'), reverse=True)
    wfd = BytesIO()
    for f in log_list:
        with open(f, 'rb') as fd:
            shutil.copyfileobj(fd, wfd)
    wfd.seek(0)
    if int(__version__.split('.')[0]) < 2:
        return send_file(wfd,
                         as_attachment=True,
                         attachment_filename=os.path.basename(file_name))
    else:
        return send_file(wfd,
                         as_attachment=True,
                         download_name=os.path.basename(file_name))
 def send_debug():
    file_list = glob.glob(logger.get_logfile(config.config_logfile) + '*')
    file_list.extend(glob.glob(logger.get_accesslogfile(config.config_access_logfile) + '*'))
    for element in [logger.LOG_TO_STDOUT, logger.LOG_TO_STDERR]:
        if element in file_list:
            file_list.remove(element)
    memory_zip = BytesIO()
    with zipfile.ZipFile(memory_zip, 'w', compression=zipfile.ZIP_DEFLATED) as zf:
        zf.writestr('settings.txt', json.dumps(config.toDict()))
        zf.writestr('libs.txt', json.dumps(collect_stats()))
        for fp in file_list:
            zf.write(fp, os.path.basename(fp))
    memory_zip.seek(0)
    if int(__version__.split('.')[0]) < 2:
        return send_file(memory_zip,
                         as_attachment=True,
                         attachment_filename="Calibre-Web-debug-pack.zip")
    else:
        return send_file(memory_zip,
                         as_attachment=True,
                         download_name="Calibre-Web-debug-pack.zip")
@@ -0,0 +1,96 @@
 import os
 import re
 from .constants import BASE_DIR
 try:
    from importlib_metadata import version
    importlib = True
    ImportNotFound = BaseException
 except ImportError:
    importlib = False
 if not importlib:
    try:
        import pkg_resources
        from pkg_resources import DistributionNotFound as ImportNotFound
        pkgresources = True
    except ImportError as e:
        pkgresources = False
 def load_dependencys(optional=False):
    deps = list()
    if importlib or pkgresources:
        if optional:
            req_path = os.path.join(BASE_DIR, "optional-requirements.txt")
        else:
            req_path = os.path.join(BASE_DIR, "requirements.txt")
        if os.path.exists(req_path):
            with open(req_path, 'r') as f:
                for line in f:
                    if not line.startswith('#') and not line == '\n' and not line.startswith('git'):
                        res = re.match(r'(.*?)([<=>\s]+)([\d\.]+),?\s?([<=>\s]+)?([\d\.]+)?', line.strip())
                        try:
                            if importlib:
                                dep_version = version(res.group(1))
                            else:
                                dep_version = pkg_resources.get_distribution(res.group(1)).version
                        except ImportNotFound:
                            if optional:
                                continue
                            dep_version = "not installed"
                        deps.append([dep_version, res.group(1), res.group(2), res.group(3), res.group(4), res.group(5)])
    return deps
 def dependency_check(optional=False):
    d = list()
    deps = load_dependencys(optional)
    for dep in deps:
        try:
            dep_version_int = [int(x) for x in dep[0].split('.')]
            low_check = [int(x) for x in dep[3].split('.')]
            high_check = [int(x) for x in dep[5].split('.')]
        except AttributeError:
            high_check = None
        except ValueError:
            d.append({'name': dep[1],
                     'target': "available",
                     'found': "Not available"
                     })
            continue
        if dep[2].strip() == "==":
            if dep_version_int != low_check:
                d.append({'name': dep[1],
                            'found': dep[0],
                            "target": dep[2] + dep[3]})
                continue
        elif dep[2].strip() == ">=":
            if dep_version_int < low_check:
                d.append({'name': dep[1],
                            'found': dep[0],
                            "target": dep[2] + dep[3]})
                continue
        elif dep[2].strip() == ">":
            if dep_version_int <= low_check:
                d.append({'name': dep[1],
                            'found': dep[0],
                            "target": dep[2] + dep[3]})
                continue
        if dep[4] and dep[5]:
            if dep[4].strip() == "<":
                if dep_version_int >= high_check:
                    d.append(
                        {'name': dep[1],
                         'found': dep[0],
                         "target": dep[4] + dep[5]})
                    continue
            elif dep[4].strip() == "<=":
                if dep_version_int > high_check:
                    d.append(
                        {'name': dep[1],
                         'found': dep[0],
                         "target": dep[4] + dep[5]})
                    continue
    return d
@@ -16,15 +16,16 @@
 #  You should have received a copy of the GNU General Public License
 #  along with this program. If not, see <http://www.gnu.org/licenses/>.
 from __future__ import division, print_function, unicode_literals
 import os
 import zipfile
 from lxml import etree
 from . import isoLanguages
 from .helper import split_authors
 from .constants import BookMeta
 def extractCover(zipFile, coverFile, coverpath, tmp_file_name):
    if coverFile is None:
        return None
@@ -64,11 +65,11 @@ def get_epub_info(tmp_file_path, original_file_name, original_file_extension):
        tmp = p.xpath('dc:%s/text()' % s, namespaces=ns)
        if len(tmp) > 0:
            if s == 'creator':
-                 epub_metadata[s] = ' & '.join(p.xpath('dc:%s/text()' % s, namespaces=ns))
+                epub_metadata[s] = ' & '.join(split_authors(tmp))
            elif s == 'subject':
-                 epub_metadata[s] = ', '.join(p.xpath('dc:%s/text()' % s, namespaces=ns))
+                epub_metadata[s] = ', '.join(tmp)
            else:
-                epub_metadata[s] = p.xpath('dc:%s/text()' % s, namespaces=ns)[0]
+                epub_metadata[s] = tmp[0]
        else:
            epub_metadata[s] = u'Unknown'
@@ -82,29 +83,32 @@ def get_epub_info(tmp_file_path, original_file_name, original_file_extension):
        else:
            epub_metadata['description'] = ""
-    if epub_metadata['language'] == u'Unknown':
+    lang = epub_metadata['language'].split('-', 1)[0].lower()
-        epub_metadata['language'] = ""
+    epub_metadata['language'] = isoLanguages.get_lang3(lang)
    else:
        lang = epub_metadata['language'].split('-', 1)[0].lower()
        if len(lang) == 2:
            epub_metadata['language'] = isoLanguages.get(part1=lang).name
        elif len(lang) == 3:
            epub_metadata['language'] = isoLanguages.get(part3=lang).name
        else:
            epub_metadata['language'] = ""
-    series = tree.xpath("/pkg:package/pkg:metadata/pkg:meta[@name='calibre:series']/@content", namespaces=ns)
+    epub_metadata = parse_epbub_series(ns, tree, epub_metadata)
    if len(series) > 0:
        epub_metadata['series'] = series[0]
    else:
        epub_metadata['series'] = ''
-    series_id = tree.xpath("/pkg:package/pkg:metadata/pkg:meta[@name='calibre:series_index']/@content", namespaces=ns)
+    coverfile = parse_ebpub_cover(ns, tree, epubZip, coverpath, tmp_file_path)
    if len(series_id) > 0:
        epub_metadata['series_id'] = series_id[0]
    else:
        epub_metadata['series_id'] = '1'
    if not epub_metadata['title']:
        title = original_file_name
    else:
        title = epub_metadata['title']
    return BookMeta(
        file_path=tmp_file_path,
        extension=original_file_extension,
        title=title.encode('utf-8').decode('utf-8'),
        author=epub_metadata['creator'].encode('utf-8').decode('utf-8'),
        cover=coverfile,
        description=epub_metadata['description'],
        tags=epub_metadata['subject'].encode('utf-8').decode('utf-8'),
        series=epub_metadata['series'].encode('utf-8').decode('utf-8'),
        series_id=epub_metadata['series_id'].encode('utf-8').decode('utf-8'),
        languages=epub_metadata['language'],
        publisher="")
 def parse_ebpub_cover(ns, tree, epubZip, coverpath, tmp_file_path):
    coversection = tree.xpath("/pkg:package/pkg:manifest/pkg:item[@id='cover-image']/@href", namespaces=ns)
    coverfile = None
    if len(coversection) > 0:
@@ -122,25 +126,28 @@ def get_epub_info(tmp_file_path, original_file_name, original_file_extension):
                markupTree = etree.fromstring(markup)
                # no matter xhtml or html with no namespace
                imgsrc = markupTree.xpath("//*[local-name() = 'img']/@src")
-                # imgsrc maybe startwith "../"" so fullpath join then relpath to cwd
+                # Alternative image source
-                filename = os.path.relpath(os.path.join(os.path.dirname(os.path.join(coverpath, coversection[0])), imgsrc[0]))
+                if not len(imgsrc):
-                coverfile = extractCover(epubZip, filename, "", tmp_file_path)
+                    imgsrc = markupTree.xpath("//attribute::*[contains(local-name(), 'href')]")
                if len(imgsrc):
                    # imgsrc maybe startwith "../"" so fullpath join then relpath to cwd
                    filename = os.path.relpath(os.path.join(os.path.dirname(os.path.join(coverpath, coversection[0])),
                                                            imgsrc[0]))
                    coverfile = extractCover(epubZip, filename, "", tmp_file_path)
            else:
                coverfile = extractCover(epubZip, coversection[0], coverpath, tmp_file_path)
    return coverfile
-    if not epub_metadata['title']:
+def parse_epbub_series(ns, tree, epub_metadata):
-        title = original_file_name
+    series = tree.xpath("/pkg:package/pkg:metadata/pkg:meta[@name='calibre:series']/@content", namespaces=ns)
    if len(series) > 0:
        epub_metadata['series'] = series[0]
    else:
-        title = epub_metadata['title']
+        epub_metadata['series'] = ''
-    return BookMeta(
+    series_id = tree.xpath("/pkg:package/pkg:metadata/pkg:meta[@name='calibre:series_index']/@content", namespaces=ns)
-        file_path=tmp_file_path,
+    if len(series_id) > 0:
-        extension=original_file_extension,
+        epub_metadata['series_id'] = series_id[0]
-        title=title.encode('utf-8').decode('utf-8'),
+    else:
-        author=epub_metadata['creator'].encode('utf-8').decode('utf-8'),
+        epub_metadata['series_id'] = '1'
-        cover=coverfile,
+    return epub_metadata
        description=epub_metadata['description'],
        tags=epub_metadata['subject'].encode('utf-8').decode('utf-8'),
        series=epub_metadata['series'].encode('utf-8').decode('utf-8'),
        series_id=epub_metadata['series_id'].encode('utf-8').decode('utf-8'),
        languages=epub_metadata['language'])
@@ -0,0 +1,69 @@
 # -*- coding: utf-8 -*-
 #  This file is part of the Calibre-Web (https://github.com/janeczku/calibre-web)
 #    Copyright (C) 2018-2020 OzzieIsaacs
 #
 #  This program is free software: you can redistribute it and/or modify
 #  it under the terms of the GNU General Public License as published by
 #  the Free Software Foundation, either version 3 of the License, or
 #  (at your option) any later version.
 #
 #  This program is distributed in the hope that it will be useful,
 #  but WITHOUT ANY WARRANTY; without even the implied warranty of
 #  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 #  GNU General Public License for more details.
 #
 #  You should have received a copy of the GNU General Public License
 #  along with this program. If not, see <http://www.gnu.org/licenses/>.
 import traceback
 from flask import render_template
 from werkzeug.exceptions import default_exceptions
 try:
    from werkzeug.exceptions import FailedDependency
 except ImportError:
    from werkzeug.exceptions import UnprocessableEntity as FailedDependency
 from . import config, app, logger, services
 log = logger.create()
 # custom error page
 def error_http(error):
    return render_template('http_error.html',
                           error_code="Error {0}".format(error.code),
                           error_name=error.name,
                           issue=False,
                           unconfigured=not config.db_configured,
                           instance=config.config_calibre_web_title
                           ), error.code
 def internal_error(error):
    return render_template('http_error.html',
                           error_code="Internal Server Error",
                           error_name=str(error),
                           issue=True,
                           unconfigured=False,
                           error_stack=traceback.format_exc().split("\n"),
                           instance=config.config_calibre_web_title
                           ), 500
 def init_errorhandler():
    # http error handling
    for ex in default_exceptions:
        if ex < 500:
            app.register_error_handler(ex, error_http)
        elif ex == 500:
            app.register_error_handler(ex, internal_error)
    if services.ldap:
        # Only way of catching the LDAPException upon logging in with LDAP server down
        @app.errorhandler(services.ldap.LDAPException)
        # pylint: disable=unused-variable
        def handle_exception(e):
            log.debug('LDAP server not accessible while trying to login to opds feed')
            return error_http(FailedDependency())
@@ -16,7 +16,6 @@
 #  You should have received a copy of the GNU General Public License
 #  along with this program. If not, see <http://www.gnu.org/licenses/>.
 from __future__ import division, print_function, unicode_literals
 from lxml import etree
 from .constants import BookMeta
@@ -29,52 +28,53 @@ def get_fb2_info(tmp_file_path, original_file_extension):
        'l': 'http://www.w3.org/1999/xlink',
    }
-    fb2_file = open(tmp_file_path)
+    fb2_file = open(tmp_file_path, encoding="utf-8")
-    tree = etree.fromstring(fb2_file.read())
+    tree = etree.fromstring(fb2_file.read().encode())
    authors = tree.xpath('/fb:FictionBook/fb:description/fb:title-info/fb:author', namespaces=ns)
    def get_author(element):
        last_name = element.xpath('fb:last-name/text()', namespaces=ns)
        if len(last_name):
-            last_name = last_name[0].encode('utf-8')
+            last_name = last_name[0]
        else:
            last_name = u''
        middle_name = element.xpath('fb:middle-name/text()', namespaces=ns)
        if len(middle_name):
-            middle_name = middle_name[0].encode('utf-8')
+            middle_name = middle_name[0]
        else:
            middle_name = u''
        first_name = element.xpath('fb:first-name/text()', namespaces=ns)
        if len(first_name):
-            first_name = first_name[0].encode('utf-8')
+            first_name = first_name[0]
        else:
            first_name = u''
-        return (first_name.decode('utf-8') + u' '
+        return (first_name + u' '
-                + middle_name.decode('utf-8') + u' '
+                + middle_name + u' '
-                + last_name.decode('utf-8')).encode('utf-8')
+                + last_name)
    author = str(", ".join(map(get_author, authors)))
    title = tree.xpath('/fb:FictionBook/fb:description/fb:title-info/fb:book-title/text()', namespaces=ns)
    if len(title):
-        title = str(title[0].encode('utf-8'))
+        title = str(title[0])
    else:
        title = u''
    description = tree.xpath('/fb:FictionBook/fb:description/fb:publish-info/fb:book-name/text()', namespaces=ns)
    if len(description):
-        description = str(description[0].encode('utf-8'))
+        description = str(description[0])
    else:
        description = u''
    return BookMeta(
        file_path=tmp_file_path,
        extension=original_file_extension,
-        title=title.decode('utf-8'),
+        title=title,
-        author=author.decode('utf-8'),
+        author=author,
        cover=None,
-        description=description.decode('utf-8'),
+        description=description,
        tags="",
        series="",
        series_id="",
-        languages="")
+        languages="",
        publisher="")
@@ -20,9 +20,7 @@
 #  You should have received a copy of the GNU General Public License
 #  along with this program. If not, see <http://www.gnu.org/licenses/>.
 from __future__ import division, print_function, unicode_literals
 import os
 import sys
 import hashlib
 import json
 import tempfile
@@ -34,24 +32,23 @@ from flask import Blueprint, flash, request, redirect, url_for, abort
 from flask_babel import gettext as _
 from flask_login import login_required
 from . import logger, gdriveutils, config, ub, calibre_db, csrf
 from .admin import admin_required
 gdrive = Blueprint('gdrive', __name__, url_prefix='/gdrive')
 log = logger.create()
 try:
    from googleapiclient.errors import HttpError
-except ImportError:
+except ImportError as err:
-    pass
+    log.debug("Cannot import googleapiclient, using GDrive will not work: %s", err)
 from . import logger, gdriveutils, config, db
 from .web import admin_required
 gdrive = Blueprint('gdrive', __name__)
 log = logger.create()
 current_milli_time = lambda: int(round(time() * 1000))
-gdrive_watch_callback_token = 'target=calibreweb-watch_files'
+gdrive_watch_callback_token = 'target=calibreweb-watch_files'  #nosec
-@gdrive.route("/gdrive/authenticate")
+@gdrive.route("/authenticate")
@login_required
@admin_required
 def authenticate_google_drive():
@@ -64,7 +61,7 @@ def authenticate_google_drive():
    return redirect(authUrl)
-@gdrive.route("/gdrive/callback")
+@gdrive.route("/callback")
 def google_drive_callback():
    auth_code = request.args.get('code')
    if not auth_code:
@@ -73,41 +70,37 @@ def google_drive_callback():
        credentials = gdriveutils.Gauth.Instance().auth.flow.step2_exchange(auth_code)
        with open(gdriveutils.CREDENTIALS, 'w') as f:
            f.write(credentials.to_json())
-    except ValueError as error:
+    except (ValueError, AttributeError) as error:
        log.error(error)
-    return redirect(url_for('admin.configuration'))
+    return redirect(url_for('admin.db_configuration'))
-@gdrive.route("/gdrive/watch/subscribe")
+@gdrive.route("/watch/subscribe")
@login_required
@admin_required
 def watch_gdrive():
    if not config.config_google_drive_watch_changes_response:
        with open(gdriveutils.CLIENT_SECRETS, 'r') as settings:
            filedata = json.load(settings)
-        if filedata['web']['redirect_uris'][0].endswith('/'):
+        address = filedata['web']['redirect_uris'][0].rstrip('/').replace('/gdrive/callback', '/gdrive/watch/callback')
            filedata['web']['redirect_uris'][0] = filedata['web']['redirect_uris'][0][:-((len('/gdrive/callback')+1))]
        else:
            filedata['web']['redirect_uris'][0] = filedata['web']['redirect_uris'][0][:-(len('/gdrive/callback'))]
        address = '%s/gdrive/watch/callback' % filedata['web']['redirect_uris'][0]
        notification_id = str(uuid4())
        try:
            result = gdriveutils.watchChange(gdriveutils.Gdrive.Instance().drive, notification_id,
                               'web_hook', address, gdrive_watch_callback_token, current_milli_time() + 604800*1000)
-            config.config_google_drive_watch_changes_response = json.dumps(result)
+            config.config_google_drive_watch_changes_response = result
            # after save(), config_google_drive_watch_changes_response will be a json object, not string
            config.save()
        except HttpError as e:
            reason=json.loads(e.content)['error']['errors'][0]
            if reason['reason'] == u'push.webhookUrlUnauthorized':
-                flash(_(u'Callback domain is not verified, please follow steps to verify domain in google developer console'), category="error")
+                flash(_(u'Callback domain is not verified, '
                        u'please follow steps to verify domain in google developer console'), category="error")
            else:
                flash(reason['message'], category="error")
-    return redirect(url_for('admin.configuration'))
+    return redirect(url_for('admin.db_configuration'))
-@gdrive.route("/gdrive/watch/revoke")
+@gdrive.route("/watch/revoke")
@login_required
@admin_required
 def revoke_watch_gdrive():
@@ -116,46 +109,50 @@ def revoke_watch_gdrive():
        try:
            gdriveutils.stopChannel(gdriveutils.Gdrive.Instance().drive, last_watch_response['id'],
                                    last_watch_response['resourceId'])
-        except HttpError:
+        except (HttpError, AttributeError):
            pass
-        config.config_google_drive_watch_changes_response = None
+        config.config_google_drive_watch_changes_response = {}
        config.save()
-    return redirect(url_for('admin.configuration'))
+    return redirect(url_for('admin.db_configuration'))
 try:
    @csrf.exempt
    @gdrive.route("/watch/callback", methods=['GET', 'POST'])
    def on_received_watch_confirmation():
        if not config.config_google_drive_watch_changes_response:
            return ''
        if request.headers.get('X-Goog-Channel-Token') != gdrive_watch_callback_token \
                or request.headers.get('X-Goog-Resource-State') != 'change' \
                or not request.data:
            return ''
-@gdrive.route("/gdrive/watch/callback", methods=['GET', 'POST'])
+        log.debug('%r', request.headers)
-def on_received_watch_confirmation():
+        log.debug('%r', request.data)
-    log.debug('%r', request.headers)
+        log.info('Change received from gdrive')
    if request.headers.get('X-Goog-Channel-Token') == gdrive_watch_callback_token \
            and request.headers.get('X-Goog-Resource-State') == 'change' \
            and request.data:
-        data = request.data
+        try:
            j = json.loads(request.data)
            log.info('Getting change details')
            response = gdriveutils.getChangeById(gdriveutils.Gdrive.Instance().drive, j['id'])
            log.debug('%r', response)
            if response:
                dbpath = os.path.join(config.config_calibre_dir, "metadata.db").encode()
                if not response['deleted'] and response['file']['title'] == 'metadata.db' \
                    and response['file']['md5Checksum'] != hashlib.md5(dbpath):  # nosec
                    tmp_dir = os.path.join(tempfile.gettempdir(), 'calibre_web')
                    if not os.path.isdir(tmp_dir):
                        os.mkdir(tmp_dir)
-        def updateMetaData():
+                    log.info('Database file updated')
-            log.info('Change received from gdrive')
+                    copyfile(dbpath, os.path.join(tmp_dir, "metadata.db_" + str(current_milli_time())))
-            log.debug('%r', data)
+                    log.info('Backing up existing and downloading updated metadata.db')
-            try:
+                    gdriveutils.downloadFile(None, "metadata.db", os.path.join(tmp_dir, "tmp_metadata.db"))
-                j = json.loads(data)
+                    log.info('Setting up new DB')
-                log.info('Getting change details')
+                    # prevent error on windows, as os.rename does on existing files, also allow cross hdd move
-                response = gdriveutils.getChangeById(gdriveutils.Gdrive.Instance().drive, j['id'])
+                    move(os.path.join(tmp_dir, "tmp_metadata.db"), dbpath)
-                log.debug('%r', response)
+                    calibre_db.reconnect_db(config, ub.app_DB_path)
-                if response:
+        except Exception as ex:
-                    if sys.version_info < (3, 0):
+            log.debug_or_exception(ex)
-                        dbpath = os.path.join(config.config_calibre_dir, "metadata.db")
+        return ''
-                    else:
+except AttributeError:
-                        dbpath = os.path.join(config.config_calibre_dir, "metadata.db").encode()
+    pass
                    if not response['deleted'] and response['file']['title'] == 'metadata.db' and response['file']['md5Checksum'] != hashlib.md5(dbpath):
                        tmpDir = tempfile.gettempdir()
                        log.info('Database file updated')
                        copyfile(dbpath, os.path.join(tmpDir, "metadata.db_" + str(current_milli_time())))
                        log.info('Backing up existing and downloading updated metadata.db')
                        gdriveutils.downloadFile(None, "metadata.db", os.path.join(tmpDir, "tmp_metadata.db"))
                        log.info('Setting up new DB')
                        # prevent error on windows, as os.rename does on exisiting files
                        move(os.path.join(tmpDir, "tmp_metadata.db"), dbpath)
                        db.setup_db(config)
            except Exception as e:
                log.exception(e)
        updateMetaData()
    return ''
@@ -16,26 +16,56 @@
 #  You should have received a copy of the GNU General Public License
 #  along with this program. If not, see <http://www.gnu.org/licenses/>.
 from __future__ import division, print_function, unicode_literals
 import os
 import json
 import shutil
 import chardet
 import ssl
 from flask import Response, stream_with_context
 from sqlalchemy import create_engine
 from sqlalchemy import Column, UniqueConstraint
 from sqlalchemy import String, Integer
 from sqlalchemy.orm import sessionmaker, scoped_session
-from sqlalchemy.ext.declarative import declarative_base
+try:
    # Compatibility with sqlalchemy 2.0
    from sqlalchemy.orm import declarative_base
 except ImportError:
    from sqlalchemy.ext.declarative import declarative_base
 from sqlalchemy.exc import OperationalError, InvalidRequestError
 from sqlalchemy.sql.expression import text
 try:
-    from pydrive.auth import GoogleAuth
+    from six import __version__ as six_version
    from pydrive.drive import GoogleDrive
    from pydrive.auth import RefreshError
    from apiclient import errors
    gdrive_support = True
 except ImportError:
    six_version = "not installed"
 try:
    from httplib2 import __version__ as httplib2_version
 except ImportError:
    httplib2_version = "not installed"
 try:
    from apiclient import errors
    from httplib2 import ServerNotFoundError
    importError = None
    gdrive_support = True
 except ImportError as e:
    importError = e
    gdrive_support = False
 try:
    from pydrive2.auth import GoogleAuth
    from pydrive2.drive import GoogleDrive
    from pydrive2.auth import RefreshError
    from pydrive2.files import ApiRequestError
 except ImportError as err:
    try:
        from pydrive.auth import GoogleAuth
        from pydrive.drive import GoogleDrive
        from pydrive.auth import RefreshError
        from pydrive.files import ApiRequestError
    except ImportError as err:
        importError = err
        gdrive_support = False
 from . import logger, cli, config
 from .constants import CONFIG_DIR as _CONFIG_DIR
@@ -50,6 +80,8 @@ if gdrive_support:
    logger.get('googleapiclient.discovery_cache').setLevel(logger.logging.ERROR)
    if not logger.is_debug_enabled():
        logger.get('googleapiclient.discovery').setLevel(logger.logging.ERROR)
 else:
    log.debug("Cannot import pydrive,httplib2, using gdrive will not work: %s", importError)
 class Singleton:
@@ -83,7 +115,7 @@ class Singleton:
        except AttributeError:
            self._instance = self._decorated()
            return self._instance
-        except ImportError as e:
+        except (ImportError, NameError) as e:
            log.debug(e)
            return None
@@ -97,7 +129,11 @@ class Singleton:
@Singleton
 class Gauth:
    def __init__(self):
-        self.auth = GoogleAuth(settings_file=SETTINGS_YAML)
+        try:
            self.auth = GoogleAuth(settings_file=SETTINGS_YAML)
        except NameError as error:
            log.error(error)
            self.auth = None
@Singleton
@@ -143,7 +179,7 @@ class PermissionAdded(Base):
 def migrate():
    if not engine.dialect.has_table(engine.connect(), "permissions_added"):
        PermissionAdded.__table__.create(bind = engine)
-    for sql in session.execute("select sql from sqlite_master where type='table'"):
+    for sql in session.execute(text("select sql from sqlite_master where type='table'")):
        if 'CREATE TABLE gdrive_ids' in sql[0]:
            currUniqueConstraint = 'UNIQUE (gdrive_id)'
            if currUniqueConstraint in sql[0]:
@@ -177,8 +213,8 @@ def getDrive(drive=None, gauth=None):
                gauth.Refresh()
            except RefreshError as e:
                log.error("Google Drive error: %s", e)
-            except Exception as e:
+            except Exception as ex:
-                log.exception(e)
+                log.debug_or_exception(ex)
        else:
            # Initialize the saved creds
            gauth.Authorize()
@@ -192,14 +228,18 @@ def getDrive(drive=None, gauth=None):
    return drive
 def listRootFolders():
-    drive = getDrive(Gdrive.Instance().drive)
+    try:
-    folder = "'root' in parents and mimeType = 'application/vnd.google-apps.folder' and trashed = false"
+        drive = getDrive(Gdrive.Instance().drive)
-    fileList = drive.ListFile({'q': folder}).GetList()
+        folder = "'root' in parents and mimeType = 'application/vnd.google-apps.folder' and trashed = false"
        fileList = drive.ListFile({'q': folder}).GetList()
    except (ServerNotFoundError, ssl.SSLError, RefreshError) as e:
        log.info("GDrive Error %s" % e)
        fileList = []
    return fileList
 def getEbooksFolder(drive):
-    return getFolderInFolder('root',config.config_google_drive_folder,drive)
+    return getFolderInFolder('root', config.config_google_drive_folder, drive)
 def getFolderInFolder(parentId, folderName, drive):
@@ -228,8 +268,13 @@ def getEbooksFolderId(drive=None):
            log.error('Error gDrive, root ID not found')
        gDriveId.path = '/'
        session.merge(gDriveId)
-        session.commit()
+        try:
-        return
+            session.commit()
        except OperationalError as ex:
            log.error("gdrive.db DB is not Writeable")
            log.debug('Database error: %s', ex)
            session.rollback()
        return gDriveId.gdrive_id
 def getFile(pathId, fileName, drive):
@@ -243,37 +288,47 @@ def getFile(pathId, fileName, drive):
 def getFolderId(path, drive):
    # drive = getDrive(drive)
-    currentFolderId = getEbooksFolderId(drive)
+    try:
-    sqlCheckPath = path if path[-1] == '/' else path + '/'
+        currentFolderId = getEbooksFolderId(drive)
-    storedPathName = session.query(GdriveId).filter(GdriveId.path == sqlCheckPath).first()
+        sqlCheckPath = path if path[-1] == '/' else path + '/'
        storedPathName = session.query(GdriveId).filter(GdriveId.path == sqlCheckPath).first()
-    if not storedPathName:
+        if not storedPathName:
-        dbChange = False
+            dbChange = False
-        s = path.split('/')
+            s = path.split('/')
-        for i, x in enumerate(s):
+            for i, x in enumerate(s):
-            if len(x) > 0:
+                if len(x) > 0:
-                currentPath = "/".join(s[:i+1])
+                    currentPath = "/".join(s[:i+1])
-                if currentPath[-1] != '/':
+                    if currentPath[-1] != '/':
-                    currentPath = currentPath + '/'
+                        currentPath = currentPath + '/'
-                storedPathName = session.query(GdriveId).filter(GdriveId.path == currentPath).first()
+                    storedPathName = session.query(GdriveId).filter(GdriveId.path == currentPath).first()
-                if storedPathName:
+                    if storedPathName:
-                    currentFolderId = storedPathName.gdrive_id
+                        currentFolderId = storedPathName.gdrive_id
                else:
                    currentFolder = getFolderInFolder(currentFolderId, x, drive)
                    if currentFolder:
                        gDriveId = GdriveId()
                        gDriveId.gdrive_id = currentFolder['id']
                        gDriveId.path = currentPath
                        session.merge(gDriveId)
                        dbChange = True
                        currentFolderId = currentFolder['id']
                    else:
-                        currentFolderId = None
+                        currentFolder = getFolderInFolder(currentFolderId, x, drive)
-                        break
+                        if currentFolder:
-        if dbChange:
+                            gDriveId = GdriveId()
-            session.commit()
+                            gDriveId.gdrive_id = currentFolder['id']
-    else:
+                            gDriveId.path = currentPath
-        currentFolderId = storedPathName.gdrive_id
+                            session.merge(gDriveId)
                            dbChange = True
                            currentFolderId = currentFolder['id']
                        else:
                            currentFolderId = None
                            break
            if dbChange:
                session.commit()
        else:
            currentFolderId = storedPathName.gdrive_id
    except OperationalError as ex:
        log.error("gdrive.db DB is not Writeable")
        log.debug('Database error: %s', ex)
        session.rollback()
    except ApiRequestError as ex:
        log.error('{} {}'.format(ex.error['message'], path))
        session.rollback()
    except RefreshError as ex:
        log.error(ex)
    return currentFolderId
@@ -317,7 +372,7 @@ def moveGdriveFolderRemote(origin_file, target_folder):
                                      addParents=gFileTargetDir['id'],
                                      removeParents=previous_parents,
                                      fields='id, parents').execute()
-    # if previous_parents has no childs anymore, delete original fileparent
+    # if previous_parents has no children anymore, delete original fileparent
    if len(children['items']) == 1:
        deleteDatabaseEntry(previous_parents)
        drive.auth.service.files().delete(fileId=previous_parents).execute()
@@ -369,7 +424,8 @@ def uploadFileToEbooksFolder(destFile, f):
            if len(existingFiles) > 0:
                driveFile = existingFiles[0]
            else:
-                driveFile = drive.CreateFile({'title': x, 'parents': [{"kind": "drive#fileLink", 'id': parent['id']}],})
+                driveFile = drive.CreateFile({'title': x,
                                              'parents': [{"kind": "drive#fileLink", 'id': parent['id']}], })
            driveFile.SetContentFile(f)
            driveFile.Upload()
        else:
@@ -467,15 +523,21 @@ def getChangeById (drive, change_id):
    except (errors.HttpError) as error:
        log.error(error)
        return None
-    except Exception as e:
+    except Exception as ex:
-        log.error(e)
+        log.error(ex)
        return None
 # Deletes the local hashes database to force search for new folder names
 def deleteDatabaseOnChange():
-    session.query(GdriveId).delete()
+    try:
-    session.commit()
+        session.query(GdriveId).delete()
        session.commit()
    except (OperationalError, InvalidRequestError) as ex:
        session.rollback()
        log.debug('Database error: %s', ex)
        log.error(u"GDrive DB is not Writeable")
 def updateGdriveCalibreFromLocal():
    copyToDrive(Gdrive.Instance().drive, config.config_calibre_dir, False, True)
@@ -489,13 +551,23 @@ def updateDatabaseOnEdit(ID,newPath):
    storedPathName = session.query(GdriveId).filter(GdriveId.gdrive_id == ID).first()
    if storedPathName:
        storedPathName.path = sqlCheckPath
-        session.commit()
+        try:
            session.commit()
        except OperationalError as ex:
            log.error("gdrive.db DB is not Writeable")
            log.debug('Database error: %s', ex)
            session.rollback()
 # Deletes the hashes in database of deleted book
 def deleteDatabaseEntry(ID):
    session.query(GdriveId).filter(GdriveId.gdrive_id == ID).delete()
-    session.commit()
+    try:
        session.commit()
    except OperationalError as ex:
        log.error("gdrive.db DB is not Writeable")
        log.debug('Database error: %s', ex)
        session.rollback()
 # Gets cover file from gdrive
@@ -512,7 +584,12 @@ def get_cover_via_gdrive(cover_path):
            permissionAdded = PermissionAdded()
            permissionAdded.gdrive_id = df['id']
            session.add(permissionAdded)
-            session.commit()
+            try:
                session.commit()
            except OperationalError as ex:
                log.error("gdrive.db DB is not Writeable")
                log.debug('Database error: %s', ex)
                session.rollback()
        return df.metadata.get('webContentLink')
    else:
        return None
@@ -526,21 +603,24 @@ def partial(total_byte_len, part_size_limit):
    return s
 # downloads files in chunks from gdrive
-def do_gdrive_download(df, headers):
+def do_gdrive_download(df, headers, convert_encoding=False):
    total_size = int(df.metadata.get('fileSize'))
    download_url = df.metadata.get('downloadUrl')
    s = partial(total_size, 1024 * 1024)  # I'm downloading BIG files, so 100M chunk size is fine for me
-    def stream():
+    def stream(convert_encoding):
        for byte in s:
            headers = {"Range": 'bytes=%s-%s' % (byte[0], byte[1])}
            resp, content = df.auth.Get_Http_Object().request(download_url, headers=headers)
            if resp.status == 206:
                if convert_encoding:
                    result = chardet.detect(content)
                    content = content.decode(result['encoding']).encode('utf-8')
                yield content
            else:
                log.warning('An error occurred: %s', resp)
                return
-    return Response(stream_with_context(stream()), headers=headers)
+    return Response(stream_with_context(stream(convert_encoding)), headers=headers)
 _SETTINGS_YAML_TEMPLATE = """
@@ -583,11 +663,20 @@ def get_error_text(client_secrets=None):
    if not os.path.isfile(CLIENT_SECRETS):
        return 'client_secrets.json is missing or not readable'
-    with open(CLIENT_SECRETS, 'r') as settings:
+    try:
-        filedata = json.load(settings)
+        with open(CLIENT_SECRETS, 'r') as settings:
            filedata = json.load(settings)
    except PermissionError:
        return 'client_secrets.json is missing or not readable'
    if 'web' not in filedata:
        return 'client_secrets.json is not configured for web application'
    if 'redirect_uris' not in filedata['web']:
        return 'Callback url (redirect url) is missing in client_secrets.json'
    if client_secrets:
        client_secrets.update(filedata['web'])
 def get_versions():
    return {'six': six_version,
            'httplib2': httplib2_version}
@@ -16,9 +16,10 @@
 #   You should have received a copy of the GNU General Public License
 #   along with this program. If not, see <http://www.gnu.org/licenses/>.
 from __future__ import division, print_function, unicode_literals
 from .iso_language_names import LANGUAGE_NAMES as _LANGUAGE_NAMES
 from . import logger
 log = logger.create()
 try:
@@ -52,17 +53,48 @@ def get_language_names(locale):
 def get_language_name(locale, lang_code):
-    return get_language_names(locale)[lang_code]
+    try:
        return get_language_names(locale)[lang_code]
    except KeyError:
        log.error('Missing translation for language name: {}'.format(lang_code))
        return "Unknown"
 def get_language_codes(locale, language_names, remainder=None):
    language_names = set(x.strip().lower() for x in language_names if x)
-
+    lang = list()
    for k, v in get_language_names(locale).items():
        v = v.lower()
        if v in language_names:
            lang.append(k)
            language_names.remove(v)
-            yield k
+    if remainder is not None and language_names:
    if remainder is not None:
        remainder.extend(language_names)
    return lang
 def get_valid_language_codes(locale, language_names, remainder=None):
    lang = list()
    if "" in language_names:
        language_names.remove("")
    for k, __ in get_language_names(locale).items():
        if k in language_names:
            lang.append(k)
            language_names.remove(k)
    if remainder is not None and len(language_names):
        remainder.extend(language_names)
    return lang
 def get_lang3(lang):
    try:
        if len(lang) == 2:
            ret_value = get(part1=lang).part3
        elif len(lang) == 3:
            ret_value = lang
        else:
            ret_value = ""
    except KeyError:
        ret_value = lang
    return ret_value
@@ -22,16 +22,15 @@
 # custom jinja filters
 from __future__ import division, print_function, unicode_literals
 import datetime
 import mimetypes
-import re
+from uuid import uuid4
 from babel.dates import format_date
 from flask import Blueprint, request, url_for
 from flask_babel import get_locale
 from flask_login import current_user
-
+from markupsafe import escape
 from . import logger
@@ -44,6 +43,8 @@ log = logger.create()
 def url_for_other_page(page):
    args = request.view_args.copy()
    args['page'] = page
    for get, val in request.args.items():
        args[get] = val
    return url_for(request.endpoint, **args)
@@ -76,22 +77,18 @@ def mimetype_filter(val):
@jinjia.app_template_filter('formatdate')
 def formatdate_filter(val):
    try:
-        conformed_timestamp = re.sub(r"[:]|([-](?!((\d{2}[:]\d{2})|(\d{4}))$))", '', val)
+        return format_date(val, format='medium', locale=get_locale())
        formatdate = datetime.datetime.strptime(conformed_timestamp[:15], "%Y%m%d %H%M%S")
        return format_date(formatdate, format='medium', locale=get_locale())
    except AttributeError as e:
        log.error('Babel error: %s, Current user locale: %s, Current User: %s', e,
                  current_user.locale,
-                  current_user.nickname
+                  current_user.name
                  )
-        return formatdate
+        return val
@jinjia.app_template_filter('formatdateinput')
 def format_date_input(val):
-    conformed_timestamp = re.sub(r"[:]|([-](?!((\d{2}[:]\d{2})|(\d{4}))$))", '', val)
+    input_date = val.isoformat().split('T', 1)[0]  # Hack to support dates <1900
    date_obj = datetime.datetime.strptime(conformed_timestamp[:15], "%Y%m%d %H%M%S")
    input_date = date_obj.isoformat().split('T', 1)[0]  # Hack to support dates <1900
    return '' if input_date == "0101-01-01" else input_date
@@ -113,8 +110,30 @@ def yesno(value, yes, no):
    return yes if value else no
-'''@jinjia.app_template_filter('canread')
+@jinjia.app_template_filter('formatfloat')
-def canread(ext):
+def formatfloat(value, decimals=1):
-    if isinstance(ext, db.Data):
+    value = 0 if not value else value
-        ext = ext.format
+    return ('{0:.' + str(decimals) + 'f}').format(value).rstrip('0').rstrip('.')
-    return ext.lower() in EXTENSIONS_READER'''
+
@jinjia.app_template_filter('formatseriesindex')
 def formatseriesindex_filter(series_index):
    if series_index:
        try:
            if int(series_index) - series_index == 0:
                return int(series_index)
            else:
                return series_index
        except ValueError:
            return series_index
    return 0
@jinjia.app_template_filter('escapedlink')
 def escapedlink_filter(url, text):
    return "<a href='{}'>{}</a>".format(url, escape(text))
@jinjia.app_template_filter('uuidfilter')
 def uuidfilter(var):
    return uuid4()
@@ -19,17 +19,11 @@
 import base64
 import datetime
 import itertools
 import json
 import sys
 import os
 import uuid
 from time import gmtime, strftime
-
+import json
-try:
+from urllib.parse import unquote
    from urllib import unquote
 except ImportError:
    from urllib.parse import unquote
 from flask import (
    Blueprint,
@@ -41,22 +35,28 @@ from flask import (
    redirect,
    abort
 )
-from flask_login import current_user, login_required
+from flask_login import current_user
 from werkzeug.datastructures import Headers
 from sqlalchemy import func
 from sqlalchemy.sql.expression import and_, or_
 from sqlalchemy.exc import StatementError
 from sqlalchemy.sql import select
 import requests
-from . import config, logger, kobo_auth, db, helper, shelf as shelf_lib, ub
+
 from . import config, logger, kobo_auth, db, calibre_db, helper, shelf as shelf_lib, ub, csrf, kobo_sync_status
 from .constants import sqlalchemy_version2
 from .helper import get_download_link
 from .services import SyncToken as SyncToken
 from .web import download_required
-from .kobo_auth import requires_kobo_auth
+from .kobo_auth import requires_kobo_auth, get_auth_token
 KOBO_FORMATS = {"KEPUB": ["KEPUB"], "EPUB": ["EPUB3", "EPUB"]}
 KOBO_STOREAPI_URL = "https://storeapi.kobo.com"
 KOBO_IMAGEHOST_URL = "https://kbimages1-a.akamaihd.net"
 SYNC_ITEM_LIMIT = 100
 kobo = Blueprint("kobo", __name__, url_prefix="/kobo/<auth_token>")
 kobo_auth.disable_failed_auth_redirect_for_blueprint(kobo)
 kobo_auth.register_url_value_preprocessor(kobo)
@@ -80,6 +80,7 @@ CONNECTION_SPECIFIC_HEADERS = [
    "transfer-encoding",
 ]
 def get_kobo_activated():
    return config.config_kobo_sync
@@ -98,6 +99,8 @@ def make_request_to_kobo_store(sync_token=None):
        allow_redirects=False,
        timeout=(2, 10)
    )
    log.debug("Content: " + str(store_response.content))
    log.debug("StatusCode: " + str(store_response.status_code))
    return store_response
@@ -106,7 +109,8 @@ def redirect_or_proxy_request():
        if request.method == "GET":
            return redirect(get_store_url_for_current_request(), 307)
        else:
-            # The Kobo device turns other request types into GET requests on redirects, so we instead proxy to the Kobo store ourselves.
+            # The Kobo device turns other request types into GET requests on redirects,
            # so we instead proxy to the Kobo store ourselves.
            store_response = make_request_to_kobo_store()
            response_headers = store_response.headers
@@ -121,7 +125,11 @@ def redirect_or_proxy_request():
 def convert_to_kobo_timestamp_string(timestamp):
-    return timestamp.strftime("%Y-%m-%dT%H:%M:%SZ")
+    try:
        return timestamp.strftime("%Y-%m-%dT%H:%M:%SZ")
    except AttributeError as exc:
        log.debug("Timestamp not valid: {}".format(exc))
        return datetime.datetime.now().strftime("%Y-%m-%dT%H:%M:%SZ")
@kobo.route("/v1/library/sync")
@@ -130,84 +138,170 @@ def convert_to_kobo_timestamp_string(timestamp):
 def HandleSyncRequest():
    sync_token = SyncToken.SyncToken.from_headers(request.headers)
    log.info("Kobo library sync request received.")
    log.debug("SyncToken: {}".format(sync_token))
    if not current_app.wsgi_app.is_proxied:
-        log.debug('Kobo: Received unproxied request, changed request port to server port')
+        log.debug('Kobo: Received unproxied request, changed request port to external server port')
-    # TODO: Limit the number of books return per sync call, and rely on the sync-continuatation header
+    # if no books synced don't respect sync_token
-    # instead so that the device triggers another sync.
+    if not ub.session.query(ub.KoboSyncedBooks).filter(ub.KoboSyncedBooks.user_id == current_user.id).count():
        sync_token.books_last_modified = datetime.datetime.min
        sync_token.books_last_created = datetime.datetime.min
        sync_token.reading_state_last_modified = datetime.datetime.min
-    new_books_last_modified = sync_token.books_last_modified
+    new_books_last_modified = sync_token.books_last_modified # needed for sync selected shelfs only
-    new_books_last_created = sync_token.books_last_created
+    new_books_last_created = sync_token.books_last_created # needed to distinguish between new and changed entitlement
    new_reading_state_last_modified = sync_token.reading_state_last_modified
    new_archived_last_modified = datetime.datetime.min
    sync_results = []
    # We reload the book database so that the user get's a fresh view of the library
    # in case of external changes (e.g: adding a book through Calibre).
-    db.reconnect_db(config)
+    calibre_db.reconnect_db(config, ub.app_DB_path)
-    archived_books = (
+    only_kobo_shelves = current_user.kobo_only_shelves_sync
        ub.session.query(ub.ArchivedBook)
        .filter(ub.ArchivedBook.user_id == int(current_user.id))
        .all()
    )
-    # We join-in books that have had their Archived bit recently modified in order to either:
+    if only_kobo_shelves:
-    #   * Restore them to the user's device.
+        if sqlalchemy_version2:
-    #   * Delete them from the user's device.
+            changed_entries = select(db.Books,
-    # (Ideally we would use a join for this logic, however cross-database joins don't look trivial in SqlAlchemy.)
+                                     ub.ArchivedBook.last_modified,
-    recently_restored_or_archived_books = []
+                                     ub.BookShelf.date_added,
-    archived_book_ids = {}
+                                     ub.ArchivedBook.is_archived)
-    new_archived_last_modified = datetime.datetime.min
+        else:
-    for archived_book in archived_books:
+            changed_entries = calibre_db.session.query(db.Books,
-        if archived_book.last_modified > sync_token.archive_last_modified:
+                                                       ub.ArchivedBook.last_modified,
-            recently_restored_or_archived_books.append(archived_book.book_id)
+                                                       ub.BookShelf.date_added,
-        if archived_book.is_archived:
+                                                       ub.ArchivedBook.is_archived)
-            archived_book_ids[archived_book.book_id] = True
+        changed_entries = (changed_entries
-        new_archived_last_modified = max(
+                           .join(db.Data).outerjoin(ub.ArchivedBook, and_(db.Books.id == ub.ArchivedBook.book_id,
-            new_archived_last_modified, archived_book.last_modified)
+                                                                          ub.ArchivedBook.user_id == current_user.id))
                           .filter(db.Books.id.notin_(calibre_db.session.query(ub.KoboSyncedBooks.book_id)
                                           .filter(ub.KoboSyncedBooks.user_id == current_user.id)))
                .filter(ub.BookShelf.date_added > sync_token.books_last_modified)
                .filter(db.Data.format.in_(KOBO_FORMATS))
                .filter(calibre_db.common_filters(allow_show_archived=True))
                .order_by(db.Books.id)
                .order_by(ub.ArchivedBook.last_modified)
                .join(ub.BookShelf, db.Books.id == ub.BookShelf.book_id)
                .join(ub.Shelf)
                .filter(ub.Shelf.user_id == current_user.id)
                .filter(ub.Shelf.kobo_sync)
                .distinct()
        )
    else:
        if sqlalchemy_version2:
            changed_entries = select(db.Books, ub.ArchivedBook.last_modified, ub.ArchivedBook.is_archived)
        else:
            changed_entries = calibre_db.session.query(db.Books,
                                                       ub.ArchivedBook.last_modified,
                                                       ub.ArchivedBook.is_archived)
        changed_entries = (changed_entries
                   .join(db.Data).outerjoin(ub.ArchivedBook, and_(db.Books.id == ub.ArchivedBook.book_id,
                                                                  ub.ArchivedBook.user_id == current_user.id))
                   .filter(db.Books.id.notin_(calibre_db.session.query(ub.KoboSyncedBooks.book_id)
                                              .filter(ub.KoboSyncedBooks.user_id == current_user.id)))
                   .filter(calibre_db.common_filters(allow_show_archived=True))
                   .filter(db.Data.format.in_(KOBO_FORMATS))
                   .order_by(db.Books.last_modified)
                   .order_by(db.Books.id)
        )
    # sqlite gives unexpected results when performing the last_modified comparison without the datetime cast.
    # It looks like it's treating the db.Books.last_modified field as a string and may fail
    # the comparison because of the +00:00 suffix.
    changed_entries = (
        db.session.query(db.Books)
        .join(db.Data)
        .filter(or_(func.datetime(db.Books.last_modified) > sync_token.books_last_modified,
                    db.Books.id.in_(recently_restored_or_archived_books)))
        .filter(db.Data.format.in_(KOBO_FORMATS))
        .all()
    )
    reading_states_in_new_entitlements = []
-    for book in changed_entries:
+    if sqlalchemy_version2:
-        kobo_reading_state = get_or_create_reading_state(book.id)
+        books = calibre_db.session.execute(changed_entries.limit(SYNC_ITEM_LIMIT))
    else:
        books = changed_entries.limit(SYNC_ITEM_LIMIT)
    log.debug("Books to Sync: {}".format(len(books.all())))
    for book in books:
        formats = [data.format for data in book.Books.data]
        if not 'KEPUB' in formats and config.config_kepubifypath and 'EPUB' in formats:
            helper.convert_book_format(book.Books.id, config.config_calibre_dir, 'EPUB', 'KEPUB', current_user.name)
        kobo_reading_state = get_or_create_reading_state(book.Books.id)
        entitlement = {
-            "BookEntitlement": create_book_entitlement(book, archived=(book.id in archived_book_ids)),
+            "BookEntitlement": create_book_entitlement(book.Books, archived=(book.is_archived == True)),
-            "BookMetadata": get_metadata(book),
+            "BookMetadata": get_metadata(book.Books),
        }
        if kobo_reading_state.last_modified > sync_token.reading_state_last_modified:
-            entitlement["ReadingState"] = get_kobo_reading_state_response(book, kobo_reading_state)
+            entitlement["ReadingState"] = get_kobo_reading_state_response(book.Books, kobo_reading_state)
            new_reading_state_last_modified = max(new_reading_state_last_modified, kobo_reading_state.last_modified)
-            reading_states_in_new_entitlements.append(book.id)
+            reading_states_in_new_entitlements.append(book.Books.id)
-        if book.timestamp > sync_token.books_last_created:
+        ts_created = book.Books.timestamp
        try:
            ts_created = max(ts_created, book.date_added)
        except AttributeError:
            pass
        if ts_created > sync_token.books_last_created:
            sync_results.append({"NewEntitlement": entitlement})
        else:
            sync_results.append({"ChangedEntitlement": entitlement})
        new_books_last_modified = max(
-            book.last_modified, new_books_last_modified
+            book.Books.last_modified, new_books_last_modified
        )
-        new_books_last_created = max(book.timestamp, new_books_last_created)
+        try:
            new_books_last_modified = max(
                new_books_last_modified, book.date_added
            )
        except AttributeError:
            pass
-    changed_reading_states = (
+        new_books_last_created = max(ts_created, new_books_last_created)
-        ub.session.query(ub.KoboReadingState)
+        kobo_sync_status.add_synced_books(book.Books.id)
-        .filter(and_(func.datetime(ub.KoboReadingState.last_modified) > sync_token.reading_state_last_modified,
+
-                     ub.KoboReadingState.user_id == current_user.id,
+    if sqlalchemy_version2:
-                     ub.KoboReadingState.book_id.notin_(reading_states_in_new_entitlements))))
+        max_change = calibre_db.session.execute(changed_entries
-    for kobo_reading_state in changed_reading_states.all():
+                                                .filter(ub.ArchivedBook.is_archived)
-        book = db.session.query(db.Books).filter(db.Books.id == kobo_reading_state.book_id).one_or_none()
+                                                .filter(ub.ArchivedBook.user_id == current_user.id)
                                                .order_by(func.datetime(ub.ArchivedBook.last_modified).desc()))\
            .columns(db.Books).first()
    else:
        max_change = changed_entries.from_self().filter(ub.ArchivedBook.is_archived)\
            .filter(ub.ArchivedBook.user_id==current_user.id) \
            .order_by(func.datetime(ub.ArchivedBook.last_modified).desc()).first()
    max_change = max_change.last_modified if max_change else new_archived_last_modified
    new_archived_last_modified = max(new_archived_last_modified, max_change)
    # no. of books returned
    if sqlalchemy_version2:
        entries = calibre_db.session.execute(changed_entries).all()
        book_count = len(entries)
    else:
        book_count = changed_entries.count()
    # last entry:
    cont_sync = bool(book_count)
    log.debug("Remaining books to Sync: {}".format(book_count))
    # generate reading state data
    changed_reading_states = ub.session.query(ub.KoboReadingState)
    if only_kobo_shelves:
        changed_reading_states = changed_reading_states.join(ub.BookShelf,
                                                             ub.KoboReadingState.book_id == ub.BookShelf.book_id)\
            .join(ub.Shelf)\
            .filter(current_user.id == ub.Shelf.user_id)\
            .filter(ub.Shelf.kobo_sync,
                    or_(
                        ub.KoboReadingState.last_modified > sync_token.reading_state_last_modified,
                        func.datetime(ub.BookShelf.date_added) > sync_token.books_last_modified
                    )).distinct()
    else:
        changed_reading_states = changed_reading_states.filter(
            ub.KoboReadingState.last_modified > sync_token.reading_state_last_modified)
    changed_reading_states = changed_reading_states.filter(
        and_(ub.KoboReadingState.user_id == current_user.id,
             ub.KoboReadingState.book_id.notin_(reading_states_in_new_entitlements)))\
        .order_by(ub.KoboReadingState.last_modified)
    cont_sync |= bool(changed_reading_states.count() > SYNC_ITEM_LIMIT)
    for kobo_reading_state in changed_reading_states.limit(SYNC_ITEM_LIMIT).all():
        book = calibre_db.session.query(db.Books).filter(db.Books.id == kobo_reading_state.book_id).one_or_none()
        if book:
            sync_results.append({
                "ChangedReadingState": {
@@ -216,19 +310,21 @@ def HandleSyncRequest():
            })
            new_reading_state_last_modified = max(new_reading_state_last_modified, kobo_reading_state.last_modified)
-    sync_shelves(sync_token, sync_results)
+    sync_shelves(sync_token, sync_results, only_kobo_shelves)
-    sync_token.books_last_created = new_books_last_created
+    # update last created timestamp to distinguish between new and changed entitlements
    if not cont_sync:
        sync_token.books_last_created = new_books_last_created
    sync_token.books_last_modified = new_books_last_modified
    sync_token.archive_last_modified = new_archived_last_modified
    sync_token.reading_state_last_modified = new_reading_state_last_modified
-    return generate_sync_response(sync_token, sync_results)
+    return generate_sync_response(sync_token, sync_results, cont_sync)
-def generate_sync_response(sync_token, sync_results):
+def generate_sync_response(sync_token, sync_results, set_cont=False):
    extra_headers = {}
-    if config.config_kobo_proxy:
+    if config.config_kobo_proxy and not set_cont:
        # Merge in sync results from the official Kobo store.
        try:
            store_response = make_request_to_kobo_store(sync_token)
@@ -240,12 +336,16 @@ def generate_sync_response(sync_token, sync_results):
            extra_headers["x-kobo-sync-mode"] = store_response.headers.get("x-kobo-sync-mode")
            extra_headers["x-kobo-recent-reads"] = store_response.headers.get("x-kobo-recent-reads")
-        except Exception as e:
+        except Exception as ex:
-            log.error("Failed to receive or parse response from Kobo's sync endpoint: " + str(e))
+            log.error("Failed to receive or parse response from Kobo's sync endpoint: {}".format(ex))
    if set_cont:
        extra_headers["x-kobo-sync"] = "continue"
    sync_token.to_headers(extra_headers)
-    response = make_response(jsonify(sync_results), extra_headers)
+    # log.debug("Kobo Sync Content: {}".format(sync_results))
-
+    # jsonify decodes the unicode string different to what kobo expects
    response = make_response(json.dumps(sync_results), extra_headers)
    response.headers["Content-Type"] = "application/json; charset=utf-8"
    return response
@@ -254,32 +354,37 @@ def generate_sync_response(sync_token, sync_results):
@download_required
 def HandleMetadataRequest(book_uuid):
    if not current_app.wsgi_app.is_proxied:
-        log.debug('Kobo: Received unproxied request, changed request port to server port')
+        log.debug('Kobo: Received unproxied request, changed request port to external server port')
    log.info("Kobo library metadata request received for book %s" % book_uuid)
-    book = db.session.query(db.Books).filter(db.Books.uuid == book_uuid).first()
+    book = calibre_db.get_book_by_uuid(book_uuid)
    if not book or not book.data:
        log.info(u"Book %s not found in database", book_uuid)
        return redirect_or_proxy_request()
    metadata = get_metadata(book)
-    return jsonify([metadata])
+    response = make_response(json.dumps([metadata], ensure_ascii=False))
    response.headers["Content-Type"] = "application/json; charset=utf-8"
    return response
 def get_download_url_for_book(book, book_format):
    if not current_app.wsgi_app.is_proxied:
-        if ':' in request.host and not request.host.endswith(']') :
+        if ':' in request.host and not request.host.endswith(']'):
            host = "".join(request.host.split(':')[:-1])
        else:
            host = request.host
-        return "{url_scheme}://{url_base}:{url_port}/download/{book_id}/{book_format}".format(
+
        return "{url_scheme}://{url_base}:{url_port}/kobo/{auth_token}/download/{book_id}/{book_format}".format(
            url_scheme=request.scheme,
            url_base=host,
-            url_port=config.config_port,
+            url_port=config.config_external_port,
            auth_token=get_auth_token(),
            book_id=book.id,
            book_format=book_format.lower()
        )
    return url_for(
-        "web.download_link",
+        "kobo.download_book",
        auth_token=kobo_auth.get_auth_token(),
        book_id=book.id,
        book_format=book_format.lower(),
        _external=True,
@@ -287,7 +392,7 @@ def get_download_url_for_book(book, book_format):
 def create_book_entitlement(book, archived):
-    book_uuid = book.uuid
+    book_uuid = str(book.uuid)
    return {
        "Accessibility": "Full",
        "ActivePeriod": {"From": convert_to_kobo_timestamp_string(datetime.datetime.now())},
@@ -314,11 +419,15 @@ def get_description(book):
    return book.comments[0].text
 # TODO handle multiple authors
 def get_author(book):
    if not book.authors:
-        return None
+        return {"Contributors": None}
-    return book.authors[0].name
+    author_list = []
    autor_roles = []
    for author in book.authors:
        autor_roles.append({"Name":author.name})    #.encode('unicode-escape').decode('latin-1')
        author_list.append(author.name)
    return {"ContributorRoles": autor_roles, "Contributors":author_list}
 def get_publisher(book):
@@ -332,10 +441,15 @@ def get_series(book):
        return None
    return book.series[0].name
 def get_seriesindex(book):
    return book.series_index or 1
 def get_metadata(book):
    download_urls = []
-    for book_data in book.data:
+    kepub = [data for data in book.data if data.format == 'KEPUB']
    for book_data in kepub if len(kepub) > 0 else book.data:
        if book_data.format not in KOBO_FORMATS:
            continue
        for kobo_format in KOBO_FORMATS[book_data.format]:
@@ -353,8 +467,8 @@ def get_metadata(book):
    book_uuid = book.uuid
    metadata = {
-        "Categories": ["00000000-0000-0000-0000-000000000001",],
+        "Categories": ["00000000-0000-0000-0000-000000000001", ],
-        "Contributors": get_author(book),
+        # "Contributors": get_author(book),
        "CoverImageId": book_uuid,
        "CrossRevisionId": book_uuid,
        "CurrentDisplayPrice": {"CurrencyCode": "USD", "TotalAmount": 0},
@@ -370,33 +484,29 @@ def get_metadata(book):
        "IsSocialEnabled": True,
        "Language": "en",
        "PhoneticPronunciations": {},
-        # TODO: Fix book.pubdate to return a datetime object so that we can easily
+        "PublicationDate": convert_to_kobo_timestamp_string(book.pubdate),
        # convert it to the format Kobo devices expect.
        "PublicationDate": book.pubdate,
        "Publisher": {"Imprint": "", "Name": get_publisher(book),},
        "RevisionId": book_uuid,
        "Title": book.title,
        "WorkId": book_uuid,
    }
    metadata.update(get_author(book))
    if get_series(book):
-        if sys.version_info < (3, 0):
+        name = get_series(book)
            name = get_series(book).encode("utf-8")
        else:
            name = get_series(book)
        metadata["Series"] = {
            "Name": get_series(book),
-            "Number": book.series_index,        # ToDo Check int() ?
+            "Number": get_seriesindex(book),        # ToDo Check int() ?
-            "NumberFloat": float(book.series_index),
+            "NumberFloat": float(get_seriesindex(book)),
            # Get a deterministic id based on the series name.
-            "Id": uuid.uuid3(uuid.NAMESPACE_DNS, name),
+            "Id": str(uuid.uuid3(uuid.NAMESPACE_DNS, name)),
        }
    return metadata
-
+@csrf.exempt
@kobo.route("/v1/library/tags", methods=["POST", "DELETE"])
-@login_required
+@requires_kobo_auth
 # Creates a Shelf with the given items, and returns the shelf's uuid.
 def HandleTagCreate():
    # catch delete requests, otherwise the are handeld in the book delete handler
@@ -425,12 +535,13 @@ def HandleTagCreate():
    items_unknown_to_calibre = add_items_to_shelf(items, shelf)
    if items_unknown_to_calibre:
        log.debug("Received request to add unknown books to a collection. Silently ignoring items.")
-    ub.session.commit()
+    ub.session_commit()
    return make_response(jsonify(str(shelf.uuid)), 201)
@csrf.exempt
@kobo.route("/v1/library/tags/<tag_id>", methods=["DELETE", "PUT"])
@requires_kobo_auth
 def HandleTagUpdate(tag_id):
    shelf = ub.session.query(ub.Shelf).filter(ub.Shelf.uuid == tag_id,
                                              ub.Shelf.user_id == current_user.id).one_or_none()
@@ -457,7 +568,7 @@ def HandleTagUpdate(tag_id):
        shelf.name = name
        ub.session.merge(shelf)
-        ub.session.commit()
+        ub.session_commit()
    return make_response(' ', 200)
@@ -471,7 +582,7 @@ def add_items_to_shelf(items, shelf):
                items_unknown_to_calibre.append(item)
                continue
-            book = db.session.query(db.Books).filter(db.Books.uuid == item["RevisionId"]).one_or_none()
+            book = calibre_db.get_book_by_uuid(item["RevisionId"])
            if not book:
                items_unknown_to_calibre.append(item)
                continue
@@ -484,8 +595,9 @@ def add_items_to_shelf(items, shelf):
    return items_unknown_to_calibre
@csrf.exempt
@kobo.route("/v1/library/tags/<tag_id>/items", methods=["POST"])
-@login_required
+@requires_kobo_auth
 def HandleTagAddItem(tag_id):
    items = None
    try:
@@ -509,13 +621,13 @@ def HandleTagAddItem(tag_id):
        log.debug("Received request to add an unknown book to a collection. Silently ignoring item.")
    ub.session.merge(shelf)
-    ub.session.commit()
+    ub.session_commit()
    return make_response('', 201)
@csrf.exempt
@kobo.route("/v1/library/tags/<tag_id>/items/delete", methods=["POST"])
-@login_required
+@requires_kobo_auth
 def HandleTagRemoveItem(tag_id):
    items = None
    try:
@@ -542,7 +654,7 @@ def HandleTagRemoveItem(tag_id):
                items_unknown_to_calibre.append(item)
                continue
-            book = db.session.query(db.Books).filter(db.Books.uuid == item["RevisionId"]).one_or_none()
+            book = calibre_db.get_book_by_uuid(item["RevisionId"])
            if not book:
                items_unknown_to_calibre.append(item)
                continue
@@ -550,7 +662,7 @@ def HandleTagRemoveItem(tag_id):
            shelf.books.filter(ub.BookShelf.book_id == book.id).delete()
        except KeyError:
            items_unknown_to_calibre.append(item)
-    ub.session.commit()
+    ub.session_commit()
    if items_unknown_to_calibre:
        log.debug("Received request to remove an unknown book to a collecition. Silently ignoring item.")
@@ -560,13 +672,11 @@ def HandleTagRemoveItem(tag_id):
 # Add new, changed, or deleted shelves to the sync_results.
 # Note: Public shelves that aren't owned by the user aren't supported.
-def sync_shelves(sync_token, sync_results):
+def sync_shelves(sync_token, sync_results, only_kobo_shelves=False):
    new_tags_last_modified = sync_token.tags_last_modified
-
+    # transmit all archived shelfs independent of last sync (why should this matter?)
-    for shelf in ub.session.query(ub.ShelfArchive).filter(func.datetime(ub.ShelfArchive.last_modified) > sync_token.tags_last_modified,
+    for shelf in ub.session.query(ub.ShelfArchive).filter(ub.ShelfArchive.user_id == current_user.id):
                                                          ub.ShelfArchive.user_id == current_user.id):
        new_tags_last_modified = max(shelf.last_modified, new_tags_last_modified)
        sync_results.append({
            "DeletedTag": {
                "Tag": {
@@ -575,9 +685,43 @@ def sync_shelves(sync_token, sync_results):
                }
            }
        })
        ub.session.delete(shelf)
        ub.session_commit()
-    for shelf in ub.session.query(ub.Shelf).filter(func.datetime(ub.Shelf.last_modified) > sync_token.tags_last_modified,
+    extra_filters = []
-                                                   ub.Shelf.user_id == current_user.id):
+    if only_kobo_shelves:
        for shelf in ub.session.query(ub.Shelf).filter(
            func.datetime(ub.Shelf.last_modified) > sync_token.tags_last_modified,
            ub.Shelf.user_id == current_user.id,
            not ub.Shelf.kobo_sync
        ):
            sync_results.append({
                "DeletedTag": {
                    "Tag": {
                        "Id": shelf.uuid,
                        "LastModified": convert_to_kobo_timestamp_string(shelf.last_modified)
                    }
                }
            })
        extra_filters.append(ub.Shelf.kobo_sync)
    if sqlalchemy_version2:
        shelflist = ub.session.execute(select(ub.Shelf).outerjoin(ub.BookShelf).filter(
            or_(func.datetime(ub.Shelf.last_modified) > sync_token.tags_last_modified,
                func.datetime(ub.BookShelf.date_added) > sync_token.tags_last_modified),
            ub.Shelf.user_id == current_user.id,
            *extra_filters
        ).distinct().order_by(func.datetime(ub.Shelf.last_modified).asc())).columns(ub.Shelf)
    else:
        shelflist = ub.session.query(ub.Shelf).outerjoin(ub.BookShelf).filter(
            or_(func.datetime(ub.Shelf.last_modified) > sync_token.tags_last_modified,
                func.datetime(ub.BookShelf.date_added) > sync_token.tags_last_modified),
            ub.Shelf.user_id == current_user.id,
            *extra_filters
        ).distinct().order_by(func.datetime(ub.Shelf.last_modified).asc())
    for shelf in shelflist:
        if not shelf_lib.check_shelf_view_permissions(shelf):
            continue
@@ -596,7 +740,7 @@ def sync_shelves(sync_token, sync_results):
                "ChangedTag": tag
            })
    sync_token.tags_last_modified = new_tags_last_modified
-    ub.session.commit()
+    ub.session_commit()
 # Creates a Kobo "Tag" object from a ub.Shelf object
@@ -610,7 +754,7 @@ def create_kobo_tag(shelf):
        "Type": "UserTag"
    }
    for book_shelf in shelf.books:
-        book = db.session.query(db.Books).filter(db.Books.id == book_shelf.book_id).one_or_none()
+        book = calibre_db.get_book(book_shelf.book_id)
        if not book:
            log.info(u"Book (id: %s) in BookShelf (id: %s) not found in book database",  book_shelf.book_id, shelf.id)
            continue
@@ -622,11 +766,11 @@ def create_kobo_tag(shelf):
        )
    return {"Tag": tag}
-
+@csrf.exempt
@kobo.route("/v1/library/<book_uuid>/state", methods=["GET", "PUT"])
-@login_required
+@requires_kobo_auth
 def HandleStateRequest(book_uuid):
-    book = db.session.query(db.Books).filter(db.Books.uuid == book_uuid).first()
+    book = calibre_db.get_book_by_uuid(book_uuid)
    if not book or not book.data:
        log.info(u"Book %s not found in database", book_uuid)
        return redirect_or_proxy_request()
@@ -677,7 +821,7 @@ def HandleStateRequest(book_uuid):
            abort(400, description="Malformed request data is missing 'ReadingStates' key")
        ub.session.merge(kobo_reading_state)
-        ub.session.commit()
+        ub.session_commit()
        return jsonify({
            "RequestResult": "Success",
            "UpdateResults": [update_results_response],
@@ -706,7 +850,7 @@ def get_ub_read_status(kobo_read_status):
 def get_or_create_reading_state(book_id):
    book_read = ub.session.query(ub.ReadBook).filter(ub.ReadBook.book_id == book_id,
-                                                          ub.ReadBook.user_id == current_user.id).one_or_none()
+                                                          ub.ReadBook.user_id == int(current_user.id)).one_or_none()
    if not book_read:
        book_read = ub.ReadBook(user_id=current_user.id, book_id=book_id)
    if not book_read.kobo_reading_state:
@@ -715,7 +859,7 @@ def get_or_create_reading_state(book_id):
        kobo_reading_state.statistics = ub.KoboStatistics()
        book_read.kobo_reading_state = kobo_reading_state
    ub.session.add(book_read)
-    ub.session.commit()
+    ub.session_commit()
    return book_read.kobo_reading_state
@@ -797,11 +941,12 @@ def TopLevelEndpoint():
    return make_response(jsonify({}))
@csrf.exempt
@kobo.route("/v1/library/<book_uuid>", methods=["DELETE"])
-@login_required
+@requires_kobo_auth
 def HandleBookDeletionRequest(book_uuid):
    log.info("Kobo book deletion request received for book %s" % book_uuid)
-    book = db.session.query(db.Books).filter(db.Books.uuid == book_uuid).first()
+    book = calibre_db.get_book_by_uuid(book_uuid)
    if not book:
        log.info(u"Book %s not found in database", book_uuid)
        return redirect_or_proxy_request()
@@ -818,12 +963,14 @@ def HandleBookDeletionRequest(book_uuid):
    archived_book.last_modified = datetime.datetime.utcnow()
    ub.session.merge(archived_book)
-    ub.session.commit()
+    ub.session_commit()
-
+    if archived_book.is_archived:
-    return ("", 204)
+        kobo_sync_status.remove_synced_book(book_id)
    return "", 204
 # TODO: Implement the following routes
@csrf.exempt
@kobo.route("/v1/library/<dummy>", methods=["DELETE", "GET"])
 def HandleUnimplementedRequest(dummy=None):
    log.debug("Unimplemented Library Request received: %s", request.base_url)
@@ -831,6 +978,7 @@ def HandleUnimplementedRequest(dummy=None):
 # TODO: Implement the following routes
@csrf.exempt
@kobo.route("/v1/user/loyalty/<dummy>", methods=["GET", "POST"])
@kobo.route("/v1/user/profile", methods=["GET", "POST"])
@kobo.route("/v1/user/wishlist", methods=["GET", "POST"])
@@ -841,30 +989,46 @@ def HandleUserRequest(dummy=None):
    return redirect_or_proxy_request()
@csrf.exempt
@kobo.route("/v1/user/loyalty/benefits", methods=["GET"])
 def handle_benefits():
    if config.config_kobo_proxy:
        return redirect_or_proxy_request()
    else:
        return make_response(jsonify({"Benefits": {}}))
@csrf.exempt
@kobo.route("/v1/analytics/gettests", methods=["GET", "POST"])
 def handle_getests():
    if config.config_kobo_proxy:
        return redirect_or_proxy_request()
    else:
        testkey = request.headers.get("X-Kobo-userkey","")
        return make_response(jsonify({"Result": "Success", "TestKey":testkey, "Tests": {}}))
@csrf.exempt
@kobo.route("/v1/products/<dummy>/prices", methods=["GET", "POST"])
@kobo.route("/v1/products/<dummy>/recommendations", methods=["GET", "POST"])
@kobo.route("/v1/products/<dummy>/nextread", methods=["GET", "POST"])
@kobo.route("/v1/products/<dummy>/reviews", methods=["GET", "POST"])
@kobo.route("/v1/products/featured/<dummy>", methods=["GET", "POST"])
@kobo.route("/v1/products/featured/", methods=["GET", "POST"])
@kobo.route("/v1/products/books/external/<dummy>", methods=["GET", "POST"])
@kobo.route("/v1/products/books/series/<dummy>", methods=["GET", "POST"])
@kobo.route("/v1/products/books/<dummy>", methods=["GET", "POST"])
@kobo.route("/v1/products/books/<dummy>/", methods=["GET", "POST"])
@kobo.route("/v1/products/dailydeal", methods=["GET", "POST"])
@kobo.route("/v1/products/deals", methods=["GET", "POST"])
@kobo.route("/v1/products", methods=["GET", "POST"])
@kobo.route("/v1/affiliate", methods=["GET", "POST"])
@kobo.route("/v1/deals", methods=["GET", "POST"])
 def HandleProductsRequest(dummy=None):
    log.debug("Unimplemented Products Request received: %s", request.base_url)
    return redirect_or_proxy_request()
 '''@kobo.errorhandler(404)
 def handle_404(err):
    # This handler acts as a catch-all for endpoints that we don't have an interest in
    # implementing (e.g: v1/analytics/gettests, v1/user/recommendations, etc)
    if err:
        print('404')
        return jsonify(error=str(err)), 404
    log.debug("Unknown Request received: %s, method: %s, data: %s", request.base_url, request.method, request.data)
    return redirect_or_proxy_request()'''
 def make_calibre_web_auth_response():
    # As described in kobo_auth.py, CalibreWeb doesn't make use practical use of this auth/device API call for
    # authentation (nor for authorization). We return a dummy response just to keep the device happy.
@@ -884,6 +1048,7 @@ def make_calibre_web_auth_response():
    )
@csrf.exempt
@kobo.route("/v1/auth/device", methods=["POST"])
@requires_kobo_auth
 def HandleAuthRequest():
@@ -891,7 +1056,7 @@ def HandleAuthRequest():
    if config.config_kobo_proxy:
        try:
            return redirect_or_proxy_request()
-        except:
+        except Exception:
            log.error("Failed to receive or parse response from Kobo's auth endpoint. Falling back to un-proxied mode.")
    return make_calibre_web_auth_response()
@@ -908,13 +1073,13 @@ def HandleInitRequest():
            store_response_json = store_response.json()
            if "Resources" in store_response_json:
                kobo_resources = store_response_json["Resources"]
-        except:
+        except Exception:
            log.error("Failed to receive or parse response from Kobo's init endpoint. Falling back to un-proxied mode.")
    if not kobo_resources:
        kobo_resources = NATIVE_KOBO_RESOURCES()
    if not current_app.wsgi_app.is_proxied:
-        log.debug('Kobo: Received unproxied request, changed request port to server port')
+        log.debug('Kobo: Received unproxied request, changed request port to external server port')
        if ':' in request.host and not request.host.endswith(']'):
            host = "".join(request.host.split(':')[:-1])
        else:
@@ -922,8 +1087,9 @@ def HandleInitRequest():
        calibre_web_url = "{url_scheme}://{url_base}:{url_port}".format(
            url_scheme=request.scheme,
            url_base=host,
-            url_port=config.config_port
+            url_port=config.config_external_port
        )
        log.debug('Kobo: Received unproxied request, changed request url to %s', calibre_web_url)
        kobo_resources["image_host"] = calibre_web_url
        kobo_resources["image_url_quality_template"] = unquote(calibre_web_url +
                                                               url_for("kobo.HandleCoverImageRequest",
@@ -932,16 +1098,14 @@ def HandleInitRequest():
                                                                       width="{width}",
                                                                       height="{height}",
                                                                       Quality='{Quality}',
-                                                                       isGreyscale='isGreyscale'
+                                                                       isGreyscale='isGreyscale'))
                                                               ))
        kobo_resources["image_url_template"] = unquote(calibre_web_url +
                                                       url_for("kobo.HandleCoverImageRequest",
                                                               auth_token=kobo_auth.get_auth_token(),
                                                               book_uuid="{ImageId}",
                                                               width="{width}",
                                                               height="{height}",
-                                                               isGreyscale='false'
+                                                               isGreyscale='false'))
                                                       ))
    else:
        kobo_resources["image_host"] = url_for("web.index", _external=True).strip("/")
        kobo_resources["image_url_quality_template"] = unquote(url_for("kobo.HandleCoverImageRequest",
@@ -960,13 +1124,19 @@ def HandleInitRequest():
                                                               isGreyscale='false',
                                                               _external=True))
    response = make_response(jsonify({"Resources": kobo_resources}))
    response.headers["x-kobo-apitoken"] = "e30="
    return response
@kobo.route("/download/<book_id>/<book_format>")
@requires_kobo_auth
@download_required
 def download_book(book_id, book_format):
    return get_download_link(book_id, book_format, "kobo")
 def NATIVE_KOBO_RESOURCES():
    return {
        "account_page": "https://secure.kobobooks.com/profile",
@@ -979,7 +1149,7 @@ def NATIVE_KOBO_RESOURCES():
        "blackstone_header": {"key": "x-amz-request-payer", "value": "requester"},
        "book": "https://storeapi.kobo.com/v1/products/books/{ProductId}",
        "book_detail_page": "https://store.kobobooks.com/{culture}/ebook/{slug}",
-        "book_detail_page_rakuten": "http://books.rakuten.co.jp/rk/{crossrevisionid}",
+        "book_detail_page_rakuten": "https://books.rakuten.co.jp/rk/{crossrevisionid}",
        "book_landing_page": "https://store.kobobooks.com/ebooks",
        "book_subscription": "https://storeapi.kobo.com/v1/products/books/subscriptions",
        "categories": "https://storeapi.kobo.com/v1/categories",
@@ -1017,7 +1187,7 @@ def NATIVE_KOBO_RESOURCES():
        "get_tests_request": "https://storeapi.kobo.com/v1/analytics/gettests",
        "giftcard_epd_redeem_url": "https://www.kobo.com/{storefront}/{language}/redeem-ereader",
        "giftcard_redeem_url": "https://www.kobo.com/{storefront}/{language}/redeem",
-        "help_page": "http://www.kobo.com/help",
+        "help_page": "https://www.kobo.com/help",
        "kobo_audiobooks_enabled": "False",
        "kobo_audiobooks_orange_deal_enabled": "False",
        "kobo_audiobooks_subscriptions_enabled": "False",
@@ -62,18 +62,14 @@ particular calls to non-Kobo specific endpoints such as the CalibreWeb book down
 from binascii import hexlify
 from datetime import datetime
 from os import urandom
 from functools import wraps
 from flask import g, Blueprint, url_for, abort, request
-from flask_login import login_user, login_required
+from flask_login import login_user, current_user, login_required
 from flask_babel import gettext as _
-from . import logger, ub, lm
+from . import logger, config, calibre_db, db, helper, ub, lm
-from .web import render_title_template
+from .render_template import render_title_template
 try:
    from functools import wraps
 except ImportError:
    pass  # We're not using Python 3
 log = logger.create()
@@ -81,6 +77,7 @@ log = logger.create()
 def register_url_value_preprocessor(kobo):
    @kobo.url_value_preprocessor
    # pylint: disable=unused-variable
    def pop_auth_token(__, values):
        g.auth_token = values.pop("auth_token")
@@ -121,44 +118,50 @@ kobo_auth = Blueprint("kobo_auth", __name__, url_prefix="/kobo_auth")
@kobo_auth.route("/generate_auth_token/<int:user_id>")
@login_required
 def generate_auth_token(user_id):
-    host = ':'.join(request.host.rsplit(':')[0:-1])
+    warning = False
-    if host.startswith('127.') or host.lower() == 'localhost' or host.startswith('[::ffff:7f'):
+    host_list = request.host.rsplit(':')
-        warning = _('PLease access calibre-web from non localhost to get valid api_endpoint for kobo device')
+    if len(host_list) == 1:
-        return render_title_template(
+        host = ':'.join(host_list)
            "generate_kobo_auth_url.html",
            title=_(u"Kobo Setup"),
            warning = warning
        )
    else:
-        # Invalidate any prevously generated Kobo Auth token for this user.
+        host = ':'.join(host_list[0:-1])
-        auth_token = ub.session.query(ub.RemoteAuthToken).filter(
+    if host.startswith('127.') or host.lower() == 'localhost' or host.startswith('[::ffff:7f') or host == "[::1]":
-            ub.RemoteAuthToken.user_id == user_id
+        warning = _('Please access Calibre-Web from non localhost to get valid api_endpoint for kobo device')
        ).filter(ub.RemoteAuthToken.token_type==1).first()
-        if not auth_token:
+    # Generate auth token if none is existing for this user
-            auth_token = ub.RemoteAuthToken()
+    auth_token = ub.session.query(ub.RemoteAuthToken).filter(
-            auth_token.user_id = user_id
+        ub.RemoteAuthToken.user_id == user_id
-            auth_token.expiration = datetime.max
+    ).filter(ub.RemoteAuthToken.token_type==1).first()
            auth_token.auth_token = (hexlify(urandom(16))).decode("utf-8")
            auth_token.token_type = 1
-            ub.session.add(auth_token)
+    if not auth_token:
-            ub.session.commit()
+        auth_token = ub.RemoteAuthToken()
-        return render_title_template(
+        auth_token.user_id = user_id
-            "generate_kobo_auth_url.html",
+        auth_token.expiration = datetime.max
-            title=_(u"Kobo Setup"),
+        auth_token.auth_token = (hexlify(urandom(16))).decode("utf-8")
-            kobo_auth_url=url_for(
+        auth_token.token_type = 1
-                "kobo.TopLevelEndpoint", auth_token=auth_token.auth_token, _external=True
+
-            ),
+        ub.session.add(auth_token)
-            warning = False
+        ub.session_commit()
-        )
+
    books = calibre_db.session.query(db.Books).join(db.Data).all()
    for book in books:
        formats = [data.format for data in book.data]
        if not 'KEPUB' in formats and config.config_kepubifypath and 'EPUB' in formats:
            helper.convert_book_format(book.id, config.config_calibre_dir, 'EPUB', 'KEPUB', current_user.name)
    return render_title_template(
        "generate_kobo_auth_url.html",
        title=_(u"Kobo Setup"),
        auth_token=auth_token.auth_token,
        warning = warning
    )
-@kobo_auth.route("/deleteauthtoken/<int:user_id>")
+@kobo_auth.route("/deleteauthtoken/<int:user_id>", methods=["POST"])
@login_required
 def delete_auth_token(user_id):
-    # Invalidate any prevously generated Kobo Auth token for this user.
+    # Invalidate any previously generated Kobo Auth token for this user
    ub.session.query(ub.RemoteAuthToken).filter(ub.RemoteAuthToken.user_id == user_id)\
        .filter(ub.RemoteAuthToken.token_type==1).delete()
-    ub.session.commit()
+
-    return ""
+    return ub.session_commit()
@@ -0,0 +1,88 @@
 # -*- coding: utf-8 -*-
 #  This file is part of the Calibre-Web (https://github.com/janeczku/calibre-web)
 #    Copyright (C) 2021 OzzieIsaacs
 #
 #  This program is free software: you can redistribute it and/or modify
 #  it under the terms of the GNU General Public License as published by
 #  the Free Software Foundation, either version 3 of the License, or
 #  (at your option) any later version.
 #
 #  This program is distributed in the hope that it will be useful,
 #  but WITHOUT ANY WARRANTY; without even the implied warranty of
 #  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 #  GNU General Public License for more details.
 #
 #  You should have received a copy of the GNU General Public License
 #  along with this program. If not, see <http://www.gnu.org/licenses/>.
 from flask_login import current_user
 from . import ub
 import datetime
 from sqlalchemy.sql.expression import or_, and_, true
 from sqlalchemy import exc
 # Add the current book id to kobo_synced_books table for current user, if entry is already present,
 # do nothing (safety precaution)
 def add_synced_books(book_id):
    is_present = ub.session.query(ub.KoboSyncedBooks).filter(ub.KoboSyncedBooks.book_id == book_id)\
        .filter(ub.KoboSyncedBooks.user_id == current_user.id).count()
    if not is_present:
        synced_book = ub.KoboSyncedBooks()
        synced_book.user_id = current_user.id
        synced_book.book_id = book_id
        ub.session.add(synced_book)
        ub.session_commit()
 # Select all entries of current book in kobo_synced_books table, which are from current user and delete them
 def remove_synced_book(book_id, all=False, session=None):
    if not all:
        user = ub.KoboSyncedBooks.user_id == current_user.id
    else:
        user = true()
    if not session:
        ub.session.query(ub.KoboSyncedBooks).filter(ub.KoboSyncedBooks.book_id == book_id).filter(user).delete()
        ub.session_commit()
    else:
        session.query(ub.KoboSyncedBooks).filter(ub.KoboSyncedBooks.book_id == book_id).filter(user).delete()
        ub.session_commit(sess=session)
 def change_archived_books(book_id, state=None, message=None):
    archived_book = ub.session.query(ub.ArchivedBook).filter(and_(ub.ArchivedBook.user_id == int(current_user.id),
                                                                  ub.ArchivedBook.book_id == book_id)).first()
    if not archived_book:
        archived_book = ub.ArchivedBook(user_id=current_user.id, book_id=book_id)
    archived_book.is_archived = state if state else not archived_book.is_archived
    archived_book.last_modified = datetime.datetime.utcnow()
    ub.session.merge(archived_book)
    ub.session_commit(message)
    return archived_book.is_archived
 # select all books which are synced by the current user and do not belong to a synced shelf and set them to archive
 # select all shelves from current user which are synced and do not belong to the "only sync" shelves
 def update_on_sync_shelfs(user_id):
    books_to_archive = (ub.session.query(ub.KoboSyncedBooks)
                        .join(ub.BookShelf, ub.KoboSyncedBooks.book_id == ub.BookShelf.book_id, isouter=True)
                        .join(ub.Shelf, ub.Shelf.user_id == user_id, isouter=True)
                        .filter(or_(ub.Shelf.kobo_sync == 0, ub.Shelf.kobo_sync == None))
                        .filter(ub.KoboSyncedBooks.user_id == user_id).all())
    for b in books_to_archive:
        change_archived_books(b.book_id, True)
        ub.session.query(ub.KoboSyncedBooks) \
            .filter(ub.KoboSyncedBooks.book_id == b.book_id) \
            .filter(ub.KoboSyncedBooks.user_id == user_id).delete()
        ub.session_commit()
    # Search all shelf which are currently not synced
    shelves_to_archive = ub.session.query(ub.Shelf).filter(ub.Shelf.user_id == user_id).filter(
        ub.Shelf.kobo_sync == 0).all()
    for a in shelves_to_archive:
        ub.session.add(ub.ShelfArchive(uuid=a.uuid, user_id=user_id))
        ub.session_commit()
@@ -16,7 +16,6 @@
 #   You should have received a copy of the GNU General Public License
 #   along with this program. If not, see <http://www.gnu.org/licenses/>.
 from __future__ import division, print_function, unicode_literals
 import os
 import sys
 import inspect
@@ -41,10 +40,32 @@ logging.addLevelName(logging.WARNING, "WARN")
 logging.addLevelName(logging.CRITICAL, "CRIT")
 class _Logger(logging.Logger):
    def debug_or_exception(self, message, stacklevel=2, *args, **kwargs):
        if sys.version_info > (3, 7):
            if is_debug_enabled():
                self.exception(message, stacklevel=stacklevel, *args, **kwargs)
            else:
                self.error(message, stacklevel=stacklevel, *args, **kwargs)
        else:
            if is_debug_enabled():
                self.exception(message, stack_info=True, *args, **kwargs)
            else:
                self.error(message, *args, **kwargs)
    def debug_no_auth(self, message, *args, **kwargs):
        message = message.strip("\r\n")
        if message.startswith("send: AUTH"):
            self.debug(message[:16], *args, **kwargs)
        else:
            self.debug(message, *args, **kwargs)
 def get(name=None):
    return logging.getLogger(name)
 def create():
    parent_frame = inspect.stack(0)[1]
    if hasattr(parent_frame, 'frame'):
@@ -54,7 +75,6 @@ def create():
    parent_module = inspect.getmodule(parent_frame)
    return get(parent_module.__name__)
 def is_debug_enabled():
    return logging.root.level <= logging.DEBUG
@@ -82,7 +102,6 @@ def _absolute_log_file(log_file, default_log_file):
        if not os.path.dirname(log_file):
            log_file = os.path.join(_CONFIG_DIR, log_file)
        return os.path.abspath(log_file)
    return default_log_file
@@ -100,6 +119,7 @@ def setup(log_file, log_level=None):
    May be called multiple times.
    '''
    log_level = log_level or DEFAULT_LOG_LEVEL
    logging.setLoggerClass(_Logger)
    logging.getLogger(__package__).setLevel(log_level)
    r = logging.root
@@ -115,7 +135,7 @@ def setup(log_file, log_level=None):
    if previous_handler:
        # if the log_file has not changed, don't create a new handler
        if getattr(previous_handler, 'baseFilename', None) == log_file:
-            return
+            return "" if log_file == DEFAULT_LOG_FILE else log_file
        logging.debug("logging to %s level %s", log_file, r.level)
    if log_file == LOG_TO_STDERR or log_file == LOG_TO_STDOUT:
@@ -127,17 +147,19 @@ def setup(log_file, log_level=None):
            file_handler.baseFilename = log_file
    else:
        try:
-            file_handler = RotatingFileHandler(log_file, maxBytes=50000, backupCount=2)
+            file_handler = RotatingFileHandler(log_file, maxBytes=100000, backupCount=2, encoding='utf-8')
        except IOError:
            if log_file == DEFAULT_LOG_FILE:
                raise
-            file_handler = RotatingFileHandler(DEFAULT_LOG_FILE, maxBytes=50000, backupCount=2)
+            file_handler = RotatingFileHandler(DEFAULT_LOG_FILE, maxBytes=100000, backupCount=2, encoding='utf-8')
            log_file = ""
    file_handler.setFormatter(FORMATTER)
    for h in r.handlers:
        r.removeHandler(h)
        h.close()
    r.addHandler(file_handler)
    return "" if log_file == DEFAULT_LOG_FILE else log_file
 def create_access_log(log_file, log_name, formatter):
@@ -150,11 +172,18 @@ def create_access_log(log_file, log_name, formatter):
    access_log = logging.getLogger(log_name)
    access_log.propagate = False
    access_log.setLevel(logging.INFO)
    try:
        file_handler = RotatingFileHandler(log_file, maxBytes=50000, backupCount=2, encoding='utf-8')
    except IOError:
        if log_file == DEFAULT_ACCESS_LOG:
            raise
        file_handler = RotatingFileHandler(DEFAULT_ACCESS_LOG, maxBytes=50000, backupCount=2, encoding='utf-8')
        log_file = ""
    file_handler = RotatingFileHandler(log_file, maxBytes=50000, backupCount=2)
    file_handler.setFormatter(formatter)
    access_log.addHandler(file_handler)
-    return access_log
+    return access_log, \
           "" if _absolute_log_file(log_file, DEFAULT_ACCESS_LOG) == DEFAULT_ACCESS_LOG else log_file
 # Enable logging of smtp lib debug output
@@ -0,0 +1,65 @@
 # -*- coding: utf-8 -*-
 #  This file is part of the Calibre-Web (https://github.com/janeczku/calibre-web)
 #    Copyright (C) 2021 OzzieIsaacs
 #
 #  This program is free software: you can redistribute it and/or modify
 #  it under the terms of the GNU General Public License as published by
 #  the Free Software Foundation, either version 3 of the License, or
 #  (at your option) any later version.
 #
 #  This program is distributed in the hope that it will be useful,
 #  but WITHOUT ANY WARRANTY; without even the implied warranty of
 #  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 #  GNU General Public License for more details.
 #
 #  You should have received a copy of the GNU General Public License
 #  along with this program. If not, see <http://www.gnu.org/licenses/>.
 # ComicVine api document: https://comicvine.gamespot.com/api/documentation
 import requests
 from cps.services.Metadata import Metadata
 class ComicVine(Metadata):
    __name__ = "ComicVine"
    __id__ = "comicvine"
    def search(self, query, generic_cover=""):
        val = list()
        apikey = "57558043c53943d5d1e96a9ad425b0eb85532ee6"
        if self.active:
            headers = {
                'User-Agent': 'Not Evil Browser'
            }
            result = requests.get("https://comicvine.gamespot.com/api/search?api_key="
                                  + apikey + "&resources=issue&query=" + query + "&sort=name:desc&format=json", headers=headers)
            for r in result.json().get('results'):
                seriesTitle = r['volume'].get('name', "")
                if r.get('store_date'):
                    dateFomers = r.get('store_date')
                else:
                    dateFomers = r.get('date_added')
                v = dict()
                v['id'] = r['id']
                v['title'] = seriesTitle + " #" + r.get('issue_number', "0") + " - " + ( r.get('name', "") or "")
                v['authors'] = r.get('authors', [])
                v['description'] = r.get('description', "")
                v['publisher'] = ""
                v['publishedDate'] = dateFomers
                v['tags'] = ["Comics", seriesTitle]
                v['rating'] = 0
                v['series'] = seriesTitle
                v['cover'] = r['image'].get('original_url')
                v['source'] = {
                    "id": self.__id__,
                    "description": "ComicVine Books",
                    "link": "https://comicvine.gamespot.com/"
                }
                v['url'] = r.get('site_detail_url', "")
                val.append(v)
        return val
@@ -0,0 +1,55 @@
 # -*- coding: utf-8 -*-
 #  This file is part of the Calibre-Web (https://github.com/janeczku/calibre-web)
 #    Copyright (C) 2021 OzzieIsaacs
 #
 #  This program is free software: you can redistribute it and/or modify
 #  it under the terms of the GNU General Public License as published by
 #  the Free Software Foundation, either version 3 of the License, or
 #  (at your option) any later version.
 #
 #  This program is distributed in the hope that it will be useful,
 #  but WITHOUT ANY WARRANTY; without even the implied warranty of
 #  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 #  GNU General Public License for more details.
 #
 #  You should have received a copy of the GNU General Public License
 #  along with this program. If not, see <http://www.gnu.org/licenses/>.
 # Google Books api document: https://developers.google.com/books/docs/v1/using
 import requests
 from cps.services.Metadata import Metadata
 class Google(Metadata):
    __name__ = "Google"
    __id__ = "google"
    def search(self, query, generic_cover=""):
        if self.active:
            val = list()
            result = requests.get("https://www.googleapis.com/books/v1/volumes?q="+query.replace(" ","+"))
            for r in result.json().get('items'):
                v = dict()
                v['id'] = r['id']
                v['title'] = r['volumeInfo'].get('title',"")
                v['authors'] = r['volumeInfo'].get('authors', [])
                v['description'] = r['volumeInfo'].get('description', "")
                v['publisher'] = r['volumeInfo'].get('publisher', "")
                v['publishedDate'] = r['volumeInfo'].get('publishedDate', "")
                v['tags'] = r['volumeInfo'].get('categories', [])
                v['rating'] = r['volumeInfo'].get('averageRating', 0)
                if r['volumeInfo'].get('imageLinks'):
                    v['cover'] = r['volumeInfo']['imageLinks']['thumbnail'].replace("http://", "https://")
                else:
                    v['cover'] = "/../../../static/generic_cover.jpg"
                v['source'] = {
                    "id": self.__id__,
                    "description": "Google Books",
                    "link": "https://books.google.com/"}
                v['url'] = "https://books.google.com/books?id=" + r['id']
                val.append(v)
            return val
@@ -0,0 +1,60 @@
 # -*- coding: utf-8 -*-
 #  This file is part of the Calibre-Web (https://github.com/janeczku/calibre-web)
 #    Copyright (C) 2021 OzzieIsaacs
 #
 #  This program is free software: you can redistribute it and/or modify
 #  it under the terms of the GNU General Public License as published by
 #  the Free Software Foundation, either version 3 of the License, or
 #  (at your option) any later version.
 #
 #  This program is distributed in the hope that it will be useful,
 #  but WITHOUT ANY WARRANTY; without even the implied warranty of
 #  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 #  GNU General Public License for more details.
 #
 #  You should have received a copy of the GNU General Public License
 #  along with this program. If not, see <http://www.gnu.org/licenses/>.
 from scholarly import scholarly
 from cps.services.Metadata import Metadata
 class scholar(Metadata):
    __name__ = "Google Scholar"
    __id__ = "googlescholar"
    def search(self, query, generic_cover=""):
        val = list()
        if self.active:
            scholar_gen = scholarly.search_pubs(' '.join(query.split('+')))
            i = 0
            for publication in scholar_gen:
                v = dict()
                v['id'] = publication['url_scholarbib'].split(':')[1]
                v['title'] = publication['bib'].get('title')
                v['authors'] = publication['bib'].get('author', [])
                v['description'] = publication['bib'].get('abstract', "")
                v['publisher'] = publication['bib'].get('venue', "")
                if publication['bib'].get('pub_year'):
                    v['publishedDate'] = publication['bib'].get('pub_year')+"-01-01"
                else:
                    v['publishedDate'] = ""
                v['tags'] = []
                v['rating'] = 0
                v['series'] = ""
                v['cover'] = ""
                v['url'] = publication.get('pub_url') or publication.get('eprint_url') or "",
                v['source'] = {
                    "id": self.__id__,
                    "description": "Google Scholar",
                    "link": "https://scholar.google.com/"
                }
                val.append(v)
                i += 1
                if (i >= 10):
                    break
        return val
@@ -16,10 +16,8 @@
 #  You should have received a copy of the GNU General Public License
 #  along with this program. If not, see <http://www.gnu.org/licenses/>
 from __future__ import division, print_function, unicode_literals
 from flask import session
 try:
    from flask_dance.consumer.backend.sqla import SQLAlchemyBackend, first, _get_real_user
    from sqlalchemy.orm.exc import NoResultFound
@@ -34,134 +32,131 @@ except ImportError:
    except ImportError:
        pass
 try:
    class OAuthBackend(SQLAlchemyBackend):
        """
        Stores and retrieves OAuth tokens using a relational database through
        the `SQLAlchemy`_ ORM.
-        .. _SQLAlchemy: http://www.sqlalchemy.org/
+class OAuthBackend(SQLAlchemyBackend):
-        """
+    """
-        def __init__(self, model, session, provider_id,
+    Stores and retrieves OAuth tokens using a relational database through
-                     user=None, user_id=None, user_required=None, anon_user=None,
+    the `SQLAlchemy`_ ORM.
                     cache=None):
            self.provider_id = provider_id
            super(OAuthBackend, self).__init__(model, session, user, user_id, user_required, anon_user, cache)
-        def get(self, blueprint, user=None, user_id=None):
+    .. _SQLAlchemy: https://www.sqlalchemy.org/
-            if self.provider_id + '_oauth_token' in session and session[self.provider_id + '_oauth_token'] != '':
+    """
-                return session[self.provider_id + '_oauth_token']
+    def __init__(self, model, session, provider_id,
-            # check cache
+                 user=None, user_id=None, user_required=None, anon_user=None,
-            cache_key = self.make_cache_key(blueprint=blueprint, user=user, user_id=user_id)
+                 cache=None):
-            token = self.cache.get(cache_key)
+        self.provider_id = provider_id
-            if token:
+        super(OAuthBackend, self).__init__(model, session, user, user_id, user_required, anon_user, cache)
                return token
            # if not cached, make database queries
            query = (
                self.session.query(self.model)
                .filter_by(provider=self.provider_id)
            )
            uid = first([user_id, self.user_id, blueprint.config.get("user_id")])
            u = first(_get_real_user(ref, self.anon_user)
                      for ref in (user, self.user, blueprint.config.get("user")))
            use_provider_user_id = False
            if self.provider_id + '_oauth_user_id' in session and session[self.provider_id + '_oauth_user_id'] != '':
                query = query.filter_by(provider_user_id=session[self.provider_id + '_oauth_user_id'])
                use_provider_user_id = True
            if self.user_required and not u and not uid and not use_provider_user_id:
                # raise ValueError("Cannot get OAuth token without an associated user")
                return None
            # check for user ID
            if hasattr(self.model, "user_id") and uid:
                query = query.filter_by(user_id=uid)
            # check for user (relationship property)
            elif hasattr(self.model, "user") and u:
                query = query.filter_by(user=u)
            # if we have the property, but not value, filter by None
            elif hasattr(self.model, "user_id"):
                query = query.filter_by(user_id=None)
            # run query
            try:
                token = query.one().token
            except NoResultFound:
                token = None
            # cache the result
            self.cache.set(cache_key, token)
    def get(self, blueprint, user=None, user_id=None):
        if self.provider_id + '_oauth_token' in session and session[self.provider_id + '_oauth_token'] != '':
            return session[self.provider_id + '_oauth_token']
        # check cache
        cache_key = self.make_cache_key(blueprint=blueprint, user=user, user_id=user_id)
        token = self.cache.get(cache_key)
        if token:
            return token
-        def set(self, blueprint, token, user=None, user_id=None):
+        # if not cached, make database queries
-            uid = first([user_id, self.user_id, blueprint.config.get("user_id")])
+        query = (
-            u = first(_get_real_user(ref, self.anon_user)
+            self.session.query(self.model)
-                      for ref in (user, self.user, blueprint.config.get("user")))
+            .filter_by(provider=self.provider_id)
        )
        uid = first([user_id, self.user_id, blueprint.config.get("user_id")])
        u = first(_get_real_user(ref, self.anon_user)
                  for ref in (user, self.user, blueprint.config.get("user")))
-            if self.user_required and not u and not uid:
+        use_provider_user_id = False
-                raise ValueError("Cannot set OAuth token without an associated user")
+        if self.provider_id + '_oauth_user_id' in session and session[self.provider_id + '_oauth_user_id'] != '':
            query = query.filter_by(provider_user_id=session[self.provider_id + '_oauth_user_id'])
            use_provider_user_id = True
-            # if there was an existing model, delete it
+        if self.user_required and not u and not uid and not use_provider_user_id:
-            existing_query = (
+            # raise ValueError("Cannot get OAuth token without an associated user")
-                self.session.query(self.model)
+            return None
-                .filter_by(provider=self.provider_id)
+        # check for user ID
-            )
+        if hasattr(self.model, "user_id") and uid:
-            # check for user ID
+            query = query.filter_by(user_id=uid)
-            has_user_id = hasattr(self.model, "user_id")
+        # check for user (relationship property)
-            if has_user_id and uid:
+        elif hasattr(self.model, "user") and u:
-                existing_query = existing_query.filter_by(user_id=uid)
+            query = query.filter_by(user=u)
-            # check for user (relationship property)
+        # if we have the property, but not value, filter by None
-            has_user = hasattr(self.model, "user")
+        elif hasattr(self.model, "user_id"):
-            if has_user and u:
+            query = query.filter_by(user_id=None)
-                existing_query = existing_query.filter_by(user=u)
+        # run query
-            # queue up delete query -- won't be run until commit()
+        try:
-            existing_query.delete()
+            token = query.one().token
-            # create a new model for this token
+        except NoResultFound:
-            kwargs = {
+            token = None
                "provider": self.provider_id,
                "token": token,
            }
            if has_user_id and uid:
                kwargs["user_id"] = uid
            if has_user and u:
                kwargs["user"] = u
            self.session.add(self.model(**kwargs))
            # commit to delete and add simultaneously
            self.session.commit()
            # invalidate cache
            self.cache.delete(self.make_cache_key(
                blueprint=blueprint, user=user, user_id=user_id
            ))
-        def delete(self, blueprint, user=None, user_id=None):
+        # cache the result
-            query = (
+        self.cache.set(cache_key, token)
                self.session.query(self.model)
                .filter_by(provider=self.provider_id)
            )
            uid = first([user_id, self.user_id, blueprint.config.get("user_id")])
            u = first(_get_real_user(ref, self.anon_user)
                      for ref in (user, self.user, blueprint.config.get("user")))
-            if self.user_required and not u and not uid:
+        return token
                raise ValueError("Cannot delete OAuth token without an associated user")
-            # check for user ID
+    def set(self, blueprint, token, user=None, user_id=None):
-            if hasattr(self.model, "user_id") and uid:
+        uid = first([user_id, self.user_id, blueprint.config.get("user_id")])
-                query = query.filter_by(user_id=uid)
+        u = first(_get_real_user(ref, self.anon_user)
-            # check for user (relationship property)
+                  for ref in (user, self.user, blueprint.config.get("user")))
            elif hasattr(self.model, "user") and u:
                query = query.filter_by(user=u)
            # if we have the property, but not value, filter by None
            elif hasattr(self.model, "user_id"):
                query = query.filter_by(user_id=None)
            # run query
            query.delete()
            self.session.commit()
            # invalidate cache
            self.cache.delete(self.make_cache_key(
                blueprint=blueprint, user=user, user_id=user_id,
            ))
-except Exception:
+        if self.user_required and not u and not uid:
-    pass
+            raise ValueError("Cannot set OAuth token without an associated user")
        # if there was an existing model, delete it
        existing_query = (
            self.session.query(self.model)
            .filter_by(provider=self.provider_id)
        )
        # check for user ID
        has_user_id = hasattr(self.model, "user_id")
        if has_user_id and uid:
            existing_query = existing_query.filter_by(user_id=uid)
        # check for user (relationship property)
        has_user = hasattr(self.model, "user")
        if has_user and u:
            existing_query = existing_query.filter_by(user=u)
        # queue up delete query -- won't be run until commit()
        existing_query.delete()
        # create a new model for this token
        kwargs = {
            "provider": self.provider_id,
            "token": token,
        }
        if has_user_id and uid:
            kwargs["user_id"] = uid
        if has_user and u:
            kwargs["user"] = u
        self.session.add(self.model(**kwargs))
        # commit to delete and add simultaneously
        self.session.commit()
        # invalidate cache
        self.cache.delete(self.make_cache_key(
            blueprint=blueprint, user=user, user_id=user_id
        ))
    def delete(self, blueprint, user=None, user_id=None):
        query = (
            self.session.query(self.model)
            .filter_by(provider=self.provider_id)
        )
        uid = first([user_id, self.user_id, blueprint.config.get("user_id")])
        u = first(_get_real_user(ref, self.anon_user)
                  for ref in (user, self.user, blueprint.config.get("user")))
        if self.user_required and not u and not uid:
            raise ValueError("Cannot delete OAuth token without an associated user")
        # check for user ID
        if hasattr(self.model, "user_id") and uid:
            query = query.filter_by(user_id=uid)
        # check for user (relationship property)
        elif hasattr(self.model, "user") and u:
            query = query.filter_by(user=u)
        # if we have the property, but not value, filter by None
        elif hasattr(self.model, "user_id"):
            query = query.filter_by(user_id=None)
        # run query
        query.delete()
        self.session.commit()
        # invalidate cache
        self.cache.delete(self.make_cache_key(
            blueprint=blueprint, user=user, user_id=user_id,
        ))
@@ -20,7 +20,6 @@
 #  You should have received a copy of the GNU General Public License
 #  along with this program. If not, see <http://www.gnu.org/licenses/>
 from __future__ import division, print_function, unicode_literals
 import json
 from functools import wraps
@@ -30,15 +29,20 @@ from flask_babel import gettext as _
 from flask_dance.consumer import oauth_authorized, oauth_error
 from flask_dance.contrib.github import make_github_blueprint, github
 from flask_dance.contrib.google import make_google_blueprint, google
-from flask_login import login_user, current_user
+from oauthlib.oauth2 import TokenExpiredError, InvalidGrantError
 from flask_login import login_user, current_user, login_required
 from sqlalchemy.orm.exc import NoResultFound
 from . import constants, logger, config, app, ub
-from .web import login_required
+
-from .oauth import OAuthBackend, backend_resultcode
+try:
    from .oauth import OAuthBackend, backend_resultcode
 except NameError:
    pass
 oauth_check = {}
 oauthblueprints = []
 oauth = Blueprint('oauth', __name__)
 log = logger.create()
@@ -84,11 +88,7 @@ def register_user_with_oauth(user=None):
            except NoResultFound:
                # no found, return error
                return
-            try:
+            ub.session_commit("User {} with OAuth for provider {} registered".format(user.name, oauth_key))
                ub.session.commit()
            except Exception as e:
                log.exception(e)
                ub.session.rollback()
 def logout_oauth_user():
@@ -97,19 +97,122 @@ def logout_oauth_user():
            session.pop(str(oauth_key) + '_oauth_user_id')
-if ub.oauth_support:
+def oauth_update_token(provider_id, token, provider_user_id):
-    oauthblueprints = []
+    session[provider_id + "_oauth_user_id"] = provider_user_id
    session[provider_id + "_oauth_token"] = token
    # Find this OAuth token in the database, or create it
    query = ub.session.query(ub.OAuth).filter_by(
        provider=provider_id,
        provider_user_id=provider_user_id,
    )
    try:
        oauth_entry = query.one()
        # update token
        oauth_entry.token = token
    except NoResultFound:
        oauth_entry = ub.OAuth(
            provider=provider_id,
            provider_user_id=provider_user_id,
            token=token,
        )
    ub.session.add(oauth_entry)
    ub.session_commit()
    # Disable Flask-Dance's default behavior for saving the OAuth token
    # Value differrs depending on flask-dance version
    return backend_resultcode
 def bind_oauth_or_register(provider_id, provider_user_id, redirect_url, provider_name):
    query = ub.session.query(ub.OAuth).filter_by(
        provider=provider_id,
        provider_user_id=provider_user_id,
    )
    try:
        oauth_entry = query.first()
        # already bind with user, just login
        if oauth_entry.user:
            login_user(oauth_entry.user)
            log.debug(u"You are now logged in as: '%s'", oauth_entry.user.name)
            flash(_(u"you are now logged in as: '%(nickname)s'", nickname= oauth_entry.user.name),
                  category="success")
            return redirect(url_for('web.index'))
        else:
            # bind to current user
            if current_user and current_user.is_authenticated:
                oauth_entry.user = current_user
                try:
                    ub.session.add(oauth_entry)
                    ub.session.commit()
                    flash(_(u"Link to %(oauth)s Succeeded", oauth=provider_name), category="success")
                    log.info("Link to {} Succeeded".format(provider_name))
                    return redirect(url_for('web.profile'))
                except Exception as ex:
                    log.debug_or_exception(ex)
                    ub.session.rollback()
            else:
                flash(_(u"Login failed, No User Linked With OAuth Account"), category="error")
            log.info('Login failed, No User Linked With OAuth Account')
            return redirect(url_for('web.login'))
            # return redirect(url_for('web.login'))
            # if config.config_public_reg:
            #   return redirect(url_for('web.register'))
            # else:
            #    flash(_(u"Public registration is not enabled"), category="error")
            #    return redirect(url_for(redirect_url))
    except (NoResultFound, AttributeError):
        return redirect(url_for(redirect_url))
 def get_oauth_status():
    status = []
    query = ub.session.query(ub.OAuth).filter_by(
        user_id=current_user.id,
    )
    try:
        oauths = query.all()
        for oauth_entry in oauths:
            status.append(int(oauth_entry.provider))
        return status
    except NoResultFound:
        return None
 def unlink_oauth(provider):
    if request.host_url + 'me' != request.referrer:
        pass
    query = ub.session.query(ub.OAuth).filter_by(
        provider=provider,
        user_id=current_user.id,
    )
    try:
        oauth_entry = query.one()
        if current_user and current_user.is_authenticated:
            oauth_entry.user = current_user
            try:
                ub.session.delete(oauth_entry)
                ub.session.commit()
                logout_oauth_user()
                flash(_(u"Unlink to %(oauth)s Succeeded", oauth=oauth_check[provider]), category="success")
                log.info("Unlink to {} Succeeded".format(oauth_check[provider]))
            except Exception as ex:
                log.debug_or_exception(ex)
                ub.session.rollback()
                flash(_(u"Unlink to %(oauth)s Failed", oauth=oauth_check[provider]), category="error")
    except NoResultFound:
        log.warning("oauth %s for user %d not found", provider, current_user.id)
        flash(_(u"Not Linked to %(oauth)s", oauth=provider), category="error")
    return redirect(url_for('web.profile'))
 def generate_oauth_blueprints():
    if not ub.session.query(ub.OAuthProvider).count():
-        oauthProvider = ub.OAuthProvider()
+        for provider in ("github", "google"):
-        oauthProvider.provider_name = "github"
+            oauthProvider = ub.OAuthProvider()
-        oauthProvider.active = False
+            oauthProvider.provider_name = provider
-        ub.session.add(oauthProvider)
+            oauthProvider.active = False
-        ub.session.commit()
+            ub.session.add(oauthProvider)
-        oauthProvider = ub.OAuthProvider()
+            ub.session_commit("{} Blueprint Created".format(provider))
        oauthProvider.provider_name = "google"
        oauthProvider.active = False
        ub.session.add(oauthProvider)
        ub.session.commit()
    oauth_ids = ub.session.query(ub.OAuthProvider).all()
    ele1 = dict(provider_name='github',
@@ -122,10 +225,10 @@ if ub.oauth_support:
    ele2 = dict(provider_name='google',
                id=oauth_ids[1].id,
                active=oauth_ids[1].active,
-                scope=["https://www.googleapis.com/auth/plus.me", "https://www.googleapis.com/auth/userinfo.email"],
+                scope=["https://www.googleapis.com/auth/userinfo.email"],
                oauth_client_id=oauth_ids[1].oauth_client_id,
                oauth_client_secret=oauth_ids[1].oauth_client_secret,
-                obtain_link='https://github.com/settings/developers')
+                obtain_link='https://console.developers.google.com/apis/credentials')
    oauthblueprints.append(ele1)
    oauthblueprints.append(ele2)
@@ -146,17 +249,23 @@ if ub.oauth_support:
        app.register_blueprint(blueprint, url_prefix="/login")
        if element['active']:
            register_oauth_blueprint(element['id'], element['provider_name'])
    return oauthblueprints
 if ub.oauth_support:
    oauthblueprints = generate_oauth_blueprints()
    @oauth_authorized.connect_via(oauthblueprints[0]['blueprint'])
    def github_logged_in(blueprint, token):
        if not token:
            flash(_(u"Failed to log in with GitHub."), category="error")
            log.error("Failed to log in with GitHub")
            return False
        resp = blueprint.session.get("/user")
        if not resp.ok:
            flash(_(u"Failed to fetch user info from GitHub."), category="error")
            log.error("Failed to fetch user info from GitHub")
            return False
        github_info = resp.json()
@@ -168,11 +277,13 @@ if ub.oauth_support:
    def google_logged_in(blueprint, token):
        if not token:
            flash(_(u"Failed to log in with Google."), category="error")
            log.error("Failed to log in with Google")
            return False
        resp = blueprint.session.get("/oauth2/v2/userinfo")
        if not resp.ok:
            flash(_(u"Failed to fetch user info from Google."), category="error")
            log.error("Failed to fetch user info from Google")
            return False
        google_info = resp.json()
@@ -180,117 +291,6 @@ if ub.oauth_support:
        return oauth_update_token(str(oauthblueprints[1]['id']), token, google_user_id)
    def oauth_update_token(provider_id, token, provider_user_id):
        session[provider_id + "_oauth_user_id"] = provider_user_id
        session[provider_id + "_oauth_token"] = token
        # Find this OAuth token in the database, or create it
        query = ub.session.query(ub.OAuth).filter_by(
            provider=provider_id,
            provider_user_id=provider_user_id,
        )
        try:
            oauth_entry = query.one()
            # update token
            oauth_entry.token = token
        except NoResultFound:
            oauth_entry = ub.OAuth(
                provider=provider_id,
                provider_user_id=provider_user_id,
                token=token,
            )
        try:
            ub.session.add(oauth_entry)
            ub.session.commit()
        except Exception as e:
            log.exception(e)
            ub.session.rollback()
        # Disable Flask-Dance's default behavior for saving the OAuth token
        # Value differrs depending on flask-dance version
        return backend_resultcode
    def bind_oauth_or_register(provider_id, provider_user_id, redirect_url, provider_name):
        query = ub.session.query(ub.OAuth).filter_by(
            provider=provider_id,
            provider_user_id=provider_user_id,
        )
        try:
            oauth_entry = query.first()
            # already bind with user, just login
            if oauth_entry.user:
                login_user(oauth_entry.user)
                log.debug(u"You are now logged in as: '%s'", oauth_entry.user.nickname)
                flash(_(u"you are now logged in as: '%(nickname)s'", nickname= oauth_entry.user.nickname),
                      category="success")
                return redirect(url_for('web.index'))
            else:
                # bind to current user
                if current_user and current_user.is_authenticated:
                    oauth_entry.user = current_user
                    try:
                        ub.session.add(oauth_entry)
                        ub.session.commit()
                        flash(_(u"Link to %(oauth)s Succeeded", oauth=provider_name), category="success")
                        return redirect(url_for('web.profile'))
                    except Exception as e:
                        log.exception(e)
                        ub.session.rollback()
                else:
                    flash(_(u"Login failed, No User Linked With OAuth Account"), category="error")
                log.info('Login failed, No User Linked With OAuth Account')
                return redirect(url_for('web.login'))
                # return redirect(url_for('web.login'))
                # if config.config_public_reg:
                #   return redirect(url_for('web.register'))
                # else:
                #    flash(_(u"Public registration is not enabled"), category="error")
                #    return redirect(url_for(redirect_url))
        except (NoResultFound, AttributeError):
            return redirect(url_for(redirect_url))
    def get_oauth_status():
        status = []
        query = ub.session.query(ub.OAuth).filter_by(
            user_id=current_user.id,
        )
        try:
            oauths = query.all()
            for oauth_entry in oauths:
                status.append(int(oauth_entry.provider))
            return status
        except NoResultFound:
            return None
    def unlink_oauth(provider):
        if request.host_url + 'me' != request.referrer:
            pass
        query = ub.session.query(ub.OAuth).filter_by(
            provider=provider,
            user_id=current_user.id,
        )
        try:
            oauth_entry = query.one()
            if current_user and current_user.is_authenticated:
                oauth_entry.user = current_user
                try:
                    ub.session.delete(oauth_entry)
                    ub.session.commit()
                    logout_oauth_user()
                    flash(_(u"Unlink to %(oauth)s Succeeded", oauth=oauth_check[provider]), category="success")
                except Exception as e:
                    log.exception(e)
                    ub.session.rollback()
                    flash(_(u"Unlink to %(oauth)s Failed", oauth=oauth_check[provider]), category="error")
        except NoResultFound:
            log.warning("oauth %s for user %d not found", provider, current_user.id)
            flash(_(u"Not Linked to %(oauth)s.", oauth=oauth_check[provider]), category="error")
        return redirect(url_for('web.profile'))
    # notify on OAuth provider error
    @oauth_error.connect_via(oauthblueprints[0]['blueprint'])
    def github_error(blueprint, error, error_description=None, error_uri=None):
@@ -305,39 +305,6 @@ if ub.oauth_support:
        )  # ToDo: Translate
        flash(msg, category="error")
    @oauth.route('/link/github')
    @oauth_required
    def github_login():
        if not github.authorized:
            return redirect(url_for('github.login'))
        account_info = github.get('/user')
        if account_info.ok:
            account_info_json = account_info.json()
            return bind_oauth_or_register(oauthblueprints[0]['id'], account_info_json['id'], 'github.login', 'github')
        flash(_(u"GitHub Oauth error, please retry later."), category="error")
        return redirect(url_for('web.login'))
    @oauth.route('/unlink/github', methods=["GET"])
    @login_required
    def github_login_unlink():
        return unlink_oauth(oauthblueprints[0]['id'])
    @oauth.route('/link/google')
    @oauth_required
    def google_login():
        if not google.authorized:
            return redirect(url_for("google.login"))
        resp = google.get("/oauth2/v2/userinfo")
        if resp.ok:
            account_info_json = resp.json()
            return bind_oauth_or_register(oauthblueprints[1]['id'], account_info_json['id'], 'google.login', 'google')
        flash(_(u"Google Oauth error, please retry later."), category="error")
        return redirect(url_for('web.login'))
    @oauth_error.connect_via(oauthblueprints[1]['blueprint'])
    def google_error(blueprint, error, error_description=None, error_uri=None):
        msg = (
@@ -352,7 +319,49 @@ if ub.oauth_support:
        flash(msg, category="error")
-    @oauth.route('/unlink/google', methods=["GET"])
+@oauth.route('/link/github')
-    @login_required
+@oauth_required
-    def google_login_unlink():
+def github_login():
-        return unlink_oauth(oauthblueprints[1]['blueprint'].name)
+    if not github.authorized:
        return redirect(url_for('github.login'))
    try:
        account_info = github.get('/user')
        if account_info.ok:
            account_info_json = account_info.json()
            return bind_oauth_or_register(oauthblueprints[0]['id'], account_info_json['id'], 'github.login', 'github')
        flash(_(u"GitHub Oauth error, please retry later."), category="error")
        log.error("GitHub Oauth error, please retry later")
    except (InvalidGrantError, TokenExpiredError) as e:
        flash(_(u"GitHub Oauth error: {}").format(e), category="error")
        log.error(e)
    return redirect(url_for('web.login'))
@oauth.route('/unlink/github', methods=["GET"])
@login_required
 def github_login_unlink():
    return unlink_oauth(oauthblueprints[0]['id'])
@oauth.route('/link/google')
@oauth_required
 def google_login():
    if not google.authorized:
        return redirect(url_for("google.login"))
    try:
        resp = google.get("/oauth2/v2/userinfo")
        if resp.ok:
            account_info_json = resp.json()
            return bind_oauth_or_register(oauthblueprints[1]['id'], account_info_json['id'], 'google.login', 'google')
        flash(_(u"Google Oauth error, please retry later."), category="error")
        log.error("Google Oauth error, please retry later")
    except (InvalidGrantError, TokenExpiredError) as e:
        flash(_(u"Google Oauth error: {}").format(e), category="error")
        log.error(e)
    return redirect(url_for('web.login'))
@oauth.route('/unlink/google', methods=["GET"])
@login_required
 def google_login_unlink():
    return unlink_oauth(oauthblueprints[1]['id'])
@@ -20,23 +20,20 @@
 #  You should have received a copy of the GNU General Public License
 #  along with this program. If not, see <http://www.gnu.org/licenses/>.
 from __future__ import division, print_function, unicode_literals
 import sys
 import datetime
 from functools import wraps
-from flask import Blueprint, request, render_template, Response, g, make_response
+from flask import Blueprint, request, render_template, Response, g, make_response, abort
 from flask_login import current_user
-from sqlalchemy.sql.expression import func, text, or_, and_
+from sqlalchemy.sql.expression import func, text, or_, and_, true
 from werkzeug.security import check_password_hash
-from . import constants, logger, config, db, ub, services, get_locale, isoLanguages
+from . import constants, logger, config, db, calibre_db, ub, services, get_locale, isoLanguages
-from .helper import fill_indexpage, get_download_link, get_book_cover, speaking_language
+from .helper import get_download_link, get_book_cover
 from .pagination import Pagination
-from .web import common_filters, get_search_results, render_read_books, download_required
+from .web import render_read_books
 from .usermanagement import load_user_from_request
 from flask_babel import gettext as _
 from babel import Locale as LC
 from babel.core import UnknownLocaleError
 opds = Blueprint('opds', __name__)
@@ -51,7 +48,7 @@ def requires_basic_auth_if_no_ano(f):
            if not auth or auth.type != 'basic' or not check_auth(auth.username, auth.password):
                return authenticate()
        return f(*args, **kwargs)
-    if config.config_login_type == constants.LOGIN_LDAP and services.ldap:
+    if config.config_login_type == constants.LOGIN_LDAP and services.ldap and config.config_anonbrowse != 1:
        return services.ldap.basic_auth_required(f)
    return decorated
@@ -93,22 +90,60 @@ def feed_cc_search(query):
@opds.route("/opds/search", methods=["GET"])
@requires_basic_auth_if_no_ano
 def feed_normal_search():
-    return feed_search(request.args.get("query").strip())
+    return feed_search(request.args.get("query", "").strip())
@opds.route("/opds/books")
@requires_basic_auth_if_no_ano
 def feed_booksindex():
    shift = 0
    off = int(request.args.get("offset") or 0)
    entries = calibre_db.session.query(func.upper(func.substr(db.Books.sort, 1, 1)).label('id'))\
        .filter(calibre_db.common_filters()).group_by(func.upper(func.substr(db.Books.sort, 1, 1))).all()
    elements = []
    if off == 0:
        elements.append({'id': "00", 'name':_("All")})
        shift = 1
    for entry in entries[
                 off + shift - 1:
                 int(off + int(config.config_books_per_page) - shift)]:
        elements.append({'id': entry.id, 'name': entry.id})
    pagination = Pagination((int(off) / (int(config.config_books_per_page)) + 1), config.config_books_per_page,
                            len(entries) + 1)
    return render_xml_template('feed.xml',
                               letterelements=elements,
                               folder='opds.feed_letter_books',
                               pagination=pagination)
@opds.route("/opds/books/letter/<book_id>")
@requires_basic_auth_if_no_ano
 def feed_letter_books(book_id):
    off = request.args.get("offset") or 0
    letter = true() if book_id == "00" else func.upper(db.Books.sort).startswith(book_id)
    entries, __, pagination = calibre_db.fill_indexpage((int(off) / (int(config.config_books_per_page)) + 1), 0,
                                                        db.Books,
                                                        letter,
                                                        [db.Books.sort])
    return render_xml_template('feed.xml', entries=entries, pagination=pagination)
@opds.route("/opds/new")
@requires_basic_auth_if_no_ano
 def feed_new():
    off = request.args.get("offset") or 0
-    entries, __, pagination = fill_indexpage((int(off) / (int(config.config_books_per_page)) + 1),
+    entries, __, pagination = calibre_db.fill_indexpage((int(off) / (int(config.config_books_per_page)) + 1), 0,
-                                             db.Books, True, [db.Books.timestamp.desc()])
+                                                        db.Books, True, [db.Books.timestamp.desc()])
    return render_xml_template('feed.xml', entries=entries, pagination=pagination)
@opds.route("/opds/discover")
@requires_basic_auth_if_no_ano
 def feed_discover():
-    entries = db.session.query(db.Books).filter(common_filters()).order_by(func.random())\
+    entries = calibre_db.session.query(db.Books).filter(calibre_db.common_filters()).order_by(func.random())\
        .limit(config.config_books_per_page)
    pagination = Pagination(1, config.config_books_per_page, int(config.config_books_per_page))
    return render_xml_template('feed.xml', entries=entries, pagination=pagination)
@@ -118,9 +153,9 @@ def feed_discover():
@requires_basic_auth_if_no_ano
 def feed_best_rated():
    off = request.args.get("offset") or 0
-    entries, __, pagination = fill_indexpage((int(off) / (int(config.config_books_per_page)) + 1),
+    entries, __, pagination = calibre_db.fill_indexpage((int(off) / (int(config.config_books_per_page)) + 1), 0,
-                                             db.Books, db.Books.ratings.any(db.Ratings.rating > 9),
+                                                        db.Books, db.Books.ratings.any(db.Ratings.rating > 9),
-                                             [db.Books.timestamp.desc()])
+                                                        [db.Books.timestamp.desc()])
    return render_xml_template('feed.xml', entries=entries, pagination=pagination)
@@ -133,16 +168,13 @@ def feed_hot():
    hot_books = all_books.offset(off).limit(config.config_books_per_page)
    entries = list()
    for book in hot_books:
-        downloadBook = db.session.query(db.Books).filter(db.Books.id == book.Downloads.book_id).first()
+        downloadBook = calibre_db.get_book(book.Downloads.book_id)
        if downloadBook:
            entries.append(
-                db.session.query(db.Books).filter(common_filters())
+                calibre_db.get_filtered_book(book.Downloads.book_id)
                .filter(db.Books.id == book.Downloads.book_id).first()
            )
        else:
            ub.delete_download(book.Downloads.book_id)
            # ub.session.query(ub.Downloads).filter(book.Downloads.book_id == ub.Downloads.book_id).delete()
            # ub.session.commit()
    numBooks = entries.__len__()
    pagination = Pagination((int(off) / (int(config.config_books_per_page)) + 1),
                            config.config_books_per_page, numBooks)
@@ -152,12 +184,41 @@ def feed_hot():
@opds.route("/opds/author")
@requires_basic_auth_if_no_ano
 def feed_authorindex():
-    off = request.args.get("offset") or 0
+    shift = 0
-    entries = db.session.query(db.Authors).join(db.books_authors_link).join(db.Books).filter(common_filters())\
+    off = int(request.args.get("offset") or 0)
-        .group_by(text('books_authors_link.author')).order_by(db.Authors.sort).limit(config.config_books_per_page)\
+    entries = calibre_db.session.query(func.upper(func.substr(db.Authors.sort, 1, 1)).label('id'))\
-        .offset(off)
+        .join(db.books_authors_link).join(db.Books).filter(calibre_db.common_filters())\
        .group_by(func.upper(func.substr(db.Authors.sort, 1, 1))).all()
    elements = []
    if off == 0:
        elements.append({'id': "00", 'name':_("All")})
        shift = 1
    for entry in entries[
                 off + shift - 1:
                 int(off + int(config.config_books_per_page) - shift)]:
        elements.append({'id': entry.id, 'name': entry.id})
    pagination = Pagination((int(off) / (int(config.config_books_per_page)) + 1), config.config_books_per_page,
-                            len(db.session.query(db.Authors).all()))
+                            len(entries) + 1)
    return render_xml_template('feed.xml',
                               letterelements=elements,
                               folder='opds.feed_letter_author',
                               pagination=pagination)
@opds.route("/opds/author/letter/<book_id>")
@requires_basic_auth_if_no_ano
 def feed_letter_author(book_id):
    off = request.args.get("offset") or 0
    letter = true() if book_id == "00" else func.upper(db.Authors.sort).startswith(book_id)
    entries = calibre_db.session.query(db.Authors).join(db.books_authors_link).join(db.Books)\
        .filter(calibre_db.common_filters()).filter(letter)\
        .group_by(text('books_authors_link.author'))\
        .order_by(db.Authors.sort)
    pagination = Pagination((int(off) / (int(config.config_books_per_page)) + 1), config.config_books_per_page,
                            entries.count())
    entries = entries.limit(config.config_books_per_page).offset(off).all()
    return render_xml_template('feed.xml', listelements=entries, folder='opds.feed_author', pagination=pagination)
@@ -165,10 +226,10 @@ def feed_authorindex():
@requires_basic_auth_if_no_ano
 def feed_author(book_id):
    off = request.args.get("offset") or 0
-    entries, __, pagination = fill_indexpage((int(off) / (int(config.config_books_per_page)) + 1),
+    entries, __, pagination = calibre_db.fill_indexpage((int(off) / (int(config.config_books_per_page)) + 1), 0,
-                                             db.Books,
+                                                        db.Books,
-                                             db.Books.authors.any(db.Authors.id == book_id),
+                                                        db.Books.authors.any(db.Authors.id == book_id),
-                                             [db.Books.timestamp.desc()])
+                                                        [db.Books.timestamp.desc()])
    return render_xml_template('feed.xml', entries=entries, pagination=pagination)
@@ -176,11 +237,14 @@ def feed_author(book_id):
@requires_basic_auth_if_no_ano
 def feed_publisherindex():
    off = request.args.get("offset") or 0
-    entries = db.session.query(db.Publishers).join(db.books_publishers_link).join(db.Books).filter(common_filters())\
+    entries = calibre_db.session.query(db.Publishers)\
-        .group_by(text('books_publishers_link.publisher')).order_by(db.Publishers.sort)\
+        .join(db.books_publishers_link)\
        .join(db.Books).filter(calibre_db.common_filters())\
        .group_by(text('books_publishers_link.publisher'))\
        .order_by(db.Publishers.sort)\
        .limit(config.config_books_per_page).offset(off)
    pagination = Pagination((int(off) / (int(config.config_books_per_page)) + 1), config.config_books_per_page,
-                            len(db.session.query(db.Publishers).all()))
+                            len(calibre_db.session.query(db.Publishers).all()))
    return render_xml_template('feed.xml', listelements=entries, folder='opds.feed_publisher', pagination=pagination)
@@ -188,21 +252,51 @@ def feed_publisherindex():
@requires_basic_auth_if_no_ano
 def feed_publisher(book_id):
    off = request.args.get("offset") or 0
-    entries, __, pagination = fill_indexpage((int(off) / (int(config.config_books_per_page)) + 1),
+    entries, __, pagination = calibre_db.fill_indexpage((int(off) / (int(config.config_books_per_page)) + 1), 0,
-                                             db.Books,
+                                                        db.Books,
-                                             db.Books.publishers.any(db.Publishers.id == book_id),
+                                                        db.Books.publishers.any(db.Publishers.id == book_id),
-                                             [db.Books.timestamp.desc()])
+                                                        [db.Books.timestamp.desc()])
    return render_xml_template('feed.xml', entries=entries, pagination=pagination)
@opds.route("/opds/category")
@requires_basic_auth_if_no_ano
 def feed_categoryindex():
-    off = request.args.get("offset") or 0
+    shift = 0
-    entries = db.session.query(db.Tags).join(db.books_tags_link).join(db.Books).filter(common_filters())\
+    off = int(request.args.get("offset") or 0)
-        .group_by(text('books_tags_link.tag')).order_by(db.Tags.name).offset(off).limit(config.config_books_per_page)
+    entries = calibre_db.session.query(func.upper(func.substr(db.Tags.name, 1, 1)).label('id'))\
        .join(db.books_tags_link).join(db.Books).filter(calibre_db.common_filters())\
        .group_by(func.upper(func.substr(db.Tags.name, 1, 1))).all()
    elements = []
    if off == 0:
        elements.append({'id': "00", 'name':_("All")})
        shift = 1
    for entry in entries[
                 off + shift - 1:
                 int(off + int(config.config_books_per_page) - shift)]:
        elements.append({'id': entry.id, 'name': entry.id})
    pagination = Pagination((int(off) / (int(config.config_books_per_page)) + 1), config.config_books_per_page,
-                            len(db.session.query(db.Tags).all()))
+                            len(entries) + 1)
    return render_xml_template('feed.xml',
                               letterelements=elements,
                               folder='opds.feed_letter_category',
                               pagination=pagination)
@opds.route("/opds/category/letter/<book_id>")
@requires_basic_auth_if_no_ano
 def feed_letter_category(book_id):
    off = request.args.get("offset") or 0
    letter = true() if book_id == "00" else func.upper(db.Tags.name).startswith(book_id)
    entries = calibre_db.session.query(db.Tags)\
        .join(db.books_tags_link)\
        .join(db.Books)\
        .filter(calibre_db.common_filters()).filter(letter)\
        .group_by(text('books_tags_link.tag'))\
        .order_by(db.Tags.name)
    pagination = Pagination((int(off) / (int(config.config_books_per_page)) + 1), config.config_books_per_page,
                            entries.count())
    entries = entries.offset(off).limit(config.config_books_per_page).all()
    return render_xml_template('feed.xml', listelements=entries, folder='opds.feed_category', pagination=pagination)
@@ -210,21 +304,50 @@ def feed_categoryindex():
@requires_basic_auth_if_no_ano
 def feed_category(book_id):
    off = request.args.get("offset") or 0
-    entries, __, pagination = fill_indexpage((int(off) / (int(config.config_books_per_page)) + 1),
+    entries, __, pagination = calibre_db.fill_indexpage((int(off) / (int(config.config_books_per_page)) + 1), 0,
-                                             db.Books,
+                                                        db.Books,
-                                             db.Books.tags.any(db.Tags.id == book_id),
+                                                        db.Books.tags.any(db.Tags.id == book_id),
-                                             [db.Books.timestamp.desc()])
+                                                        [db.Books.timestamp.desc()])
    return render_xml_template('feed.xml', entries=entries, pagination=pagination)
@opds.route("/opds/series")
@requires_basic_auth_if_no_ano
 def feed_seriesindex():
-    off = request.args.get("offset") or 0
+    shift = 0
-    entries = db.session.query(db.Series).join(db.books_series_link).join(db.Books).filter(common_filters())\
+    off = int(request.args.get("offset") or 0)
-        .group_by(text('books_series_link.series')).order_by(db.Series.sort).offset(off).all()
+    entries = calibre_db.session.query(func.upper(func.substr(db.Series.sort, 1, 1)).label('id'))\
        .join(db.books_series_link).join(db.Books).filter(calibre_db.common_filters())\
        .group_by(func.upper(func.substr(db.Series.sort, 1, 1))).all()
    elements = []
    if off == 0:
        elements.append({'id': "00", 'name':_("All")})
        shift = 1
    for entry in entries[
                 off + shift - 1:
                 int(off + int(config.config_books_per_page) - shift)]:
        elements.append({'id': entry.id, 'name': entry.id})
    pagination = Pagination((int(off) / (int(config.config_books_per_page)) + 1), config.config_books_per_page,
-                            len(db.session.query(db.Series).all()))
+                            len(entries) + 1)
    return render_xml_template('feed.xml',
                               letterelements=elements,
                               folder='opds.feed_letter_series',
                               pagination=pagination)
@opds.route("/opds/series/letter/<book_id>")
@requires_basic_auth_if_no_ano
 def feed_letter_series(book_id):
    off = request.args.get("offset") or 0
    letter = true() if book_id == "00" else func.upper(db.Series.sort).startswith(book_id)
    entries = calibre_db.session.query(db.Series)\
        .join(db.books_series_link)\
        .join(db.Books)\
        .filter(calibre_db.common_filters()).filter(letter)\
        .group_by(text('books_series_link.series'))\
        .order_by(db.Series.sort)
    pagination = Pagination((int(off) / (int(config.config_books_per_page)) + 1), config.config_books_per_page,
                            entries.count())
    entries = entries.offset(off).limit(config.config_books_per_page).all()
    return render_xml_template('feed.xml', listelements=entries, folder='opds.feed_series', pagination=pagination)
@@ -232,10 +355,10 @@ def feed_seriesindex():
@requires_basic_auth_if_no_ano
 def feed_series(book_id):
    off = request.args.get("offset") or 0
-    entries, __, pagination = fill_indexpage((int(off) / (int(config.config_books_per_page)) + 1),
+    entries, __, pagination = calibre_db.fill_indexpage((int(off) / (int(config.config_books_per_page)) + 1), 0,
-                                             db.Books,
+                                                        db.Books,
-                                             db.Books.series.any(db.Series.id == book_id),
+                                                        db.Books.series.any(db.Series.id == book_id),
-                                             [db.Books.series_index])
+                                                        [db.Books.series_index])
    return render_xml_template('feed.xml', entries=entries, pagination=pagination)
@@ -243,16 +366,19 @@ def feed_series(book_id):
@requires_basic_auth_if_no_ano
 def feed_ratingindex():
    off = request.args.get("offset") or 0
-    entries = db.session.query(db.Ratings, func.count('books_ratings_link.book').label('count'),
+    entries = calibre_db.session.query(db.Ratings, func.count('books_ratings_link.book').label('count'),
                               (db.Ratings.rating / 2).label('name')) \
-        .join(db.books_ratings_link).join(db.Books).filter(common_filters()) \
+        .join(db.books_ratings_link)\
-        .group_by(text('books_ratings_link.rating')).order_by(db.Ratings.rating).all()
+        .join(db.Books)\
        .filter(calibre_db.common_filters()) \
        .group_by(text('books_ratings_link.rating'))\
        .order_by(db.Ratings.rating).all()
    pagination = Pagination((int(off) / (int(config.config_books_per_page)) + 1), config.config_books_per_page,
                            len(entries))
    element = list()
    for entry in entries:
-        element.append(FeedObject(entry[0].id, "{} Stars".format(entry.name)))
+        element.append(FeedObject(entry[0].id, _("{} Stars").format(entry.name)))
    return render_xml_template('feed.xml', listelements=element, folder='opds.feed_ratings', pagination=pagination)
@@ -260,10 +386,10 @@ def feed_ratingindex():
@requires_basic_auth_if_no_ano
 def feed_ratings(book_id):
    off = request.args.get("offset") or 0
-    entries, __, pagination = fill_indexpage((int(off) / (int(config.config_books_per_page)) + 1),
+    entries, __, pagination = calibre_db.fill_indexpage((int(off) / (int(config.config_books_per_page)) + 1), 0,
-                                             db.Books,
+                                                        db.Books,
-                                             db.Books.ratings.any(db.Ratings.id == book_id),
+                                                        db.Books.ratings.any(db.Ratings.id == book_id),
-                                             [db.Books.timestamp.desc()])
+                                                        [db.Books.timestamp.desc()])
    return render_xml_template('feed.xml', entries=entries, pagination=pagination)
@@ -271,8 +397,10 @@ def feed_ratings(book_id):
@requires_basic_auth_if_no_ano
 def feed_formatindex():
    off = request.args.get("offset") or 0
-    entries = db.session.query(db.Data).join(db.Books).filter(common_filters()) \
+    entries = calibre_db.session.query(db.Data).join(db.Books)\
-        .group_by(db.Data.format).order_by(db.Data.format).all()
+        .filter(calibre_db.common_filters()) \
        .group_by(db.Data.format)\
        .order_by(db.Data.format).all()
    pagination = Pagination((int(off) / (int(config.config_books_per_page)) + 1), config.config_books_per_page,
                            len(entries))
@@ -286,10 +414,10 @@ def feed_formatindex():
@requires_basic_auth_if_no_ano
 def feed_format(book_id):
    off = request.args.get("offset") or 0
-    entries, __, pagination = fill_indexpage((int(off) / (int(config.config_books_per_page)) + 1),
+    entries, __, pagination = calibre_db.fill_indexpage((int(off) / (int(config.config_books_per_page)) + 1), 0,
-                                             db.Books,
+                                                        db.Books,
-                                             db.Books.data.any(db.Data.format == book_id.upper()),
+                                                        db.Books.data.any(db.Data.format == book_id.upper()),
-                                             [db.Books.timestamp.desc()])
+                                                        [db.Books.timestamp.desc()])
    return render_xml_template('feed.xml', entries=entries, pagination=pagination)
@@ -299,18 +427,19 @@ def feed_format(book_id):
 def feed_languagesindex():
    off = request.args.get("offset") or 0
    if current_user.filter_language() == u"all":
-        languages = speaking_language()
+        languages = calibre_db.speaking_language()
    else:
-        try:
+        #try:
-            cur_l = LC.parse(current_user.filter_language())
+        #    cur_l = LC.parse(current_user.filter_language())
-        except UnknownLocaleError:
+        #except UnknownLocaleError:
-            cur_l = None
+        #    cur_l = None
-        languages = db.session.query(db.Languages).filter(
+        languages = calibre_db.session.query(db.Languages).filter(
            db.Languages.lang_code == current_user.filter_language()).all()
-        if cur_l:
+        languages[0].name = isoLanguages.get_language_name(get_locale(), languages[0].lang_code)
-            languages[0].name = cur_l.get_language_name(get_locale())
+        #if cur_l:
-        else:
+        #    languages[0].name = cur_l.get_language_name(get_locale())
-            languages[0].name = _(isoLanguages.get(part3=languages[0].lang_code).name)
+        #else:
        #    languages[0].name = _(isoLanguages.get(part3=languages[0].lang_code).name)
    pagination = Pagination((int(off) / (int(config.config_books_per_page)) + 1), config.config_books_per_page,
                            len(languages))
    return render_xml_template('feed.xml', listelements=languages, folder='opds.feed_languages', pagination=pagination)
@@ -320,10 +449,10 @@ def feed_languagesindex():
@requires_basic_auth_if_no_ano
 def feed_languages(book_id):
    off = request.args.get("offset") or 0
-    entries, __, pagination = fill_indexpage((int(off) / (int(config.config_books_per_page)) + 1),
+    entries, __, pagination = calibre_db.fill_indexpage((int(off) / (int(config.config_books_per_page)) + 1), 0,
-                                             db.Books,
+                                                        db.Books,
-                                             db.Books.languages.any(db.Languages.id == book_id),
+                                                        db.Books.languages.any(db.Languages.id == book_id),
-                                             [db.Books.timestamp.desc()])
+                                                        [db.Books.timestamp.desc()])
    return render_xml_template('feed.xml', entries=entries, pagination=pagination)
@@ -356,7 +485,7 @@ def feed_shelf(book_id):
        books_in_shelf = ub.session.query(ub.BookShelf).filter(ub.BookShelf.shelf == book_id).order_by(
            ub.BookShelf.order.asc()).all()
        for book in books_in_shelf:
-            cur_book = db.session.query(db.Books).filter(db.Books.id == book.book_id).first()
+            cur_book = calibre_db.get_book(book.book_id)
            result.append(cur_book)
    pagination = Pagination((int(off) / (int(config.config_books_per_page)) + 1), config.config_books_per_page,
                            len(result))
@@ -365,16 +494,25 @@ def feed_shelf(book_id):
@opds.route("/opds/download/<book_id>/<book_format>/")
@requires_basic_auth_if_no_ano
@download_required
 def opds_download_link(book_id, book_format):
-    return get_download_link(book_id, book_format.lower())
+    # I gave up with this: With enabled ldap login, the user doesn't get logged in, therefore it's always guest
    # workaround, loading the user from the request and checking it's download rights here
    # in case of anonymous browsing user is None
    user = load_user_from_request(request) or current_user
    if not user.role_download():
        return abort(403)
    if "Kobo" in request.headers.get('User-Agent'):
        client = "kobo"
    else:
        client = ""
    return get_download_link(book_id, book_format.lower(), client)
@opds.route("/ajax/book/<string:uuid>/<library>")
@opds.route("/ajax/book/<string:uuid>", defaults={'library': ""})
@requires_basic_auth_if_no_ano
 def get_metadata_calibre_companion(uuid, library):
-    entry = db.session.query(db.Books).filter(db.Books.uuid.like("%" + uuid + "%")).first()
+    entry = calibre_db.session.query(db.Books).filter(db.Books.uuid.like("%" + uuid + "%")).first()
    if entry is not None:
        js = render_template('json.txt', entry=entry)
        response = make_response(js)
@@ -386,8 +524,7 @@ def get_metadata_calibre_companion(uuid, library):
 def feed_search(term):
    if term:
-        term = term.strip().lower()
+        entries, __, ___ = calibre_db.get_search_results(term)
        entries = get_search_results(term)
        entriescount = len(entries) if len(entries) > 0 else 1
        pagination = Pagination(1, entriescount, entriescount)
        return render_xml_template('feed.xml', searchterm=term, entries=entries, pagination=pagination)
@@ -396,11 +533,18 @@ def feed_search(term):
 def check_auth(username, password):
-    if sys.version_info.major == 3:
+    try:
        username = username.encode('windows-1252')
-    user = ub.session.query(ub.User).filter(func.lower(ub.User.nickname) ==
+    except UnicodeEncodeError:
        username = username.encode('utf-8')
    user = ub.session.query(ub.User).filter(func.lower(ub.User.name) ==
                                            username.decode('utf-8').lower()).first()
-    return bool(user and check_password_hash(str(user.password), password))
+    if bool(user and check_password_hash(str(user.password), password)):
        return True
    else:
        ip_Address = request.headers.get('X-Forwarded-For', request.remote_addr)
        log.warning('OPDS Login failed for user "%s" IP-address: %s', username.decode('utf-8'), ip_Address)
        return False
 def authenticate():
@@ -20,7 +20,6 @@
 #  You should have received a copy of the GNU General Public License
 #  along with this program. If not, see <http://www.gnu.org/licenses/>.
 from __future__ import division, print_function, unicode_literals
 from math import ceil
@@ -27,11 +27,8 @@
 # http://flask.pocoo.org/snippets/62/
-from __future__ import division, print_function, unicode_literals
+from urllib.parse import urlparse, urljoin
-try:
+
    from urllib.parse import urlparse, urljoin
 except ImportError:
    from urlparse import urlparse, urljoin
 from flask import request, url_for, redirect
@@ -0,0 +1,138 @@
 # -*- coding: utf-8 -*-
 #  This file is part of the Calibre-Web (https://github.com/janeczku/calibre-web)
 #    Copyright (C) 2018-2019 OzzieIsaacs, cervinko, jkrehm, bodybybuddha, ok11,
 #                            andy29485, idalin, Kyosfonica, wuqi, Kennyl, lemmsh,
 #                            falgh1, grunjol, csitko, ytils, xybydy, trasba, vrabe,
 #                            ruben-herold, marblepebble, JackED42, SiphonSquirrel,
 #                            apetresc, nanu-c, mutschler
 #
 #  This program is free software: you can redistribute it and/or modify
 #  it under the terms of the GNU General Public License as published by
 #  the Free Software Foundation, either version 3 of the License, or
 #  (at your option) any later version.
 #
 #  This program is distributed in the hope that it will be useful,
 #  but WITHOUT ANY WARRANTY; without even the implied warranty of
 #  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 #  GNU General Public License for more details.
 #
 #  You should have received a copy of the GNU General Public License
 #  along with this program. If not, see <http://www.gnu.org/licenses/>.
 import json
 from datetime import datetime
 from flask import Blueprint, request, make_response, abort, url_for, flash, redirect
 from flask_login import login_required, current_user, login_user
 from flask_babel import gettext as _
 from sqlalchemy.sql.expression import true
 from . import config, logger, ub
 from .render_template import render_title_template
 try:
    from functools import wraps
 except ImportError:
    pass  # We're not using Python 3
 remotelogin = Blueprint('remotelogin', __name__)
 log = logger.create()
 def remote_login_required(f):
    @wraps(f)
    def inner(*args, **kwargs):
        if config.config_remote_login:
            return f(*args, **kwargs)
        if request.headers.get('X-Requested-With') == 'XMLHttpRequest':
            data = {'status': 'error', 'message': 'Forbidden'}
            response = make_response(json.dumps(data, ensure_ascii=False))
            response.headers["Content-Type"] = "application/json; charset=utf-8"
            return response, 403
        abort(403)
    return inner
@remotelogin.route('/remote/login')
@remote_login_required
 def remote_login():
    auth_token = ub.RemoteAuthToken()
    ub.session.add(auth_token)
    ub.session_commit()
    verify_url = url_for('remotelogin.verify_token', token=auth_token.auth_token, _external=true)
    log.debug(u"Remot Login request with token: %s", auth_token.auth_token)
    return render_title_template('remote_login.html', title=_(u"Login"), token=auth_token.auth_token,
                                 verify_url=verify_url, page="remotelogin")
@remotelogin.route('/verify/<token>')
@remote_login_required
@login_required
 def verify_token(token):
    auth_token = ub.session.query(ub.RemoteAuthToken).filter(ub.RemoteAuthToken.auth_token == token).first()
    # Token not found
    if auth_token is None:
        flash(_(u"Token not found"), category="error")
        log.error(u"Remote Login token not found")
        return redirect(url_for('web.index'))
    # Token expired
    elif datetime.now() > auth_token.expiration:
        ub.session.delete(auth_token)
        ub.session_commit()
        flash(_(u"Token has expired"), category="error")
        log.error(u"Remote Login token expired")
        return redirect(url_for('web.index'))
    # Update token with user information
    auth_token.user_id = current_user.id
    auth_token.verified = True
    ub.session_commit()
    flash(_(u"Success! Please return to your device"), category="success")
    log.debug(u"Remote Login token for userid %s verified", auth_token.user_id)
    return redirect(url_for('web.index'))
@remotelogin.route('/ajax/verify_token', methods=['POST'])
@remote_login_required
 def token_verified():
    token = request.form['token']
    auth_token = ub.session.query(ub.RemoteAuthToken).filter(ub.RemoteAuthToken.auth_token == token).first()
    data = {}
    # Token not found
    if auth_token is None:
        data['status'] = 'error'
        data['message'] = _(u"Token not found")
    # Token expired
    elif datetime.now() > auth_token.expiration:
        ub.session.delete(auth_token)
        ub.session_commit()
        data['status'] = 'error'
        data['message'] = _(u"Token has expired")
    elif not auth_token.verified:
        data['status'] = 'not_verified'
    else:
        user = ub.session.query(ub.User).filter(ub.User.id == auth_token.user_id).first()
        login_user(user)
        ub.session.delete(auth_token)
        ub.session_commit("User {} logged in via remotelogin, token deleted".format(user.name))
        data['status'] = 'success'
        log.debug(u"Remote Login for userid %s succeded", user.id)
        flash(_(u"you are now logged in as: '%(nickname)s'", nickname=user.name), category="success")
    response = make_response(json.dumps(data, ensure_ascii=False))
    response.headers["Content-Type"] = "application/json; charset=utf-8"
    return response
@@ -0,0 +1,122 @@
 # -*- coding: utf-8 -*-
 #  This file is part of the Calibre-Web (https://github.com/janeczku/calibre-web)
 #    Copyright (C) 2018-2020 OzzieIsaacs
 #
 #  This program is free software: you can redistribute it and/or modify
 #  it under the terms of the GNU General Public License as published by
 #  the Free Software Foundation, either version 3 of the License, or
 #  (at your option) any later version.
 #
 #  This program is distributed in the hope that it will be useful,
 #  but WITHOUT ANY WARRANTY; without even the implied warranty of
 #  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 #  GNU General Public License for more details.
 #
 #  You should have received a copy of the GNU General Public License
 #  along with this program. If not, see <http://www.gnu.org/licenses/>.
 from flask import render_template
 from flask_babel import gettext as _
 from flask import g
 from werkzeug.local import LocalProxy
 from flask_login import current_user
 from . import config, constants, ub, logger, db, calibre_db
 from .ub import User
 log = logger.create()
 def get_sidebar_config(kwargs=None):
    kwargs = kwargs or []
    if 'content' in kwargs:
        content = kwargs['content']
        content = isinstance(content, (User, LocalProxy)) and not content.role_anonymous()
    else:
        content = 'conf' in kwargs
    sidebar = list()
    sidebar.append({"glyph": "glyphicon-book", "text": _('Books'), "link": 'web.index', "id": "new",
                    "visibility": constants.SIDEBAR_RECENT, 'public': True, "page": "root",
                    "show_text": _('Show recent books'), "config_show":False})
    sidebar.append({"glyph": "glyphicon-fire", "text": _('Hot Books'), "link": 'web.books_list', "id": "hot",
                    "visibility": constants.SIDEBAR_HOT, 'public': True, "page": "hot",
                    "show_text": _('Show Hot Books'), "config_show": True})
    if current_user.role_admin():
        sidebar.append({"glyph": "glyphicon-download", "text": _('Downloaded Books'), "link": 'web.download_list',
                        "id": "download", "visibility": constants.SIDEBAR_DOWNLOAD, 'public': (not g.user.is_anonymous),
                        "page": "download", "show_text": _('Show Downloaded Books'),
                        "config_show": content})
    else:
        sidebar.append({"glyph": "glyphicon-download", "text": _('Downloaded Books'), "link": 'web.books_list',
                        "id": "download", "visibility": constants.SIDEBAR_DOWNLOAD, 'public': (not g.user.is_anonymous),
                        "page": "download", "show_text": _('Show Downloaded Books'),
                        "config_show": content})
    sidebar.append(
        {"glyph": "glyphicon-star", "text": _('Top Rated Books'), "link": 'web.books_list', "id": "rated",
         "visibility": constants.SIDEBAR_BEST_RATED, 'public': True, "page": "rated",
         "show_text": _('Show Top Rated Books'), "config_show": True})
    sidebar.append({"glyph": "glyphicon-eye-open", "text": _('Read Books'), "link": 'web.books_list', "id": "read",
                    "visibility": constants.SIDEBAR_READ_AND_UNREAD, 'public': (not g.user.is_anonymous),
                    "page": "read", "show_text": _('Show read and unread'), "config_show": content})
    sidebar.append(
        {"glyph": "glyphicon-eye-close", "text": _('Unread Books'), "link": 'web.books_list', "id": "unread",
         "visibility": constants.SIDEBAR_READ_AND_UNREAD, 'public': (not g.user.is_anonymous), "page": "unread",
         "show_text": _('Show unread'), "config_show": False})
    sidebar.append({"glyph": "glyphicon-random", "text": _('Discover'), "link": 'web.books_list', "id": "rand",
                    "visibility": constants.SIDEBAR_RANDOM, 'public': True, "page": "discover",
                    "show_text": _('Show Random Books'), "config_show": True})
    sidebar.append({"glyph": "glyphicon-inbox", "text": _('Categories'), "link": 'web.category_list', "id": "cat",
                    "visibility": constants.SIDEBAR_CATEGORY, 'public': True, "page": "category",
                    "show_text": _('Show category selection'), "config_show": True})
    sidebar.append({"glyph": "glyphicon-bookmark", "text": _('Series'), "link": 'web.series_list', "id": "serie",
                    "visibility": constants.SIDEBAR_SERIES, 'public': True, "page": "series",
                    "show_text": _('Show series selection'), "config_show": True})
    sidebar.append({"glyph": "glyphicon-user", "text": _('Authors'), "link": 'web.author_list', "id": "author",
                    "visibility": constants.SIDEBAR_AUTHOR, 'public': True, "page": "author",
                    "show_text": _('Show author selection'), "config_show": True})
    sidebar.append(
        {"glyph": "glyphicon-text-size", "text": _('Publishers'), "link": 'web.publisher_list', "id": "publisher",
         "visibility": constants.SIDEBAR_PUBLISHER, 'public': True, "page": "publisher",
         "show_text": _('Show publisher selection'), "config_show":True})
    sidebar.append({"glyph": "glyphicon-flag", "text": _('Languages'), "link": 'web.language_overview', "id": "lang",
                    "visibility": constants.SIDEBAR_LANGUAGE, 'public': (g.user.filter_language() == 'all'),
                    "page": "language",
                    "show_text": _('Show language selection'), "config_show": True})
    sidebar.append({"glyph": "glyphicon-star-empty", "text": _('Ratings'), "link": 'web.ratings_list', "id": "rate",
                    "visibility": constants.SIDEBAR_RATING, 'public': True,
                    "page": "rating", "show_text": _('Show ratings selection'), "config_show": True})
    sidebar.append({"glyph": "glyphicon-file", "text": _('File formats'), "link": 'web.formats_list', "id": "format",
                    "visibility": constants.SIDEBAR_FORMAT, 'public': True,
                    "page": "format", "show_text": _('Show file formats selection'), "config_show": True})
    sidebar.append(
        {"glyph": "glyphicon-trash", "text": _('Archived Books'), "link": 'web.books_list', "id": "archived",
         "visibility": constants.SIDEBAR_ARCHIVED, 'public': (not g.user.is_anonymous), "page": "archived",
         "show_text": _('Show archived books'), "config_show": content})
    sidebar.append(
        {"glyph": "glyphicon-th-list", "text": _('Books List'), "link": 'web.books_table', "id": "list",
         "visibility": constants.SIDEBAR_LIST, 'public': (not g.user.is_anonymous), "page": "list",
         "show_text": _('Show Books List'), "config_show": content})
    return sidebar
 def get_readbooks_ids():
    if not config.config_read_column:
        readBooks = ub.session.query(ub.ReadBook).filter(ub.ReadBook.user_id == int(current_user.id))\
            .filter(ub.ReadBook.read_status == ub.ReadBook.STATUS_FINISHED).all()
        return frozenset([x.book_id for x in readBooks])
    else:
        try:
            readBooks = calibre_db.session.query(db.cc_classes[config.config_read_column])\
                .filter(db.cc_classes[config.config_read_column].value == True).all()
            return frozenset([x.book for x in readBooks])
        except (KeyError, AttributeError):
            log.error("Custom Column No.%d is not existing in calibre database", config.config_read_column)
            return []
 # Returns the template for rendering and includes the instance name
 def render_title_template(*args, **kwargs):
    sidebar = get_sidebar_config(kwargs)
    return render_template(instance=config.config_calibre_web_title, sidebar=sidebar,
                           accept=constants.EXTENSIONS_UPLOAD, read_book_ids=get_readbooks_ids(),
                           *args, **kwargs)
@@ -36,8 +36,6 @@
 #
 # Inspired by http://flask.pocoo.org/snippets/35/
 from __future__ import division, print_function, unicode_literals
 class ReverseProxied(object):
    """Wrap the application in this middleware and configure the
@@ -77,6 +75,7 @@ class ReverseProxied(object):
        servr = environ.get('HTTP_X_FORWARDED_HOST', '')
        if servr:
            environ['HTTP_HOST'] = servr
            self.proxied = True
        return self.app(environ, start_response)
    @property
@@ -0,0 +1,117 @@
 # -*- coding: utf-8 -*-
 #  This file is part of the Calibre-Web (https://github.com/janeczku/calibre-web)
 #    Copyright (C) 2021 OzzieIsaacs
 #
 #  This program is free software: you can redistribute it and/or modify
 #  it under the terms of the GNU General Public License as published by
 #  the Free Software Foundation, either version 3 of the License, or
 #  (at your option) any later version.
 #
 #  This program is distributed in the hope that it will be useful,
 #  but WITHOUT ANY WARRANTY; without even the implied warranty of
 #  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 #  GNU General Public License for more details.
 #
 #  You should have received a copy of the GNU General Public License
 #  along with this program. If not, see <http://www.gnu.org/licenses/>.
 import os
 import json
 import importlib
 import sys
 import inspect
 import datetime
 import concurrent.futures
 from flask import Blueprint, request, Response, url_for
 from flask_login import current_user
 from flask_login import login_required
 from sqlalchemy.orm.attributes import flag_modified
 from sqlalchemy.exc import OperationalError, InvalidRequestError
 from . import constants, logger, ub
 from cps.services.Metadata import Metadata
 meta = Blueprint('metadata', __name__)
 log = logger.create()
 new_list = list()
 meta_dir = os.path.join(constants.BASE_DIR, "cps", "metadata_provider")
 modules = os.listdir(os.path.join(constants.BASE_DIR, "cps", "metadata_provider"))
 for f in modules:
    if os.path.isfile(os.path.join(meta_dir, f)) and not f.endswith('__init__.py'):
        a = os.path.basename(f)[:-3]
        try:
            importlib.import_module("cps.metadata_provider." + a)
            new_list.append(a)
        except ImportError:
            log.error("Import error for metadata source: {}".format(a))
            pass
 def list_classes(provider_list):
    classes = list()
    for element in provider_list:
        for name, obj in inspect.getmembers(sys.modules["cps.metadata_provider." + element]):
            if inspect.isclass(obj) and name != "Metadata" and issubclass(obj, Metadata):
                classes.append(obj())
    return classes
 cl = list_classes(new_list)
@meta.route("/metadata/provider")
@login_required
 def metadata_provider():
    active = current_user.view_settings.get('metadata', {})
    provider = list()
    for c in cl:
        ac = active.get(c.__id__, True)
        provider.append({"name": c.__name__, "active": ac, "initial": ac, "id": c.__id__})
    return Response(json.dumps(provider), mimetype='application/json')
@meta.route("/metadata/provider", methods=['POST'])
@meta.route("/metadata/provider/<prov_name>", methods=['POST'])
@login_required
 def metadata_change_active_provider(prov_name):
    new_state = request.get_json()
    active = current_user.view_settings.get('metadata', {})
    active[new_state['id']] = new_state['value']
    current_user.view_settings['metadata'] = active
    try:
        try:
            flag_modified(current_user, "view_settings")
        except AttributeError:
            pass
        ub.session.commit()
    except (InvalidRequestError, OperationalError):
        log.error("Invalid request received: {}".format(request))
        return "Invalid request", 400
    if "initial" in new_state and prov_name:
        for c in cl:
            if c.__id__ == prov_name:
                data = c.search(new_state.get('query', ""))
                break
        return Response(json.dumps(data), mimetype='application/json')
    return ""
@meta.route("/metadata/search", methods=['POST'])
@login_required
 def metadata_search():
    query = request.form.to_dict().get('query')
    data = list()
    active = current_user.view_settings.get('metadata', {})
    if query:
        generic_cover = ""
        with concurrent.futures.ThreadPoolExecutor(max_workers=5) as executor:
            meta = {executor.submit(c.search, query, generic_cover): c for c in cl if active.get(c.__id__, True)}
            for future in concurrent.futures.as_completed(meta):
                data.extend(future.result())
    return Response(json.dumps(data), mimetype='application/json')
@@ -16,17 +16,19 @@
 #  You should have received a copy of the GNU General Public License
 #  along with this program. If not, see <http://www.gnu.org/licenses/>.
 from __future__ import division, print_function, unicode_literals
 import sys
 import os
 import errno
 import signal
 import socket
 import subprocess  # nosec
 try:
    from gevent.pywsgi import WSGIServer
    from gevent.pool import Pool
    from gevent import __version__ as _version
    from greenlet import GreenletExit
    import ssl
    VERSION = 'Gevent ' + _version
    _GEVENT = True
 except ImportError:
@@ -72,7 +74,11 @@ class WebServer(object):
        if config.config_access_log:
            log_name = "gevent.access" if _GEVENT else "tornado.access"
            formatter = logger.ACCESS_FORMATTER_GEVENT if _GEVENT else logger.ACCESS_FORMATTER_TORNADO
-            self.access_logger = logger.create_access_log(config.config_access_logfile, log_name, formatter)
+            self.access_logger, logfile = logger.create_access_log(config.config_access_logfile, log_name, formatter)
            if logfile != config.config_access_logfile:
                log.warning("Accesslog path %s not valid, falling back to default", config.config_access_logfile)
                config.config_access_logfile = logfile
                config.save()
        else:
            if not _GEVENT:
                logger.get('tornado.access').disabled = True
@@ -130,6 +136,64 @@ class WebServer(object):
        return sock, _readable_listen_address(*address)
    @staticmethod
    def _get_args_for_reloading():
        """Determine how the script was executed, and return the args needed
        to execute it again in a new process.
        Code from https://github.com/pyload/pyload. Author GammaC0de, voulter
        """
        rv = [sys.executable]
        py_script = sys.argv[0]
        args = sys.argv[1:]
        # Need to look at main module to determine how it was executed.
        __main__ = sys.modules["__main__"]
        # The value of __package__ indicates how Python was called. It may
        # not exist if a setuptools script is installed as an egg. It may be
        # set incorrectly for entry points created with pip on Windows.
        if getattr(__main__, "__package__", None) is None or (
            os.name == "nt"
            and __main__.__package__ == ""
            and not os.path.exists(py_script)
            and os.path.exists("{}.exe".format(py_script))
        ):
            # Executed a file, like "python app.py".
            py_script = os.path.abspath(py_script)
            if os.name == "nt":
                # Windows entry points have ".exe" extension and should be
                # called directly.
                if not os.path.exists(py_script) and os.path.exists("{}.exe".format(py_script)):
                    py_script += ".exe"
                if (
                        os.path.splitext(sys.executable)[1] == ".exe"
                        and os.path.splitext(py_script)[1] == ".exe"
                ):
                    rv.pop(0)
            rv.append(py_script)
        else:
            # Executed a module, like "python -m module".
            if sys.argv[0] == "-m":
                args = sys.argv
            else:
                if os.path.isfile(py_script):
                    # Rewritten by Python from "-m script" to "/path/to/script.py".
                    py_module = __main__.__package__
                    name = os.path.splitext(os.path.basename(py_script))[0]
                    if name != "__main__":
                        py_module += ".{}".format(name)
                else:
                    # Incorrectly rewritten by pydevd debugger from "-m script" to "script".
                    py_module = py_script
                rv.extend(("-m", py_module.lstrip(".")))
        rv.extend(args)
        return rv
    def _start_gevent(self):
        ssl_args = self.ssl_args or {}
@@ -139,6 +203,16 @@ class WebServer(object):
                output = _readable_listen_address(self.listen_address, self.listen_port)
            log.info('Starting Gevent server on %s', output)
            self.wsgiserver = WSGIServer(sock, self.app, log=self.access_logger, spawn=Pool(), **ssl_args)
            if ssl_args:
                wrap_socket = self.wsgiserver.wrap_socket
                def my_wrap_socket(*args, **kwargs):
                    try:
                        return wrap_socket(*args, **kwargs)
                    except (ssl.SSLError, OSError) as ex:
                        log.warning('Gevent SSL Error: %s', ex)
                        raise GreenletExit
                self.wsgiserver.wrap_socket = my_wrap_socket
            self.wsgiserver.serve_forever()
        finally:
            if self.unix_socket_file:
@@ -176,21 +250,19 @@ class WebServer(object):
        finally:
            self.wsgiserver = None
        # prevent irritating log of pending tasks message from asyncio
        logger.get('asyncio').setLevel(logger.logging.CRITICAL)
        if not self.restart:
            log.info("Performing shutdown of Calibre-Web")
            # prevent irritiating log of pending tasks message from asyncio
            logger.get('asyncio').setLevel(logger.logging.CRITICAL)
            return True
        log.info("Performing restart of Calibre-Web")
-        arguments = list(sys.argv)
+        args = self._get_args_for_reloading()
-        arguments.insert(0, sys.executable)
+        subprocess.call(args, close_fds=True)  # nosec
        if os.name == 'nt':
            arguments = ["\"%s\"" % a for a in arguments]
        os.execv(sys.executable, arguments)
        return True
-    def _killServer(self, ignored_signum, ignored_frame):
+    def _killServer(self, __, ___):
        self.stop()
    def stop(self, restart=False):
@@ -0,0 +1,27 @@
 # -*- coding: utf-8 -*-
 #  This file is part of the Calibre-Web (https://github.com/janeczku/calibre-web)
 #    Copyright (C) 2021 OzzieIsaacs
 #
 #  This program is free software: you can redistribute it and/or modify
 #  it under the terms of the GNU General Public License as published by
 #  the Free Software Foundation, either version 3 of the License, or
 #  (at your option) any later version.
 #
 #  This program is distributed in the hope that it will be useful,
 #  but WITHOUT ANY WARRANTY; without even the implied warranty of
 #  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 #  GNU General Public License for more details.
 #
 #  You should have received a copy of the GNU General Public License
 #  along with this program. If not, see <http://www.gnu.org/licenses/>.
 class Metadata():
    __name__ = "Generic"
    def __init__(self):
        self.active = True
    def set_status(self, state):
        self.active = state
@@ -21,20 +21,18 @@ import sys
 from base64 import b64decode, b64encode
 from jsonschema import validate, exceptions, __version__
 from datetime import datetime
-try:
+
-    from urllib import unquote
+from urllib.parse import unquote
 except ImportError:
    from urllib.parse import unquote
 from flask import json
-from .. import logger as log
+from .. import logger
 log = logger.create()
 def b64encode_json(json_data):
-    if sys.version_info < (3, 0):
+    return b64encode(json.dumps(json_data).encode())
        return b64encode(json.dumps(json_data))
    else:
        return b64encode(json.dumps(json_data).encode())
 # Python3 has a timestamp() method we could be calling, however it's not avaiable in python2.
@@ -45,7 +43,8 @@ def to_epoch_timestamp(datetime_object):
 def get_datetime_from_json(json_object, field_name):
    try:
        return datetime.utcfromtimestamp(json_object[field_name])
-    except KeyError:
+    except (KeyError, OSError, OverflowError):
        # OSError is thrown on Windows if timestamp is <1970 or >2038
        return datetime.min
@@ -60,7 +59,7 @@ class SyncToken:
        books_last_modified: Datetime representing the last modified book that the device knows about.
    """
-    SYNC_TOKEN_HEADER = "x-kobo-synctoken"
+    SYNC_TOKEN_HEADER = "x-kobo-synctoken"  # nosec
    VERSION = "1-1-0"
    LAST_MODIFIED_ADDED_VERSION = "1-1-0"
    MIN_VERSION = "1-0-0"
@@ -80,7 +79,8 @@ class SyncToken:
            "books_last_created": {"type": "string"},
            "archive_last_modified": {"type": "string"},
            "reading_state_last_modified": {"type": "string"},
-            "tags_last_modified": {"type": "string"},
+            "tags_last_modified": {"type": "string"}
            # "books_last_id": {"type": "integer", "optional": True}
        },
    }
@@ -91,19 +91,21 @@ class SyncToken:
        books_last_modified=datetime.min,
        archive_last_modified=datetime.min,
        reading_state_last_modified=datetime.min,
-        tags_last_modified=datetime.min,
+        tags_last_modified=datetime.min
-    ):
+        # books_last_id=-1
    ):  # nosec
        self.raw_kobo_store_token = raw_kobo_store_token
        self.books_last_created = books_last_created
        self.books_last_modified = books_last_modified
        self.archive_last_modified = archive_last_modified
        self.reading_state_last_modified = reading_state_last_modified
        self.tags_last_modified = tags_last_modified
        # self.books_last_id = books_last_id
    @staticmethod
    def from_headers(headers):
        sync_token_header = headers.get(SyncToken.SYNC_TOKEN_HEADER, "")
-        if sync_token_header == "":
+        if sync_token_header == "":  # nosec
            return SyncToken()
        # On the first sync from a Kobo device, we may receive the SyncToken
@@ -133,9 +135,12 @@ class SyncToken:
            archive_last_modified = get_datetime_from_json(data_json, "archive_last_modified")
            reading_state_last_modified = get_datetime_from_json(data_json, "reading_state_last_modified")
            tags_last_modified = get_datetime_from_json(data_json, "tags_last_modified")
            # books_last_id = data_json["books_last_id"]
        except TypeError:
            log.error("SyncToken timestamps don't parse to a datetime.")
            return SyncToken(raw_kobo_store_token=raw_kobo_store_token)
        #except KeyError:
        #    books_last_id = -1
        return SyncToken(
            raw_kobo_store_token=raw_kobo_store_token,
@@ -143,7 +148,8 @@ class SyncToken:
            books_last_modified=books_last_modified,
            archive_last_modified=archive_last_modified,
            reading_state_last_modified=reading_state_last_modified,
-            tags_last_modified=tags_last_modified
+            tags_last_modified=tags_last_modified,
            #books_last_id=books_last_id
        )
    def set_kobo_store_header(self, store_headers):
@@ -166,7 +172,16 @@ class SyncToken:
                "books_last_created": to_epoch_timestamp(self.books_last_created),
                "archive_last_modified": to_epoch_timestamp(self.archive_last_modified),
                "reading_state_last_modified": to_epoch_timestamp(self.reading_state_last_modified),
-                "tags_last_modified": to_epoch_timestamp(self.tags_last_modified)
+                "tags_last_modified": to_epoch_timestamp(self.tags_last_modified),
                #"books_last_id":self.books_last_id
            },
        }
        return b64encode_json(token)
    def __str__(self):
        return "{},{},{},{},{},{}".format(self.books_last_created,
                                       self.books_last_modified,
                                       self.archive_last_modified,
                                       self.reading_state_last_modified,
                                       self.tags_last_modified, self.raw_kobo_store_token)
                                       #self.books_last_id)
@@ -16,8 +16,6 @@
 #  You should have received a copy of the GNU General Public License
 #  along with this program. If not, see <http://www.gnu.org/licenses/>.
 from __future__ import division, print_function, unicode_literals
 from .. import logger
@@ -45,3 +43,9 @@ except ImportError as err:
    log.debug("Cannot import SyncToken, syncing books with Kobo Devices will not work: %s", err)
    kobo = None
    SyncToken = None
 try:
    from . import gmail
 except ImportError as err:
    log.debug("Cannot import gmail, sending books via Gmail Oauth2 Verification will not work: %s", err)
    gmail = None
@@ -0,0 +1,100 @@
 # -*- coding: utf-8 -*-
 #  This file is part of the Calibre-Web (https://github.com/janeczku/calibre-web)
 #    Copyright (C) 2021 OzzieIsaacs
 #
 #  This program is free software: you can redistribute it and/or modify
 #  it under the terms of the GNU General Public License as published by
 #  the Free Software Foundation, either version 3 of the License, or
 #  (at your option) any later version.
 #
 #  This program is distributed in the hope that it will be useful,
 #  but WITHOUT ANY WARRANTY; without even the implied warranty of
 #  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 #  GNU General Public License for more details.
 #
 #  You should have received a copy of the GNU General Public License
 #  along with this program. If not, see <http://www.gnu.org/licenses/>.
 import os.path
 from google_auth_oauthlib.flow import InstalledAppFlow
 from google.auth.transport.requests import Request
 from googleapiclient.discovery import build
 from google.oauth2.credentials import Credentials
 from datetime import datetime
 import base64
 from flask_babel import gettext as _
 from ..constants import BASE_DIR
 from .. import logger
 log = logger.create()
 SCOPES = ['openid', 'https://www.googleapis.com/auth/gmail.send', 'https://www.googleapis.com/auth/userinfo.email']
 def setup_gmail(token):
    # If there are no (valid) credentials available, let the user log in.
    creds = None
    if "token" in token:
        creds = Credentials(
            token=token['token'],
            refresh_token=token['refresh_token'],
            token_uri=token['token_uri'],
            client_id=token['client_id'],
            client_secret=token['client_secret'],
            scopes=token['scopes'],
        )
        creds.expiry = datetime.fromisoformat(token['expiry'])
    if not creds or not creds.valid:
        # don't forget to dump one more time after the refresh
        # also, some file-locking routines wouldn't be needless
        if creds and creds.expired and creds.refresh_token:
            creds.refresh(Request())
        else:
            cred_file = os.path.join(BASE_DIR, 'gmail.json')
            if not os.path.exists(cred_file):
                raise Exception(_("Found no valid gmail.json file with OAuth information"))
            flow = InstalledAppFlow.from_client_secrets_file(
                os.path.join(BASE_DIR, 'gmail.json'), SCOPES)
            creds = flow.run_local_server(port=0)
            user_info = get_user_info(creds)
        return {
            'token': creds.token,
            'refresh_token': creds.refresh_token,
            'token_uri': creds.token_uri,
            'client_id': creds.client_id,
            'client_secret': creds.client_secret,
            'scopes': creds.scopes,
            'expiry': creds.expiry.isoformat(),
            'email': user_info
        }
    return {}
 def get_user_info(credentials):
    user_info_service = build(serviceName='oauth2', version='v2',credentials=credentials)
    user_info = user_info_service.userinfo().get().execute()
    return user_info.get('email', "")
 def send_messsage(token, msg):
    log.debug("Start sending e-mail via Gmail")
    creds = Credentials(
        token=token['token'],
        refresh_token=token['refresh_token'],
        token_uri=token['token_uri'],
        client_id=token['client_id'],
        client_secret=token['client_secret'],
        scopes=token['scopes'],
    )
    creds.expiry = datetime.fromisoformat(token['expiry'])
    if creds and creds.expired and creds.refresh_token:
        creds.refresh(Request())
    service = build('gmail', 'v1', credentials=creds)
    message_as_bytes = msg.as_bytes()  # the message should converted from string to bytes.
    message_as_base64 = base64.urlsafe_b64encode(message_as_bytes)  # encode in base64 (printable letters coding)
    raw = message_as_base64.decode()  # convert to something  JSON serializable
    body = {'raw': raw}
    (service.users().messages().send(userId='me', body=body).execute())
    log.debug("E-mail send successfully via Gmail")
@@ -16,11 +16,13 @@
 #  You should have received a copy of the GNU General Public License
 #  along with this program. If not, see <http://www.gnu.org/licenses/>.
 from __future__ import division, print_function, unicode_literals
 import time
 from functools import reduce
-from goodreads.client import GoodreadsClient
+try:
    from goodreads.client import GoodreadsClient
 except ImportError:
    from betterreads.client import GoodreadsClient
 try: import Levenshtein
 except ImportError: Levenshtein = False
@@ -69,7 +71,7 @@ def get_author_info(author_name):
        author_info = _client.find_author(author_name=author_name)
    except Exception as ex:
        # Skip goodreads, if site is down/inaccessible
-        log.warning('Goodreads website is down/inaccessible? %s', ex)
+        log.warning('Goodreads website is down/inaccessible? %s', ex.__str__())
        return
    if author_info:
@@ -95,8 +97,12 @@ def get_other_books(author_info, library_books=None):
    for book in author_info.books:
        if book.isbn in identifiers:
            continue
-        if book.gid["#text"] in identifiers:
+        if isinstance(book.gid, int):
-            continue
+            if book.gid in identifiers:
                continue
        else:
            if book.gid["#text"] in identifiers:
                continue
        if Levenshtein and library_titles:
            goodreads_title = book._book_dict['title_without_series']
@@ -16,11 +16,10 @@
 #  You should have received a copy of the GNU General Public License
 #  along with this program. If not, see <http://www.gnu.org/licenses/>.
 from __future__ import division, print_function, unicode_literals
 import base64
 from flask_simpleldap import LDAP, LDAPException
-
+from flask_simpleldap import ldap as pyLDAP
 from .. import constants, logger
 try:
@@ -38,6 +37,7 @@ def init_app(app, config):
    app.config['LDAP_HOST'] = config.config_ldap_provider_url
    app.config['LDAP_PORT'] = config.config_ldap_port
    app.config['LDAP_CUSTOM_OPTIONS'] = {pyLDAP.OPT_REFERRALS: 0}
    if config.config_ldap_encryption == 2:
        app.config['LDAP_SCHEMA'] = 'ldaps'
    else:
@@ -54,8 +54,14 @@ def init_app(app, config):
        app.config['LDAP_USERNAME'] = ""
        app.config['LDAP_PASSWORD'] = base64.b64decode("")
    if bool(config.config_ldap_cert_path):
-        app.config['LDAP_REQUIRE_CERT'] = True
+        app.config['LDAP_CUSTOM_OPTIONS'].update({
-        app.config['LDAP_CERT_PATH'] = config.config_ldap_cert_path
+            pyLDAP.OPT_X_TLS_REQUIRE_CERT: pyLDAP.OPT_X_TLS_DEMAND,
            pyLDAP.OPT_X_TLS_CACERTFILE: config.config_ldap_cacert_path,
            pyLDAP.OPT_X_TLS_CERTFILE: config.config_ldap_cert_path,
            pyLDAP.OPT_X_TLS_KEYFILE: config.config_ldap_key_path,
            pyLDAP.OPT_X_TLS_NEWCTX: 0
            })
    app.config['LDAP_BASE_DN'] = config.config_ldap_dn
    app.config['LDAP_USER_OBJECT_FILTER'] = config.config_ldap_user_object
@@ -64,13 +70,22 @@ def init_app(app, config):
    app.config['LDAP_OPENLDAP'] = bool(config.config_ldap_openldap)
    app.config['LDAP_GROUP_OBJECT_FILTER'] = config.config_ldap_group_object_filter
    app.config['LDAP_GROUP_MEMBERS_FIELD'] = config.config_ldap_group_members_field
    # app.config['LDAP_CUSTOM_OPTIONS'] = {'OPT_NETWORK_TIMEOUT': 10}
-    _ldap.init_app(app)
+    try:
        _ldap.init_app(app)
    except ValueError:
        if bool(config.config_ldap_cert_path):
            app.config['LDAP_CUSTOM_OPTIONS'].pop(pyLDAP.OPT_X_TLS_NEWCTX)
        try:
            _ldap.init_app(app)
        except RuntimeError as e:
            log.error(e)
    except RuntimeError as e:
        log.error(e)
-def get_object_details(user=None, group=None, query_filter=None, dn_only=False):
+def get_object_details(user=None,query_filter=None):
-    return _ldap.get_object_details(user, group, query_filter, dn_only)
+    return _ldap.get_object_details(user, query_filter=query_filter)
 def bind():
@@ -101,7 +116,7 @@ def bind_user(username, password):
        return None, error
    except LDAPException as ex:
        if ex.message == 'Invalid credentials':
-            error = ("LDAP admin login failed")
+            error = "LDAP admin login failed"
            return None, error
        if ex.message == "Can't contact LDAP server":
            # log.warning('LDAP Server down: %s', ex)
@@ -0,0 +1,239 @@
 # -*- coding: utf-8 -*-
 #  This file is part of the Calibre-Web (https://github.com/janeczku/calibre-web)
 #    Copyright (C) 2020 pwr
 #
 #  This program is free software: you can redistribute it and/or modify
 #  it under the terms of the GNU General Public License as published by
 #  the Free Software Foundation, either version 3 of the License, or
 #  (at your option) any later version.
 #
 #  This program is distributed in the hope that it will be useful,
 #  but WITHOUT ANY WARRANTY; without even the implied warranty of
 #  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 #  GNU General Public License for more details.
 #
 #  You should have received a copy of the GNU General Public License
 #  along with this program. If not, see <http://www.gnu.org/licenses/>.
 import threading
 import abc
 import uuid
 import time
 try:
    import queue
 except ImportError:
    import Queue as queue
 from datetime import datetime
 from collections import namedtuple
 from cps import logger
 log = logger.create()
 # task 'status' consts
 STAT_WAITING = 0
 STAT_FAIL = 1
 STAT_STARTED = 2
 STAT_FINISH_SUCCESS = 3
 # Only retain this many tasks in dequeued list
 TASK_CLEANUP_TRIGGER = 20
 QueuedTask = namedtuple('QueuedTask', 'num, user, added, task')
 def _get_main_thread():
    for t in threading.enumerate():
        if t.__class__.__name__ == '_MainThread':
            return t
    raise Exception("main thread not found?!")
 class ImprovedQueue(queue.Queue):
    def to_list(self):
        """
        Returns a copy of all items in the queue without removing them.
        """
        with self.mutex:
            return list(self.queue)
 # Class for all worker tasks in the background
 class WorkerThread(threading.Thread):
    _instance = None
    @classmethod
    def getInstance(cls):
        if cls._instance is None:
            cls._instance = WorkerThread()
        return cls._instance
    def __init__(self):
        threading.Thread.__init__(self)
        self.dequeued = list()
        self.doLock = threading.Lock()
        self.queue = ImprovedQueue()
        self.num = 0
        self.start()
    @classmethod
    def add(cls, user, task):
        ins = cls.getInstance()
        ins.num += 1
        log.debug("Add Task for user: {} - {}".format(user, task))
        ins.queue.put(QueuedTask(
            num=ins.num,
            user=user,
            added=datetime.now(),
            task=task,
        ))
    @property
    def tasks(self):
        with self.doLock:
            tasks = self.queue.to_list() + self.dequeued
            return sorted(tasks, key=lambda x: x.num)
    def cleanup_tasks(self):
        with self.doLock:
            dead = []
            alive = []
            for x in self.dequeued:
                (dead if x.task.dead else alive).append(x)
            # if the ones that we need to keep are within the trigger, do nothing else
            delta = len(self.dequeued) - len(dead)
            if delta > TASK_CLEANUP_TRIGGER:
                ret = alive
            else:
                # otherwise, lop off the oldest dead tasks until we hit the target trigger
                ret = sorted(dead, key=lambda x: x.task.end_time)[-TASK_CLEANUP_TRIGGER:] + alive
            self.dequeued = sorted(ret, key=lambda x: x.num)
    # Main thread loop starting the different tasks
    def run(self):
        main_thread = _get_main_thread()
        while main_thread.is_alive():
            try:
                # this blocks until something is available. This can cause issues when the main thread dies - this
                # thread will remain alive. We implement a timeout to unblock every second which allows us to check if
                # the main thread is still alive.
                # We don't use a daemon here because we don't want the tasks to just be abruptly halted, leading to
                # possible file / database corruption
                item = self.queue.get(timeout=1)
            except queue.Empty:
                time.sleep(1)
                continue
            with self.doLock:
                # add to list so that in-progress tasks show up
                self.dequeued.append(item)
            # once we hit our trigger, start cleaning up dead tasks
            if len(self.dequeued) > TASK_CLEANUP_TRIGGER:
                self.cleanup_tasks()
            # sometimes tasks (like Upload) don't actually have work to do and are created as already finished
            if item.task.stat is STAT_WAITING:
                # CalibreTask.start() should wrap all exceptions in it's own error handling
                item.task.start(self)
            self.queue.task_done()
 class CalibreTask:
    __metaclass__ = abc.ABCMeta
    def __init__(self, message):
        self._progress = 0
        self.stat = STAT_WAITING
        self.error = None
        self.start_time = None
        self.end_time = None
        self.message = message
        self.id = uuid.uuid4()
    @abc.abstractmethod
    def run(self, worker_thread):
        """Provides the caller some human-readable name for this class"""
        raise NotImplementedError
    @abc.abstractmethod
    def name(self):
        """Provides the caller some human-readable name for this class"""
        raise NotImplementedError
    def start(self, *args):
        self.start_time = datetime.now()
        self.stat = STAT_STARTED
        # catch any unhandled exceptions in a task and automatically fail it
        try:
            self.run(*args)
        except Exception as ex:
            self._handleError(str(ex))
            log.debug_or_exception(ex)
        self.end_time = datetime.now()
    @property
    def stat(self):
        return self._stat
    @stat.setter
    def stat(self, x):
        self._stat = x
    @property
    def progress(self):
        return self._progress
    @progress.setter
    def progress(self, x):
        if not 0 <= x <= 1:
            raise ValueError("Task progress should within [0, 1] range")
        self._progress = x
    @property
    def error(self):
        return self._error
    @error.setter
    def error(self, x):
        self._error = x
    @property
    def runtime(self):
        return (self.end_time or datetime.now()) - self.start_time
    @property
    def dead(self):
        """Determines whether or not this task can be garbage collected
        We have a separate dictating this because there may be certain tasks that want to override this
        """
        # By default, we're good to clean a task if it's "Done"
        return self.stat in (STAT_FINISH_SUCCESS, STAT_FAIL)
    '''@progress.setter
    def progress(self, x):        
        if x > 1: 
            x = 1
        if x < 0: 
            x = 0
        self._progress = x'''
    def _handleError(self, error_message):
        self.stat = STAT_FAIL
        self.progress = 1
        self.error = error_message
    def _handleSuccess(self):
        self.stat = STAT_FINISH_SUCCESS
        self.progress = 1
@@ -20,18 +20,18 @@
 #  You should have received a copy of the GNU General Public License
 #  along with this program. If not, see <http://www.gnu.org/licenses/>.
-from __future__ import division, print_function, unicode_literals
+import sys
 from datetime import datetime
-from flask import Blueprint, request, flash, redirect, url_for
+from flask import Blueprint, flash, redirect, request, url_for
 from flask_babel import gettext as _
-from flask_login import login_required, current_user
+from flask_login import current_user, login_required
-from sqlalchemy.sql.expression import func
+from sqlalchemy.exc import InvalidRequestError, OperationalError
-
+from sqlalchemy.sql.expression import func, true
 from . import logger, ub, searched_ids, db
 from .web import render_title_template
 from .helper import common_filters
 from . import calibre_db, config, db, logger, ub
 from .render_template import render_title_template
 from .usermanagement import login_required_if_no_ano
 shelf = Blueprint('shelf', __name__)
 log = logger.create()
@@ -56,7 +56,7 @@ def check_shelf_view_permissions(cur_shelf):
    return True
-@shelf.route("/shelf/add/<int:shelf_id>/<int:book_id>")
+@shelf.route("/shelf/add/<int:shelf_id>/<int:book_id>", methods=["POST"])
@login_required
 def add_to_shelf(shelf_id, book_id):
    xhr = request.headers.get('X-Requested-With') == 'XMLHttpRequest'
@@ -70,10 +70,9 @@ def add_to_shelf(shelf_id, book_id):
    if not check_shelf_edit_permissions(shelf):
        if not xhr:
-            flash(_(u"Sorry you are not allowed to add a book to the the shelf: %(shelfname)s", shelfname=shelf.name),
+            flash(_(u"Sorry you are not allowed to add a book to that shelf"), category="error")
                  category="error")
            return redirect(url_for('web.index'))
-        return "Sorry you are not allowed to add a book to the the shelf: %s" % shelf.name, 403
+        return "Sorry you are not allowed to add a book to the that shelf", 403
    book_in_shelf = ub.session.query(ub.BookShelf).filter(ub.BookShelf.shelf == shelf_id,
                                                          ub.BookShelf.book_id == book_id).first()
@@ -92,9 +91,19 @@ def add_to_shelf(shelf_id, book_id):
    shelf.books.append(ub.BookShelf(shelf=shelf.id, book_id=book_id, order=maxOrder + 1))
    shelf.last_modified = datetime.utcnow()
-    ub.session.merge(shelf)
+    try:
-    ub.session.commit()
+        ub.session.merge(shelf)
        ub.session.commit()
    except (OperationalError, InvalidRequestError):
        ub.session.rollback()
        log.error("Settings DB is not Writeable")
        flash(_(u"Settings DB is not Writeable"), category="error")
        if "HTTP_REFERER" in request.environ:
            return redirect(request.environ["HTTP_REFERER"])
        else:
            return redirect(url_for('web.index'))
    if not xhr:
        log.debug("Book has been added to shelf: {}".format(shelf.name))
        flash(_(u"Book has been added to shelf: %(sname)s", sname=shelf.name), category="success")
        if "HTTP_REFERER" in request.environ:
            return redirect(request.environ["HTTP_REFERER"])
@@ -103,7 +112,7 @@ def add_to_shelf(shelf_id, book_id):
    return "", 204
-@shelf.route("/shelf/massadd/<int:shelf_id>")
+@shelf.route("/shelf/massadd/<int:shelf_id>", methods=["POST"])
@login_required
 def search_to_shelf(shelf_id):
    shelf = ub.session.query(ub.Shelf).filter(ub.Shelf.id == shelf_id).first()
@@ -113,52 +122,55 @@ def search_to_shelf(shelf_id):
        return redirect(url_for('web.index'))
    if not check_shelf_edit_permissions(shelf):
-        flash(_(u"You are not allowed to add a book to the the shelf: %(name)s", name=shelf.name), category="error")
+        log.warning("You are not allowed to add a book to the shelf".format(shelf.name))
        flash(_(u"You are not allowed to add a book to the shelf"), category="error")
        return redirect(url_for('web.index'))
-    if current_user.id in searched_ids and searched_ids[current_user.id]:
+    if current_user.id in ub.searched_ids and ub.searched_ids[current_user.id]:
        books_for_shelf = list()
        books_in_shelf = ub.session.query(ub.BookShelf).filter(ub.BookShelf.shelf == shelf_id).all()
        if books_in_shelf:
            book_ids = list()
            for book_id in books_in_shelf:
                book_ids.append(book_id.book_id)
-            for searchid in searched_ids[current_user.id]:
+            for searchid in ub.searched_ids[current_user.id]:
                if searchid not in book_ids:
                    books_for_shelf.append(searchid)
        else:
-            books_for_shelf = searched_ids[current_user.id]
+            books_for_shelf = ub.searched_ids[current_user.id]
        if not books_for_shelf:
-            log.error("Books are already part of %s", shelf)
+            log.error("Books are already part of {}".format(shelf.name))
            flash(_(u"Books are already part of the shelf: %(name)s", name=shelf.name), category="error")
            return redirect(url_for('web.index'))
-        maxOrder = ub.session.query(func.max(ub.BookShelf.order)).filter(ub.BookShelf.shelf == shelf_id).first()
+        maxOrder = ub.session.query(func.max(ub.BookShelf.order)).filter(ub.BookShelf.shelf == shelf_id).first()[0] or 0
        if maxOrder[0] is None:
            maxOrder = 0
        else:
            maxOrder = maxOrder[0]
        for book in books_for_shelf:
-            maxOrder = maxOrder + 1
+            maxOrder += 1
            shelf.books.append(ub.BookShelf(shelf=shelf.id, book_id=book, order=maxOrder))
        shelf.last_modified = datetime.utcnow()
-        ub.session.merge(shelf)
+        try:
-        ub.session.commit()
+            ub.session.merge(shelf)
-        flash(_(u"Books have been added to shelf: %(sname)s", sname=shelf.name), category="success")
+            ub.session.commit()
            flash(_(u"Books have been added to shelf: %(sname)s", sname=shelf.name), category="success")
        except (OperationalError, InvalidRequestError):
            ub.session.rollback()
            log.error("Settings DB is not Writeable")
            flash(_("Settings DB is not Writeable"), category="error")
    else:
        log.error("Could not add books to shelf: {}".format(shelf.name))
        flash(_(u"Could not add books to shelf: %(sname)s", sname=shelf.name), category="error")
    return redirect(url_for('web.index'))
-@shelf.route("/shelf/remove/<int:shelf_id>/<int:book_id>")
+@shelf.route("/shelf/remove/<int:shelf_id>/<int:book_id>", methods=["POST"])
@login_required
 def remove_from_shelf(shelf_id, book_id):
    xhr = request.headers.get('X-Requested-With') == 'XMLHttpRequest'
    shelf = ub.session.query(ub.Shelf).filter(ub.Shelf.id == shelf_id).first()
    if shelf is None:
-        log.error("Invalid shelf specified: %s", shelf_id)
+        log.error("Invalid shelf specified: {}".format(shelf_id))
        if not xhr:
            return redirect(url_for('web.index'))
        return "Invalid shelf specified", 400
@@ -181,10 +193,18 @@ def remove_from_shelf(shelf_id, book_id):
                return redirect(url_for('web.index'))
            return "Book already removed from shelf", 410
-        ub.session.delete(book_shelf)
+        try:
-        shelf.last_modified = datetime.utcnow()
+            ub.session.delete(book_shelf)
-        ub.session.commit()
+            shelf.last_modified = datetime.utcnow()
-
+            ub.session.commit()
        except (OperationalError, InvalidRequestError):
            ub.session.rollback()
            log.error("Settings DB is not Writeable")
            flash(_("Settings DB is not Writeable"), category="error")
            if "HTTP_REFERER" in request.environ:
                return redirect(request.environ["HTTP_REFERER"])
            else:
                return redirect(url_for('web.index'))
        if not xhr:
            flash(_(u"Book has been removed from shelf: %(sname)s", sname=shelf.name), category="success")
            if "HTTP_REFERER" in request.environ:
@@ -194,98 +214,108 @@ def remove_from_shelf(shelf_id, book_id):
        return "", 204
    else:
        if not xhr:
-            flash(_(u"Sorry you are not allowed to remove a book from this shelf: %(sname)s", sname=shelf.name),
+            log.warning("You are not allowed to remove a book from shelf: {}".format(shelf.name))
            flash(_(u"Sorry you are not allowed to remove a book from this shelf"),
                  category="error")
            return redirect(url_for('web.index'))
-        return "Sorry you are not allowed to remove a book from this shelf: %s" % shelf.name, 403
+        return "Sorry you are not allowed to remove a book from this shelf", 403
@shelf.route("/shelf/create", methods=["GET", "POST"])
@login_required
 def create_shelf():
    shelf = ub.Shelf()
-    if request.method == "POST":
+    return create_edit_shelf(shelf, page_title=_(u"Create a Shelf"), page="shelfcreate")
        to_save = request.form.to_dict()
        if "is_public" in to_save:
            shelf.is_public = 1
        shelf.name = to_save["title"]
        shelf.user_id = int(current_user.id)
        is_shelf_name_unique = False
        if shelf.is_public == 1:
            is_shelf_name_unique = ub.session.query(ub.Shelf) \
                .filter((ub.Shelf.name == to_save["title"]) & (ub.Shelf.is_public == 1)) \
                .first() is None
            if not is_shelf_name_unique:
                flash(_(u"A public shelf with the name '%(title)s' already exists.", title=to_save["title"]),
                      category="error")
        else:
            is_shelf_name_unique = ub.session.query(ub.Shelf) \
                .filter((ub.Shelf.name == to_save["title"]) & (ub.Shelf.is_public == 0) &
                        (ub.Shelf.user_id == int(current_user.id)))\
                                       .first() is None
            if not is_shelf_name_unique:
                flash(_(u"A private shelf with the name '%(title)s' already exists.", title=to_save["title"]),
                      category="error")
        if is_shelf_name_unique:
            try:
                ub.session.add(shelf)
                ub.session.commit()
                flash(_(u"Shelf %(title)s created", title=to_save["title"]), category="success")
                return redirect(url_for('shelf.show_shelf', shelf_id=shelf.id))
            except Exception:
                flash(_(u"There was an error"), category="error")
        return render_title_template('shelf_edit.html', shelf=shelf, title=_(u"Create a Shelf"), page="shelfcreate")
    else:
        return render_title_template('shelf_edit.html', shelf=shelf, title=_(u"Create a Shelf"), page="shelfcreate")
@shelf.route("/shelf/edit/<int:shelf_id>", methods=["GET", "POST"])
@login_required
 def edit_shelf(shelf_id):
    shelf = ub.session.query(ub.Shelf).filter(ub.Shelf.id == shelf_id).first()
    if not check_shelf_edit_permissions(shelf):
        flash(_(u"Sorry you are not allowed to edit this shelf"), category="error")
        return redirect(url_for('web.index'))
    return create_edit_shelf(shelf, page_title=_(u"Edit a shelf"), page="shelfedit", shelf_id=shelf_id)
 # if shelf ID is set, we are editing a shelf
 def create_edit_shelf(shelf, page_title, page, shelf_id=False):
    sync_only_selected_shelves = current_user.kobo_only_shelves_sync
    # calibre_db.session.query(ub.Shelf).filter(ub.Shelf.user_id == current_user.id).filter(ub.Shelf.kobo_sync).count()
    if request.method == "POST":
        to_save = request.form.to_dict()
-
+        if not current_user.role_edit_shelfs() and to_save.get("is_public") == "on":
-        is_shelf_name_unique = False
+            flash(_(u"Sorry you are not allowed to create a public shelf"), category="error")
-        if shelf.is_public == 1:
+            return redirect(url_for('web.index'))
-            is_shelf_name_unique = ub.session.query(ub.Shelf) \
+        is_public = 1 if to_save.get("is_public") == "on" else 0
-                .filter((ub.Shelf.name == to_save["title"]) & (ub.Shelf.is_public == 1)) \
+        if config.config_kobo_sync:
-                .filter(ub.Shelf.id != shelf_id) \
+            shelf.kobo_sync = True if to_save.get("kobo_sync") else False
-                .first() is None
+            if shelf.kobo_sync:
-
+                ub.session.query(ub.ShelfArchive).filter(ub.ShelfArchive.user_id == current_user.id).filter(
-            if not is_shelf_name_unique:
+                    ub.ShelfArchive.uuid == shelf.uuid).delete()
-                flash(_(u"A public shelf with the name '%(title)s' already exists.", title=to_save["title"]),
+                ub.session_commit()
-                      category="error")
+        shelf_title = to_save.get("title", "")
-        else:
+        if check_shelf_is_unique(shelf, shelf_title, is_public, shelf_id):
-            is_shelf_name_unique = ub.session.query(ub.Shelf) \
+            shelf.name = shelf_title
-                .filter((ub.Shelf.name == to_save["title"]) & (ub.Shelf.is_public == 0) &
+            shelf.is_public = is_public
-                        (ub.Shelf.user_id == int(current_user.id)))\
+            if not shelf_id:
-                                       .filter(ub.Shelf.id != shelf_id)\
+                shelf.user_id = int(current_user.id)
-                                       .first() is None
+                ub.session.add(shelf)
-
+                shelf_action = "created"
-            if not is_shelf_name_unique:
+                flash_text = _(u"Shelf %(title)s created", title=shelf_title)
                flash(_(u"A private shelf with the name '%(title)s' already exists.", title=to_save["title"]),
                      category="error")
        if is_shelf_name_unique:
            shelf.name = to_save["title"]
            shelf.last_modified = datetime.utcnow()
            if "is_public" in to_save:
                shelf.is_public = 1
            else:
-                shelf.is_public = 0
+                shelf_action = "changed"
                flash_text = _(u"Shelf %(title)s changed", title=shelf_title)
            try:
                ub.session.commit()
-                flash(_(u"Shelf %(title)s changed", title=to_save["title"]), category="success")
+                log.info(u"Shelf {} {}".format(shelf_title, shelf_action))
-            except Exception:
+                flash(flash_text, category="success")
                return redirect(url_for('shelf.show_shelf', shelf_id=shelf.id))
            except (OperationalError, InvalidRequestError) as ex:
                ub.session.rollback()
                log.debug_or_exception(ex)
                log.error("Settings DB is not Writeable")
                flash(_("Settings DB is not Writeable"), category="error")
            except Exception as ex:
                ub.session.rollback()
                log.debug_or_exception(ex)
                flash(_(u"There was an error"), category="error")
-        return render_title_template('shelf_edit.html', shelf=shelf, title=_(u"Edit a shelf"), page="shelfedit")
+    return render_title_template('shelf_edit.html',
                                 shelf=shelf,
                                 title=page_title,
                                 page=page,
                                 kobo_sync_enabled=config.config_kobo_sync,
                                 sync_only_selected_shelves=sync_only_selected_shelves)
 def check_shelf_is_unique(shelf, title, is_public, shelf_id=False):
    if shelf_id:
        ident = ub.Shelf.id != shelf_id
    else:
-        return render_title_template('shelf_edit.html', shelf=shelf, title=_(u"Edit a shelf"), page="shelfedit")
+        ident = true()
    if is_public == 1:
        is_shelf_name_unique = ub.session.query(ub.Shelf) \
                                   .filter((ub.Shelf.name == title) & (ub.Shelf.is_public == 1)) \
                                   .filter(ident) \
                                   .first() is None
        if not is_shelf_name_unique:
            log.error("A public shelf with the name '{}' already exists.".format(title))
            flash(_(u"A public shelf with the name '%(title)s' already exists.", title=title),
                  category="error")
    else:
        is_shelf_name_unique = ub.session.query(ub.Shelf) \
                                   .filter((ub.Shelf.name == title) & (ub.Shelf.is_public == 0) &
                                           (ub.Shelf.user_id == int(current_user.id))) \
                                   .filter(ident) \
                                   .first() is None
        if not is_shelf_name_unique:
            log.error("A private shelf with the name '{}' already exists.".format(title))
            flash(_(u"A private shelf with the name '%(title)s' already exists.", title=title),
                  category="error")
    return is_shelf_name_unique
 def delete_shelf_helper(cur_shelf):
@@ -295,45 +325,35 @@ def delete_shelf_helper(cur_shelf):
    ub.session.delete(cur_shelf)
    ub.session.query(ub.BookShelf).filter(ub.BookShelf.shelf == shelf_id).delete()
    ub.session.add(ub.ShelfArchive(uuid=cur_shelf.uuid, user_id=cur_shelf.user_id))
-    ub.session.commit()
+    ub.session_commit("successfully deleted Shelf {}".format(cur_shelf.name))
    log.info("successfully deleted %s", cur_shelf)
-@shelf.route("/shelf/delete/<int:shelf_id>")
+@shelf.route("/shelf/delete/<int:shelf_id>", methods=["POST"])
@login_required
 def delete_shelf(shelf_id):
    cur_shelf = ub.session.query(ub.Shelf).filter(ub.Shelf.id == shelf_id).first()
-    delete_shelf_helper(cur_shelf)
+    try:
        delete_shelf_helper(cur_shelf)
        flash(_("Shelf successfully deleted"), category="success")
    except InvalidRequestError:
        ub.session.rollback()
        log.error("Settings DB is not Writeable")
        flash(_("Settings DB is not Writeable"), category="error")
    return redirect(url_for('web.index'))
-@shelf.route("/shelf/<int:shelf_id>", defaults={'shelf_type': 1})
+@shelf.route("/simpleshelf/<int:shelf_id>")
-@shelf.route("/shelf/<int:shelf_id>/<int:shelf_type>")
+@login_required_if_no_ano
-def show_shelf(shelf_type, shelf_id):
+def show_simpleshelf(shelf_id):
-    shelf = ub.session.query(ub.Shelf).filter(ub.Shelf.id == shelf_id).first()
+    return render_show_shelf(2, shelf_id, 1, None)
    result = list()
    # user is allowed to access shelf
    if shelf and check_shelf_view_permissions(shelf):
        page = "shelf.html" if shelf_type == 1 else 'shelfdown.html'
-        books_in_shelf = ub.session.query(ub.BookShelf).filter(ub.BookShelf.shelf == shelf_id)\
+@shelf.route("/shelf/<int:shelf_id>", defaults={"sort_param": "order", 'page': 1})
-            .order_by(ub.BookShelf.order.asc()).all()
+@shelf.route("/shelf/<int:shelf_id>/<sort_param>", defaults={'page': 1})
-        for book in books_in_shelf:
+@shelf.route("/shelf/<int:shelf_id>/<sort_param>/<int:page>")
-            cur_book = db.session.query(db.Books).filter(db.Books.id == book.book_id).filter(common_filters()).first()
+@login_required_if_no_ano
-            if cur_book:
+def show_shelf(shelf_id, sort_param, page):
-                result.append(cur_book)
+    return render_show_shelf(1, shelf_id, page, sort_param)
            else:
                cur_book = db.session.query(db.Books).filter(db.Books.id == book.book_id).first()
                if not cur_book:
                    log.info('Not existing book %s in %s deleted', book.book_id, shelf)
                    ub.session.query(ub.BookShelf).filter(ub.BookShelf.book_id == book.book_id).delete()
                    ub.session.commit()
        return render_title_template(page, entries=result, title=_(u"Shelf: '%(name)s'", name=shelf.name),
                                     shelf=shelf, page="shelf")
    else:
        flash(_(u"Error opening shelf. Shelf does not exist or is not accessible"), category="error")
        return redirect(url_for("web.index"))
@shelf.route("/shelf/order/<int:shelf_id>", methods=["GET", "POST"])
@@ -348,27 +368,94 @@ def order_shelf(shelf_id):
            setattr(book, 'order', to_save[str(book.book_id)])
            counter += 1
            # if order diffrent from before -> shelf.last_modified = datetime.utcnow()
-        ub.session.commit()
+        try:
            ub.session.commit()
        except (OperationalError, InvalidRequestError):
            ub.session.rollback()
            log.error("Settings DB is not Writeable")
            flash(_("Settings DB is not Writeable"), category="error")
    shelf = ub.session.query(ub.Shelf).filter(ub.Shelf.id == shelf_id).first()
    result = list()
    if shelf and check_shelf_view_permissions(shelf):
-        books_in_shelf2 = ub.session.query(ub.BookShelf).filter(ub.BookShelf.shelf == shelf_id) \
+        result = calibre_db.session.query(db.Books) \
-            .order_by(ub.BookShelf.order.asc()).all()
+            .join(ub.BookShelf, ub.BookShelf.book_id == db.Books.id, isouter=True) \
-        for book in books_in_shelf2:
+            .add_columns(calibre_db.common_filters().label("visible")) \
-            cur_book = db.session.query(db.Books).filter(db.Books.id == book.book_id).filter(common_filters()).first()
+            .filter(ub.BookShelf.shelf == shelf_id).order_by(ub.BookShelf.order.asc()).all()
            if cur_book:
                result.append({'title': cur_book.title,
                               'id': cur_book.id,
                               'author': cur_book.authors,
                               'series': cur_book.series,
                               'series_index': cur_book.series_index})
            else:
                cur_book = db.session.query(db.Books).filter(db.Books.id == book.book_id).first()
                result.append({'title': _('Hidden Book'),
                               'id': cur_book.id,
                               'author': [],
                               'series': []})
    return render_title_template('shelf_order.html', entries=result,
                                 title=_(u"Change order of Shelf: '%(name)s'", name=shelf.name),
                                 shelf=shelf, page="shelforder")
 def change_shelf_order(shelf_id, order):
    result = calibre_db.session.query(db.Books).outerjoin(db.books_series_link,
                                                          db.Books.id == db.books_series_link.c.book)\
        .outerjoin(db.Series).join(ub.BookShelf, ub.BookShelf.book_id == db.Books.id) \
        .filter(ub.BookShelf.shelf == shelf_id).order_by(*order).all()
    for index, entry in enumerate(result):
        book = ub.session.query(ub.BookShelf).filter(ub.BookShelf.shelf == shelf_id) \
            .filter(ub.BookShelf.book_id == entry.id).first()
        book.order = index
    ub.session_commit("Shelf-id:{} - Order changed".format(shelf_id))
 def render_show_shelf(shelf_type, shelf_id, page_no, sort_param):
    shelf = ub.session.query(ub.Shelf).filter(ub.Shelf.id == shelf_id).first()
    # check user is allowed to access shelf
    if shelf and check_shelf_view_permissions(shelf):
        if shelf_type == 1:
            # order = [ub.BookShelf.order.asc()]
            if sort_param == 'pubnew':
                change_shelf_order(shelf_id, [db.Books.pubdate.desc()])
            if sort_param == 'pubold':
                change_shelf_order(shelf_id, [db.Books.pubdate])
            if sort_param == 'abc':
                change_shelf_order(shelf_id, [db.Books.sort])
            if sort_param == 'zyx':
                change_shelf_order(shelf_id, [db.Books.sort.desc()])
            if sort_param == 'new':
                change_shelf_order(shelf_id, [db.Books.timestamp.desc()])
            if sort_param == 'old':
                change_shelf_order(shelf_id, [db.Books.timestamp])
            if sort_param == 'authaz':
                change_shelf_order(shelf_id, [db.Books.author_sort.asc(), db.Series.name, db.Books.series_index])
            if sort_param == 'authza':
                change_shelf_order(shelf_id, [db.Books.author_sort.desc(),
                                              db.Series.name.desc(),
                                              db.Books.series_index.desc()])
            page = "shelf.html"
            pagesize = 0
        else:
            pagesize = sys.maxsize
            page = 'shelfdown.html'
        result, __, pagination = calibre_db.fill_indexpage(page_no, pagesize,
                                                           db.Books,
                                                           ub.BookShelf.shelf == shelf_id,
                                                           [ub.BookShelf.order.asc()],
                                                           ub.BookShelf, ub.BookShelf.book_id == db.Books.id)
        # delete chelf entries where book is not existent anymore, can happen if book is deleted outside calibre-web
        wrong_entries = calibre_db.session.query(ub.BookShelf) \
            .join(db.Books, ub.BookShelf.book_id == db.Books.id, isouter=True) \
            .filter(db.Books.id == None).all()
        for entry in wrong_entries:
            log.info('Not existing book {} in {} deleted'.format(entry.book_id, shelf))
            try:
                ub.session.query(ub.BookShelf).filter(ub.BookShelf.book_id == entry.book_id).delete()
                ub.session.commit()
            except (OperationalError, InvalidRequestError):
                ub.session.rollback()
                log.error("Settings DB is not Writeable")
                flash(_("Settings DB is not Writeable"), category="error")
        return render_title_template(page,
                                     entries=result,
                                     pagination=pagination,
                                     title=_(u"Shelf: '%(name)s'", name=shelf.name),
                                     shelf=shelf,
                                     page="shelf")
    else:
        flash(_(u"Error opening shelf. Shelf does not exist or is not accessible"), category="error")
        return redirect(url_for("web.index"))
--- a/Show More
+++ b/Show More