Refactor subprocess calls

This commit is contained in:
Ozzieisaacs
2019-02-03 18:32:27 +01:00
parent 7f34073955
commit 36229076f7
5 changed files with 71 additions and 28 deletions
+6 -3
View File
@@ -19,17 +19,19 @@
import os
import subprocess
# import subprocess
import ub
import re
from flask_babel import gettext as _
from subproc_wrapper import process_open
def versionKindle():
versions = _(u'not installed')
if os.path.exists(ub.config.config_converterpath):
try:
p = subprocess.Popen(ub.config.config_converterpath, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
p = process_open(ub.config.config_converterpath)
# p = subprocess.Popen(ub.config.config_converterpath, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
p.wait()
for lines in p.stdout.readlines():
if isinstance(lines, bytes):
@@ -45,7 +47,8 @@ def versionCalibre():
versions = _(u'not installed')
if os.path.exists(ub.config.config_converterpath):
try:
p = subprocess.Popen([ub.config.config_converterpath, '--version'], stdout=subprocess.PIPE, stderr=subprocess.PIPE)
p = process_open([ub.config.config_converterpath, '--version'])
# p = subprocess.Popen([ub.config.config_converterpath, '--version'], stdout=subprocess.PIPE, stderr=subprocess.PIPE)
p.wait()
for lines in p.stdout.readlines():
if isinstance(lines, bytes):