Fix app crashing

.idea/runConfigurations.xml

@@ -3,6 +3,7 @@
   <component name="RunConfigurationProducerService">
     <option name="ignoredProducers">
       <set>
+        <option value="com.android.tools.idea.compose.preview.runconfiguration.ComposePreviewRunConfigurationProducer" />
         <option value="org.jetbrains.plugins.gradle.execution.test.runner.AllInPackageGradleConfigurationProducer" />
         <option value="org.jetbrains.plugins.gradle.execution.test.runner.TestClassGradleConfigurationProducer" />
         <option value="org.jetbrains.plugins.gradle.execution.test.runner.TestMethodGradleConfigurationProducer" />

app/build.gradle

@@ -38,21 +38,21 @@ android {
         minSdkVersion 16
         targetSdkVersion 30
         versionCode 64
-        versionName "5.1.9"
+        versionName "5.1.9-hotfix4"
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
         vectorDrawables.useSupportLibrary = true
     }
     buildTypes {
         debug {
-            minifyEnabled true
-            shrinkResources true
+            defaultConfig.minSdkVersion 21
+
+            minifyEnabled false
+            shrinkResources false
 
             debuggable true
             applicationIdSuffix ".debug"
             versionNameSuffix "-DEBUG"
 
-            proguardFiles getDefaultProguardFile("proguard-android-optimize.txt"), "proguard-rules.pro"
-
             ext.enableCrashlytics = false
             ext.alwaysUpdateBuildId = false
         }
@@ -125,7 +125,7 @@ dependencies {
 
     implementation "ru.noties.markwon:core:3.1.0"
 
-    implementation "xyz.quaver:libpupil:2.1.0"
+    implementation "xyz.quaver:libpupil:2.1.1"
     implementation "xyz.quaver:documentfilex:0.6.1"
     implementation "xyz.quaver:floatingsearchview:1.1.7"
 

app/release/output-metadata.json

@@ -5,13 +5,13 @@
     "kind": "Directory"
   },
   "applicationId": "xyz.quaver.pupil",
-  "variantName": "processReleaseResources",
+  "variantName": "release",
   "elements": [
     {
       "type": "SINGLE",
       "filters": [],
       "versionCode": 64,
-      "versionName": "5.1.8-beta2",
+      "versionName": "5.1.9-hotfix4",
       "outputFile": "app-release.apk"
     }
   ]

app/src/main/java/xyz/quaver/pupil/adapters/ReaderAdapter.kt

@@ -52,7 +52,7 @@ class ReaderAdapter(
     private val activity: ReaderActivity,
     private val galleryID: Int
 ) : RecyclerView.Adapter<ReaderAdapter.ViewHolder>() {
-    var reader: GalleryInfo? = null
+    var galleryInfo: GalleryInfo? = null
 
     var isFullScreen = false
 
@@ -101,7 +101,7 @@ class ReaderAdapter(
                 binding.image.updateLayoutParams<ConstraintLayout.LayoutParams> {
                     height = 0
                     dimensionRatio =
-                        "${reader!!.files[position].width}:${reader!!.files[position].height}"
+                        "${galleryInfo!!.files[position].width}:${galleryInfo!!.files[position].height}"
                 }
             } else {
                 binding.root.layoutParams.height = ViewGroup.LayoutParams.MATCH_PARENT
@@ -158,7 +158,7 @@ class ReaderAdapter(
         holder.bind(position)
     }
 
-    override fun getItemCount() = reader?.files?.size ?: 0
+    override fun getItemCount() = galleryInfo?.files?.size ?: 0
 
     override fun onViewRecycled(holder: ViewHolder) {
         holder.clear()

app/src/main/java/xyz/quaver/pupil/receiver/UpdateBroadcastReceiver.kt

@@ -54,7 +54,7 @@ class UpdateBroadcastReceiver : BroadcastReceiver() {
 
                 val uri = downloadManager.query(query).use { cursor ->
                     if (cursor.moveToFirst()) {
-                        cursor.getString(cursor.getColumnIndex(DownloadManager.COLUMN_LOCAL_URI)).let {
+                        cursor.getString(cursor.getColumnIndex(DownloadManager.COLUMN_LOCAL_URI))?.let {
                             val uri = Uri.parse(it)
 
                             when (uri.scheme) {

app/src/main/java/xyz/quaver/pupil/services/DownloadService.kt

@@ -305,10 +305,10 @@ class DownloadService : Service() {
 
         initNotification(galleryID)
 
-        val reader = cache.getReader()
+        val galleryInfo = cache.getGalleryInfo()
 
         // Gallery doesn't exist
-        if (reader == null) {
+        if (galleryInfo == null) {
             delete(galleryID)
             progress[galleryID] = mutableListOf()
             return@launch
@@ -316,7 +316,7 @@ class DownloadService : Service() {
 
         histories.add(galleryID)
 
-        progress[galleryID] = MutableList(reader.files.size) { 0F }
+        progress[galleryID] = MutableList(galleryInfo.files.size) { 0F }
 
         cache.metadata.imageList?.let {
             it.forEachIndexed { index, image ->
@@ -334,7 +334,7 @@ class DownloadService : Service() {
             return@launch
         }
 
-        notification[galleryID]?.setContentTitle(reader.title?.ellipsize(30))
+        notification[galleryID]?.setContentTitle(galleryInfo.title?.ellipsize(30))
         notify(galleryID)
 
         val queued = mutableSetOf<Int>()
@@ -348,7 +348,7 @@ class DownloadService : Service() {
             }
         }
 
-        reader.requestBuilders.forEachIndexed { index, it ->
+        galleryInfo.requestBuilders.forEachIndexed { index, it ->
             if (progress[galleryID]?.get(index)?.isInfinite() == false) {
                 val request = it.tag(Tag(galleryID, index, startId)).build()
                 client.newCall(request).enqueue(callback)

app/src/main/java/xyz/quaver/pupil/ui/MainActivity.kt

@@ -129,7 +129,7 @@ class MainActivity :
 
         if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.R &&
             !Preferences["download_folder_ignore_warning", false] &&
-            ContextCompat.getExternalFilesDirs(this, null).map { Uri.fromFile(it).toString() }
+            ContextCompat.getExternalFilesDirs(this, null).filterNotNull().map { Uri.fromFile(it).toString() }
                 .contains(Preferences["download_folder", ""])
         ) {
             AlertDialog.Builder(this)

app/src/main/java/xyz/quaver/pupil/ui/ReaderActivity.kt

@@ -183,7 +183,7 @@ class ReaderActivity : BaseActivity() {
 
                 with(binding.numberPicker) {
                     minValue = 1
-                    maxValue = cache.metadata.reader?.files?.size ?: 0
+                    maxValue = cache.metadata.galleryInfo?.files?.size ?: 0
                     value = currentPage
                 }
                 val dialog = AlertDialog.Builder(this).apply {
@@ -298,17 +298,17 @@ class ReaderActivity : BaseActivity() {
                     downloader.progress[galleryID]?.count { it.isInfinite() } ?: 0
 
                 if (title == getString(R.string.reader_loading)) {
-                    val reader = cache.metadata.reader
+                    val galleryInfo = cache.metadata.galleryInfo
 
-                    if (reader != null) {
+                    if (galleryInfo != null) {
                         with(binding.recyclerview.adapter as ReaderAdapter) {
-                            this.reader = reader
+                            this.galleryInfo = galleryInfo
                             notifyDataSetChanged()
                         }
 
-                        title = reader.title
+                        title = galleryInfo.title
                         menu?.findItem(R.id.reader_menu_page_indicator)?.title =
-                            "$currentPage/${reader.files.size}"
+                            "$currentPage/${galleryInfo.files.size}"
 
                         menu?.findItem(R.id.reader_type)?.icon = ContextCompat.getDrawable(this@ReaderActivity, R.drawable.hitomi)
                     }

app/src/main/java/xyz/quaver/pupil/util/downloader/Cache.kt

@@ -37,18 +37,57 @@ import xyz.quaver.hitomi.GalleryInfo
 import xyz.quaver.io.FileX
 import xyz.quaver.io.util.*
 import xyz.quaver.pupil.client
-import xyz.quaver.pupil.util.Preferences
 import java.io.File
 import java.io.IOException
 import java.util.concurrent.ConcurrentHashMap
 
 @Serializable
-data class Metadata(
-    var galleryBlock: GalleryBlock? = null,
-    var reader: GalleryInfo? = null,
+data class OldGalleryBlock(
+    val code: String,
+    val id: Int,
+    val galleryUrl: String,
+    val thumbnails: List<String>,
+    val title: String,
+    val artists: List<String>,
+    val series: List<String>,
+    val type: String,
+    val language: String,
+    val relatedTags: List<String>
+)
+
+@Serializable
+data class OldReader(val code: String, val galleryInfo: GalleryInfo)
+
+@Serializable
+data class OldMetadata(
+    var galleryBlock: OldGalleryBlock? = null,
+    var reader: OldReader? = null,
     var imageList: MutableList<String?>? = null
 ) {
-    fun copy(): Metadata = Metadata(galleryBlock, reader, imageList?.let { MutableList(it.size) { i -> it[i] } })
+    fun copy(): OldMetadata = OldMetadata(galleryBlock, reader, imageList?.let { MutableList(it.size) { i -> it[i] } })
+}
+
+@Serializable
+data class Metadata(
+    var galleryBlock: GalleryBlock? = null,
+    var galleryInfo: GalleryInfo? = null,
+    var imageList: MutableList<String?>? = null
+) {
+    constructor(old: OldMetadata) : this(old.galleryBlock?.let { galleryBlock -> GalleryBlock(
+        galleryBlock.id,
+        galleryBlock.galleryUrl,
+        galleryBlock.thumbnails,
+        galleryBlock.title,
+        galleryBlock.artists,
+        galleryBlock.series,
+        galleryBlock.type,
+        galleryBlock.language,
+        galleryBlock.relatedTags) },
+        old.reader?.galleryInfo,
+        old.imageList
+    )
+
+    fun copy(): Metadata = Metadata(galleryBlock, galleryInfo, imageList?.let { MutableList(it.size) { i -> it[i] } })
 }
 
 class Cache private constructor(context: Context, val galleryID: Int) : ContextWrapper(context) {
@@ -73,8 +112,12 @@ class Cache private constructor(context: Context, val galleryID: Int) : ContextW
     }
 
     var metadata = kotlin.runCatching {
-        findFile(".metadata")?.readText()?.let {
-            Json.decodeFromString<Metadata>(it)
+        findFile(".metadata")?.readText()?.let { metadata ->
+            kotlin.runCatching {
+                Json.decodeFromString<Metadata>(metadata)
+            }.getOrElse {
+                Metadata(Json.decodeFromString<OldMetadata>(metadata))
+            }
         }
     }.getOrNull() ?: Metadata()
 
@@ -139,14 +182,14 @@ class Cache private constructor(context: Context, val galleryID: Int) : ContextW
                 }.getOrNull()?.uri }
             } } ?: Uri.EMPTY
 
-    suspend fun getReader(): GalleryInfo? {
+    suspend fun getGalleryInfo(): GalleryInfo? {
 
-        return metadata.reader
+        return metadata.galleryInfo
             ?: withContext(Dispatchers.IO) {
                 try {
                     xyz.quaver.hitomi.getGalleryInfo(galleryID).also {
                         setMetadata { metadata ->
-                            metadata.reader = it
+                            metadata.galleryInfo = it
 
                             if (metadata.imageList == null)
                                 metadata.imageList = MutableList(it.files.size) { null }