hotfix

app/src/main/java/xyz/quaver/pupil/util/ConstValues.kt

@@ -21,4 +21,5 @@ package xyz.quaver.pupil.util
 const val REQUEST_LOCK = 38238
 const val REQUEST_RESTORE = 16546
 const val REQUEST_DOWNLOAD_FOLDER = 3874
-const val REQUEST_DOWNLOAD_FOLDER_OLD = 3425
+const val REQUEST_DOWNLOAD_FOLDER_OLD = 3425
+const val REQUEST_WRITE_PERMISSION_AND_SAF = 13900

app/src/main/java/xyz/quaver/pupil/util/FileUtils.java

@@ -1,178 +0,0 @@
-/*
- *     Pupil, Hitomi.la viewer for Android
- *     Copyright (C) 2020  tom5079
- *
- *     This program is free software: you can redistribute it and/or modify
- *     it under the terms of the GNU General Public License as published by
- *     the Free Software Foundation, either version 3 of the License, or
- *     (at your option) any later version.
- *
- *     This program is distributed in the hope that it will be useful,
- *     but WITHOUT ANY WARRANTY; without even the implied warranty of
- *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *     GNU General Public License for more details.
- *
- *     You should have received a copy of the GNU General Public License
- *     along with this program.  If not, see <http://www.gnu.org/licenses/>.
- */
-
-package xyz.quaver.pupil.util;
-
-/*
- * Copyright (C) 2007-2008 OpenIntents.org
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-import android.content.ContentUris;
-import android.content.Context;
-import android.database.Cursor;
-import android.net.Uri;
-import android.os.Build;
-import android.provider.DocumentsContract;
-import android.provider.MediaStore;
-
-/**
- * @version 2009-07-03
- * @author Peli
- * @version 2013-12-11
- * @author paulburke (ipaulpro)
- */
-public class FileUtils {
-    /**
-     * Get a file path from a Uri. This will get the the path for Storage Access
-     * Framework Documents, as well as the _data field for the MediaStore and
-     * other file-based ContentProviders.
-     *
-     * @param context The context.
-     * @param uri The Uri to query.
-     * @author paulburke
-     */
-    public static String getPath(final Context context, final Uri uri) {
-
-        // DocumentProvider
-        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT && DocumentsContract.isDocumentUri(context, uri)) {
-            // ExternalStorageProvider
-            if (isExternalStorageDocument(uri)) {
-                final String docId = DocumentsContract.getDocumentId(uri);
-                final String[] split = docId.split(":");
-                final String type = split[0];
-
-                if ("primary".equalsIgnoreCase(type)) {
-                    return context.getExternalFilesDir(null).getParentFile().getParentFile().getParentFile().getParent() + "/" + split[1];
-                }
-
-                // TODO handle non-primary volumes
-            }
-            // DownloadsProvider
-            else if (isDownloadsDocument(uri)) {
-
-                final String id = DocumentsContract.getDocumentId(uri);
-                final Uri contentUri = ContentUris.withAppendedId(
-                        Uri.parse("content://downloads/public_downloads"), Long.valueOf(id));
-
-                return getDataColumn(context, contentUri, null, null);
-            }
-            // MediaProvider
-            else if (isMediaDocument(uri)) {
-                final String docId = DocumentsContract.getDocumentId(uri);
-                final String[] split = docId.split(":");
-                final String type = split[0];
-
-                Uri contentUri = null;
-                if ("image".equals(type)) {
-                    contentUri = MediaStore.Images.Media.EXTERNAL_CONTENT_URI;
-                } else if ("video".equals(type)) {
-                    contentUri = MediaStore.Video.Media.EXTERNAL_CONTENT_URI;
-                } else if ("audio".equals(type)) {
-                    contentUri = MediaStore.Audio.Media.EXTERNAL_CONTENT_URI;
-                }
-
-                final String selection = "_id=?";
-                final String[] selectionArgs = new String[] {
-                        split[1]
-                };
-
-                return getDataColumn(context, contentUri, selection, selectionArgs);
-            }
-        }
-        // MediaStore (and general)
-        else if ("content".equalsIgnoreCase(uri.getScheme())) {
-            return getDataColumn(context, uri, null, null);
-        }
-        // File
-        else if ("file".equalsIgnoreCase(uri.getScheme())) {
-            return uri.getPath();
-        }
-
-        return null;
-    }
-
-    /**
-     * Get the value of the data column for this Uri. This is useful for
-     * MediaStore Uris, and other file-based ContentProviders.
-     *
-     * @param context The context.
-     * @param uri The Uri to query.
-     * @param selection (Optional) Filter used in the query.
-     * @param selectionArgs (Optional) Selection arguments used in the query.
-     * @return The value of the _data column, which is typically a file path.
-     */
-    public static String getDataColumn(Context context, Uri uri, String selection,
-                                       String[] selectionArgs) {
-
-        Cursor cursor = null;
-        final String column = "_data";
-        final String[] projection = {
-                column
-        };
-
-        try {
-            cursor = context.getContentResolver().query(uri, projection, selection, selectionArgs,
-                    null);
-            if (cursor != null && cursor.moveToFirst()) {
-                final int column_index = cursor.getColumnIndexOrThrow(column);
-                return cursor.getString(column_index);
-            }
-        } finally {
-            if (cursor != null)
-                cursor.close();
-        }
-        return null;
-    }
-
-
-    /**
-     * @param uri The Uri to check.
-     * @return Whether the Uri authority is ExternalStorageProvider.
-     */
-    public static boolean isExternalStorageDocument(Uri uri) {
-        return "com.android.externalstorage.documents".equals(uri.getAuthority());
-    }
-
-    /**
-     * @param uri The Uri to check.
-     * @return Whether the Uri authority is DownloadsProvider.
-     */
-    public static boolean isDownloadsDocument(Uri uri) {
-        return "com.android.providers.downloads.documents".equals(uri.getAuthority());
-    }
-
-    /**
-     * @param uri The Uri to check.
-     * @return Whether the Uri authority is MediaProvider.
-     */
-    public static boolean isMediaDocument(Uri uri) {
-        return "com.android.providers.media.documents".equals(uri.getAuthority());
-    }
-}

app/src/main/java/xyz/quaver/pupil/util/download/Cache.kt

@@ -21,7 +21,7 @@ package xyz.quaver.pupil.util.download
 import android.content.Context
 import android.content.ContextWrapper
 import android.util.Base64
-import androidx.documentfile.provider.DocumentFile
+import android.util.Log
 import androidx.preference.PreferenceManager
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.Dispatchers
@@ -34,7 +34,8 @@ import kotlinx.serialization.stringify
 import xyz.quaver.Code
 import xyz.quaver.hitomi.GalleryBlock
 import xyz.quaver.hitomi.Reader
-import xyz.quaver.pupil.util.*
+import xyz.quaver.pupil.util.getCachedGallery
+import xyz.quaver.pupil.util.getDownloadDirectory
 import java.io.File
 import java.net.URL
 
@@ -44,29 +45,20 @@ class Cache(context: Context) : ContextWrapper(context) {
 
     // Search in this order
     // Download -> Cache
-    fun getCachedGallery(galleryID: Int) : DocumentFile? {
-        var file = getDownloadDirectory(this).findFile(galleryID.toString())
-
-        if (file?.exists() == true)
-            return file
-
-        file = DocumentFile.fromFile(File(cacheDir, "imageCache/$galleryID"))
-
-        return if (file.exists())
-             file
-        else
-             null
+    fun getCachedGallery(galleryID: Int) = getCachedGallery(this, galleryID).also {
+        if (!it.exists())
+            it.mkdirs()
     }
 
     @UseExperimental(ImplicitReflectionSerializer::class)
     fun getCachedMetadata(galleryID: Int) : Metadata? {
-        val file = (getCachedGallery(galleryID) ?: return null).findFile(".metadata")
+        val file = File(getCachedGallery(galleryID), ".metadata")
 
-        if (file?.exists() != true)
+        if (!file.exists())
             return null
 
         return try {
-            Json.parse(file.readText(this))
+            Json.parse(file.readText())
         } catch (e: Exception) {
             //File corrupted
             file.delete()
@@ -76,13 +68,12 @@ class Cache(context: Context) : ContextWrapper(context) {
 
     @UseExperimental(ImplicitReflectionSerializer::class)
     fun setCachedMetadata(galleryID: Int, metadata: Metadata) {
-        val file = getCachedGallery(galleryID)?.findFile(".metadata") ?:
-        DocumentFile.fromFile(File(cacheDir, "imageCache/$galleryID").also {
+        val file = File(getCachedGallery(galleryID), ".metadata").also {
             if (!it.exists())
-                it.mkdirs()
-        }).createFile("null", ".metadata") ?: return
+                it.createNewFile()
+        }
 
-        file.writeText(this, Json.stringify(metadata))
+        file.writeText(Json.stringify(metadata))
     }
 
     suspend fun getThumbnail(galleryID: Int): String? {
@@ -186,46 +177,39 @@ class Cache(context: Context) : ContextWrapper(context) {
         return reader
     }
 
-    fun getImages(galleryID: Int): List<DocumentFile?>? {
-        val gallery = getCachedGallery(galleryID) ?: return null
+    fun getImages(galleryID: Int): List<File?>? {
+        val started = System.currentTimeMillis()
+        val gallery = getCachedGallery(galleryID)
         val reader = getReaderOrNull(galleryID) ?: return null
-        val images = gallery.listFiles()
+        val images = gallery.listFiles() ?: return null
 
+        Log.i("PUPILD", "${System.currentTimeMillis() - started} ms")
         return reader.galleryInfo.indices.map { index ->
-            images.firstOrNull { file -> file.name?.startsWith("%05d".format(index)) == true }
+            images.firstOrNull { file -> file.name.startsWith("%05d".format(index)) }
         }
     }
 
     fun putImage(galleryID: Int, name: String, data: ByteArray) {
-        val cache = getCachedGallery(galleryID) ?:
-        DocumentFile.fromFile(File(cacheDir, "imageCache/$galleryID").also {
+        val cache = File(getCachedGallery(galleryID), name).also {
             if (!it.exists())
-                it.mkdirs()
-        }) ?: return
+                it.createNewFile()
+        }
 
         if (!Regex("""^[0-9]+.+$""").matches(name))
             throw IllegalArgumentException("File name is not a number")
 
-        cache.let {
-            if (it.findFile(name) != null)
-                it
-            else
-                it.createFile("null", name)
-        }?.writeBytes(this, data)
+        cache.writeBytes(data)
     }
 
     fun moveToDownload(galleryID: Int) {
-        val cache = getCachedGallery(galleryID)
+        val cache = getCachedGallery(galleryID).also {
+            if (!it.exists())
+                return
+        }
+        val download = File(getDownloadDirectory(this), galleryID.toString())
 
-        if (cache != null) {
-            val download = getDownloadDirectory(this)
-
-            if (!download.isParentOf(cache)) {
-                cache.copyRecursively(this, download)
-                cache.deleteRecursively()
-            }
-        } else
-            getDownloadDirectory(this).createDirectory(galleryID.toString())
+        cache.copyRecursively(download, true)
+        cache.deleteRecursively()
     }
 
     fun isDownloading(galleryID: Int) = getCachedMetadata(galleryID)?.isDownloading == true

app/src/main/java/xyz/quaver/pupil/util/download/DownloadWorker.kt

@@ -214,28 +214,8 @@ class DownloadWorker private constructor(context: Context) : ContextWrapper(cont
     fun isCompleted(galleryID: Int) = progress[galleryID]?.all { !it.isFinite() } == true
 
     private fun queueDownload(galleryID: Int, reader: Reader, index: Int, callback: Callback) {
-        val cache = Cache(this@DownloadWorker).getImages(galleryID)
         val lowQuality = preferences.getBoolean("low_quality", false)
 
-        //Cache exists :P
-        cache?.get(index)?.let {
-            progress[galleryID]?.set(index, Float.POSITIVE_INFINITY)
-
-            notify(galleryID)
-
-            if (isCompleted(galleryID)) {
-                with(Cache(this@DownloadWorker)) {
-                    if (isDownloading(galleryID)) {
-                        moveToDownload(galleryID)
-                        setDownloading(galleryID, false)
-                    }
-                }
-                nRunners--
-            }
-
-            return
-        }
-
         val request = Request.Builder().apply {
             when (reader.code) {
                 Code.HITOMI -> {
@@ -276,7 +256,14 @@ class DownloadWorker private constructor(context: Context) : ContextWrapper(cont
             return@launch
         }
 
-        progress.put(galleryID, reader.galleryInfo.map { 0F }.toMutableList())
+        val cache = Cache(this@DownloadWorker).getImages(galleryID)
+
+        progress.put(galleryID, reader.galleryInfo.indices.map { index ->
+            if (cache?.get(index) != null)
+                Float.POSITIVE_INFINITY
+            else
+                0F
+        }.toMutableList())
         exception.put(galleryID, reader.galleryInfo.map { null }.toMutableList())
 
         if (notification[galleryID] == null)
@@ -285,6 +272,18 @@ class DownloadWorker private constructor(context: Context) : ContextWrapper(cont
         notification[galleryID].setContentTitle(reader.title)
         notify(galleryID)
 
+        if (isCompleted(galleryID)) {
+            with(Cache(this@DownloadWorker)) {
+                if (isDownloading(galleryID)) {
+                    moveToDownload(galleryID)
+                    setDownloading(galleryID, false)
+                }
+            }
+            nRunners--
+
+            return@launch
+        }
+
         for (i in reader.galleryInfo.indices) {
             val callback = object : Callback {
                 override fun onFailure(call: Call, e: IOException) {
@@ -297,10 +296,11 @@ class DownloadWorker private constructor(context: Context) : ContextWrapper(cont
                     notify(galleryID)
 
                     if (isCompleted(galleryID)) {
-                        val cache = Cache(this@DownloadWorker)
-                        if (cache.isDownloading(galleryID)) {
-                            cache.moveToDownload(galleryID)
-                            cache.setDownloading(galleryID, false)
+                        with(Cache(this@DownloadWorker)) {
+                            if (isDownloading(galleryID)) {
+                                moveToDownload(galleryID)
+                                setDownloading(galleryID, false)
+                            }
                         }
                         nRunners--
                     }
@@ -319,17 +319,19 @@ class DownloadWorker private constructor(context: Context) : ContextWrapper(cont
                     notify(galleryID)
 
                     if (isCompleted(galleryID)) {
-                        val cache = Cache(this@DownloadWorker)
-                        if (cache.isDownloading(galleryID)) {
-                            cache.moveToDownload(galleryID)
-                            cache.setDownloading(galleryID, false)
+                        with(Cache(this@DownloadWorker)) {
+                            if (isDownloading(galleryID)) {
+                                moveToDownload(galleryID)
+                                setDownloading(galleryID, false)
+                            }
                         }
                         nRunners--
                     }
                 }
             }
 
-            queueDownload(galleryID, reader, i, callback)
+            if (progress[galleryID]?.get(i)?.isFinite() == true)
+                queueDownload(galleryID, reader, i, callback)
         }
     }
 

app/src/main/java/xyz/quaver/pupil/util/file.kt

@@ -18,43 +18,45 @@
 
 package xyz.quaver.pupil.util
 
+import android.annotation.TargetApi
 import android.content.Context
 import android.net.Uri
-import androidx.core.content.FileProvider
-import androidx.documentfile.provider.DocumentFile
+import android.os.Build
+import android.os.storage.StorageManager
+import android.provider.DocumentsContract
+import androidx.core.content.ContextCompat
 import androidx.preference.PreferenceManager
 import java.io.File
+import java.io.FileOutputStream
+import java.lang.reflect.Array
 import java.net.URL
-import java.nio.charset.Charset
-import java.util.*
+
 
 fun getCachedGallery(context: Context, galleryID: Int) =
-    getDownloadDirectory(context).findFile(galleryID.toString()) ?:
-    DocumentFile.fromFile(File(context.cacheDir, "imageCache/$galleryID"))
-
-fun getDownloadDirectory(context: Context) : DocumentFile {
-    val uri = PreferenceManager.getDefaultSharedPreferences(context).getString("dl_location", null).let {
-        if (it != null)
-            Uri.parse(it)
+    File(getDownloadDirectory(context), galleryID.toString()).let {
+        if (it.exists())
+            it
         else
-            Uri.fromFile(context.getExternalFilesDir(null))
+            File(context.cacheDir, "imageCache/$galleryID")
     }
 
-    return if (uri.toString().startsWith("file"))
-        DocumentFile.fromFile(File(uri.path!!))
-    else
-        DocumentFile.fromTreeUri(context, uri) ?: DocumentFile.fromFile(context.getExternalFilesDir(null)!!)
-}
+fun getDownloadDirectory(context: Context) =
+    PreferenceManager.getDefaultSharedPreferences(context).getString("dl_location", null).let {
+        if (it != null && !it.startsWith("content"))
+            File(it)
+        else
+            context.getExternalFilesDir(null)!!
+    }
 
-fun convertUpdateUri(context: Context, uri: Uri) : Uri =
-    if (uri.toString().startsWith("file"))
-        FileProvider.getUriForFile(context, context.applicationContext.packageName + ".provider", File(uri.path!!.substringAfter("file:///")))
-    else
-        uri
+fun URL.download(to: File, onDownloadProgress: ((Long, Long) -> Unit)? = null) {
 
-fun URL.download(context: Context, to: DocumentFile, onDownloadProgress: ((Long, Long) -> Unit)? = null) {
-    context.contentResolver.openOutputStream(to.uri).use { out ->
-        out!!
+    if (to.parentFile?.exists() == false)
+        to.parentFile!!.mkdirs()
+
+    if (!to.exists())
+        to.createNewFile()
+
+    FileOutputStream(to).use { out ->
 
         with(openConnection()) {
             val fileSize = contentLength.toLong()
@@ -78,74 +80,135 @@ fun URL.download(context: Context, to: DocumentFile, onDownloadProgress: ((Long,
     }
 }
 
-fun DocumentFile.isParentOf(file: DocumentFile?) : Boolean {
-    var parent = file?.parentFile
-    while (parent != null) {
-        if (this.uri.path == parent.uri.path)
-            return true
-
-        parent = parent.parentFile
-    }
-
-    return false
-}
-
-fun DocumentFile.reader(context: Context, charset: Charset = Charsets.UTF_8) = context.contentResolver.openInputStream(uri)!!.reader(charset)
-fun DocumentFile.readBytes(context: Context) = context.contentResolver.openInputStream(uri)!!.readBytes()
-fun DocumentFile.readText(context: Context, charset: Charset = Charsets.UTF_8) = reader(context, charset).use { it.readText() }
-
-fun DocumentFile.writeBytes(context: Context, array: ByteArray) = context.contentResolver.openOutputStream(uri)!!.write(array)
-fun DocumentFile.writeText(context: Context, text: String, charset: Charset = Charsets.UTF_8) = writeBytes(context, text.toByteArray(charset))
-
-fun DocumentFile.copyRecursively(
-    context: Context,
-    target: DocumentFile
-) {
-    if (!exists())
-        throw Exception("The source file doesn't exist.")
-
-    if (this.isFile) {
-        target.let {
-            if (it.findFile(name!!) != null)
-                it
-            else
-                createFile("null", name!!)!!
-        }.writeBytes(
-            context,
-            readBytes(context)
-        )
-    } else if (this.isDirectory) {
-        target.createDirectory(name!!).also { newTarget ->
-            listFiles().forEach { child ->
-                child.copyRecursively(context, newTarget!!)
+fun getExtSdCardPaths(context: Context) =
+    ContextCompat.getExternalFilesDirs(context, null).drop(1).map {
+        it.absolutePath.substringBeforeLast("/Android/data").let {  path ->
+            runCatching {
+                File(path).canonicalPath
+            }.getOrElse {
+                path
             }
         }
     }
+
+const val PRIMARY_VOLUME_NAME = "primary"
+fun getVolumePath(context: Context, volumeID: String?): String? {
+    return runCatching {
+        val storageManager = context.getSystemService(Context.STORAGE_SERVICE) as StorageManager
+        val storageVolumeClass = Class.forName("android.os.storage.StorageVolume")
+
+        val getVolumeList = storageVolumeClass.javaClass.getMethod("getVolumeList")
+        val getUUID = storageVolumeClass.getMethod("getUuid")
+        val getPath = storageVolumeClass.getMethod("getPath")
+        val isPrimary = storageVolumeClass.getMethod("isPrimary")
+
+        val result = getVolumeList.invoke(storageManager)!!
+
+        val length = Array.getLength(result)
+
+        for (i in 0 until length) {
+            val storageVolumeElement = Array.get(result, i)
+            val uuid = getUUID.invoke(storageVolumeElement) as? String
+            val primary = isPrimary.invoke(storageVolumeElement) as? Boolean
+
+            // primary volume?
+            if (primary == true && volumeID == PRIMARY_VOLUME_NAME)
+                return@runCatching getPath.invoke(storageVolumeElement) as? String
+
+            // other volumes?
+            if (volumeID == uuid) {
+                return@runCatching getPath.invoke(storageVolumeElement) as? String
+            }
+        }
+        return@runCatching null
+    }.getOrNull()
 }
 
-fun DocumentFile.deleteRecursively() {
+// Credits go to https://stackoverflow.com/questions/34927748/android-5-0-documentfile-from-tree-uri/36162691#36162691
+@TargetApi(Build.VERSION_CODES.LOLLIPOP)
+fun getVolumeIdFromTreeUri(uri: Uri) =
+    DocumentsContract.getTreeDocumentId(uri).split(':').let {
+        if (it.isNotEmpty())
+            it[0]
+        else
+            null
+    }
 
-    if (this.isDirectory)
-        listFiles().forEach {
-            it.deleteRecursively()
+@TargetApi(Build.VERSION_CODES.LOLLIPOP)
+fun getDocumentPathFromTreeUri(uri: Uri) =
+    DocumentsContract.getTreeDocumentId(uri).split(':').let {
+        if (it.size >= 2)
+            it[1]
+        else
+            File.separator
+    }
+
+fun getFullPathFromTreeUri(context: Context, uri: Uri) : String? {
+    val volumePath = getVolumePath(context, getVolumeIdFromTreeUri(uri) ?: return null).let {
+        it ?: return File.separator
+
+        if (it.endsWith(File.separator))
+            it.dropLast(1)
+        else
+            it
+    }
+
+    val documentPath = getDocumentPathFromTreeUri(uri).let {
+        if (it.endsWith(File.separator))
+            it.dropLast(1)
+        else
+            it
+    }
+
+    return if (documentPath.isNotEmpty()) {
+        if (documentPath.startsWith(File.separator))
+            volumePath + documentPath
+        else
+            volumePath + File.separator + documentPath
+    } else
+        volumePath
+}
+
+// Huge thanks to avluis(https://github.com/avluis)
+// This code is originated from Hentoid(https://github.com/avluis/Hentoid) under Apache-2.0 license.
+fun Uri.toFile(context: Context): File? {
+    val path = this.path ?: return null
+
+    val pathSeparator = path.indexOf(':')
+    val folderName = path.substring(pathSeparator+1)
+
+    // Determine whether the designated file is
+    // - on a removable media (e.g. SD card, OTG)
+    // or
+    // - on the internal phone memory
+    val removableMediaFolderRoots = getExtSdCardPaths(context)
+
+    /* First test is to compare root names with known roots of removable media
+     * In many cases, the SD card root name is shared between pre-SAF (File) and SAF (DocumentFile) frameworks
+     * (e.g. /storage/3437-3934 vs. /tree/3437-3934)
+     * This is what the following block is trying to do
+     */
+    for (s in removableMediaFolderRoots) {
+        val sRoot = s.substring(s.lastIndexOf(File.separatorChar))
+        val root = path.substring(0, pathSeparator).let {
+            it.substring(it.lastIndexOf(File.separatorChar))
         }
 
-    this.delete()
-}
+        if (sRoot.equals(root, true)) {
+            return File(s + File.separatorChar + folderName)
+        }
+    }
+    /* In some other cases, there is no common name (e.g. /storage/sdcard1 vs. /tree/3437-3934)
+     * We can use a slower method to translate the Uri obtained with SAF into a pre-SAF path
+     * and compare it to the known removable media volume names
+     */
+    val root = getFullPathFromTreeUri(context, this)
 
-fun DocumentFile.walk(state: LinkedList<DocumentFile> = LinkedList()) : Queue<DocumentFile> {
-    if (state.isEmpty())
-        state.push(this)
-
-    listFiles().forEach {
-        state.push(it)
-
-        if (it.isDirectory) {
-            it.walk(state)
+    for (s in removableMediaFolderRoots) {
+        if (root?.startsWith(s) == true) {
+            return File(root)
         }
     }
 
-    return state
-}
-
-fun File.copyTo(context: Context, target: DocumentFile) = target.writeBytes(context, this.readBytes())
+    return File(context.getExternalFilesDir(null)?.canonicalPath?.substringBeforeLast("/Android/data") ?: return null, folderName)
+}

app/src/main/java/xyz/quaver/pupil/util/update.kt

@@ -26,6 +26,7 @@ import androidx.appcompat.app.AlertDialog
 import androidx.appcompat.app.AppCompatActivity
 import androidx.core.app.NotificationCompat
 import androidx.core.app.NotificationManagerCompat
+import androidx.core.content.FileProvider
 import androidx.lifecycle.Lifecycle
 import androidx.preference.PreferenceManager
 import kotlinx.coroutines.CoroutineScope
@@ -35,6 +36,7 @@ import kotlinx.serialization.json.*
 import ru.noties.markwon.Markwon
 import xyz.quaver.pupil.BuildConfig
 import xyz.quaver.pupil.R
+import java.io.File
 import java.net.URL
 import java.util.*
 
@@ -146,15 +148,10 @@ fun checkUpdate(context: AppCompatActivity, force: Boolean = false) {
                 }
 
                 CoroutineScope(Dispatchers.IO).launch io@{
-                    val target = getDownloadDirectory(context).let {
-                        if (it.findFile("Pupil.apk") != null)
-                            it
-                        else
-                            it.createFile("null", "Pupil.apk")!!
-                    }
+                    val target = File(getDownloadDirectory(context), "Pupil.apk")
 
                     try {
-                        URL(url).download(context, target) { progress, fileSize ->
+                        URL(url).download(target) { progress, fileSize ->
                             builder.setProgress(fileSize.toInt(), progress.toInt(), false)
                             notificationManager.notify(UPDATE_NOTIFICATION_ID, builder.build())
                         }
@@ -173,7 +170,7 @@ fun checkUpdate(context: AppCompatActivity, force: Boolean = false) {
 
                     val install = Intent(Intent.ACTION_VIEW).apply {
                         flags = Intent.FLAG_ACTIVITY_CLEAR_TOP or Intent.FLAG_GRANT_READ_URI_PERMISSION
-                        setDataAndType(convertUpdateUri(context, target.uri), MimeTypeMap.getSingleton().getMimeTypeFromExtension("apk"))
+                        setDataAndType(FileProvider.getUriForFile(context, context.applicationContext.packageName + ".provider", target), MimeTypeMap.getSingleton().getMimeTypeFromExtension("apk"))
                     }
 
                     builder.apply {