migrated to ViewBinding

2020-11-27 18:15:57 +09:00
parent d567b30f4b
commit 9f9a4c81b3
37 changed files with 688 additions and 703 deletions
--- a/app/src/main/java/xyz/quaver/pupil/ui/dialog/DefaultQueryDialog.kt
+++ b/app/src/main/java/xyz/quaver/pupil/ui/dialog/DefaultQueryDialog.kt
@@ -18,19 +18,15 @@

 package xyz.quaver.pupil.ui.dialog

-import android.annotation.SuppressLint
 import android.app.Dialog
 import android.content.Context
 import android.os.Bundle
 import android.text.Editable
 import android.text.TextWatcher
-import android.view.LayoutInflater
-import android.view.View
 import android.widget.ArrayAdapter
 import androidx.appcompat.app.AlertDialog
-import kotlinx.android.synthetic.main.dialog_default_query.*
-import kotlinx.android.synthetic.main.dialog_default_query.view.*
 import xyz.quaver.pupil.R
+import xyz.quaver.pupil.databinding.DefaultQueryDialogBinding
 import xyz.quaver.pupil.types.Tags
 import xyz.quaver.pupil.util.Preferences

@@ -49,46 +45,48 @@ class DefaultQueryDialog(context : Context) : AlertDialog(context) {

    var onPositiveButtonClickListener : ((Tags) -> (Unit))? = null

-    @SuppressLint("InflateParams")
-    override fun onCreate(savedInstanceState: Bundle?) {
-        setTitle(R.string.default_query_dialog_title)
-        setView(build())
-        setButton(Dialog.BUTTON_POSITIVE, context.getString(android.R.string.ok)) { _, _ ->
-            val newTags = Tags.parse(default_query_dialog_edittext.text.toString())
+    private lateinit var binding: DefaultQueryDialogBinding

-            with(default_query_dialog_language_selector) {
+    override fun onCreate(savedInstanceState: Bundle?) {
+        super.onCreate(savedInstanceState)
+
+        setTitle(R.string.default_query_dialog_title)
+        binding = DefaultQueryDialogBinding.inflate(layoutInflater)
+        setView(binding.root)
+
+        initView()
+
+        setButton(Dialog.BUTTON_POSITIVE, context.getString(android.R.string.ok)) { _, _ ->
+            val newTags = Tags.parse(binding.edittext.text.toString())
+
+            with(binding.languageSelector) {
                if (selectedItemPosition != 0)
                    newTags.add("language:${reverseLanguages[selectedItem]}")
            }

-            if (default_query_dialog_BL_checkbox.isChecked)
+            if (binding.BLCheckbox.isChecked)
                newTags.add(excludeBL)

-            if (default_query_dialog_guro_checkbox.isChecked)
+            if (binding.guroCheckbox.isChecked)
                excludeGuro.forEach { tag ->
                    newTags.add(tag)
                }

-            if (default_query_dialog_loli_checkbox.isChecked)
+            if (binding.loliCheckbox.isChecked)
                excludeLoli.forEach { tag ->
                    newTags.add(tag)
                }

            onPositiveButtonClickListener?.invoke(newTags)
        }
-
-        super.onCreate(savedInstanceState)
    }

-    @SuppressLint("InflateParams")
-    private fun build() : View {
+    private fun initView() {
        val tags = Tags.parse(
            Preferences["default_query"]
        )

-        val view = LayoutInflater.from(context).inflate(R.layout.dialog_default_query, null)
-
-        with(view.default_query_dialog_language_selector) {
+        with(binding.languageSelector) {
            adapter =
                ArrayAdapter(
                    context,
@@ -111,13 +109,13 @@ class DefaultQueryDialog(context : Context) : AlertDialog(context) {
            }
        }

-        with(view.default_query_dialog_BL_checkbox) {
+        with(binding.BLCheckbox) {
            isChecked = tags.contains(excludeBL)
            if (tags.contains(excludeBL))
                tags.remove(excludeBL)
        }

-        with(view.default_query_dialog_guro_checkbox) {
+        with(binding.guroCheckbox) {
            isChecked = excludeGuro.all { tags.contains(it) }
            if (excludeGuro.all { tags.contains(it) })
                excludeGuro.forEach {
@@ -125,7 +123,7 @@ class DefaultQueryDialog(context : Context) : AlertDialog(context) {
                }
        }

-        with(view.default_query_dialog_loli_checkbox) {
+        with(binding.loliCheckbox) {
            isChecked = excludeLoli.all { tags.contains(it) }
            if (excludeLoli.all { tags.contains(it) })
                excludeLoli.forEach {
@@ -133,7 +131,7 @@ class DefaultQueryDialog(context : Context) : AlertDialog(context) {
                }
        }

-        with(view.default_query_dialog_edittext) {
+        with(binding.edittext) {
            setText(tags.toString(), android.widget.TextView.BufferType.EDITABLE)
            addTextChangedListener(object : TextWatcher {
                override fun beforeTextChanged(
@@ -158,8 +156,6 @@ class DefaultQueryDialog(context : Context) : AlertDialog(context) {
                }
            })
        }
-
-        return view
    }

 }
--- a/app/src/main/java/xyz/quaver/pupil/ui/dialog/DownloadFolderNameDialogFragment.kt
+++ b/app/src/main/java/xyz/quaver/pupil/ui/dialog/DownloadFolderNameDialogFragment.kt
@@ -18,17 +18,15 @@

 package xyz.quaver.pupil.ui.dialog

-import android.annotation.SuppressLint
 import android.app.Dialog
 import android.os.Bundle
-import android.view.View
 import android.view.ViewGroup
 import androidx.core.widget.addTextChangedListener
 import androidx.fragment.app.DialogFragment
 import com.google.android.material.snackbar.Snackbar
-import kotlinx.android.synthetic.main.dialog_download_folder_name.view.*
 import kotlinx.coroutines.runBlocking
 import xyz.quaver.pupil.R
+import xyz.quaver.pupil.databinding.DownloadFolderNameDialogBinding
 import xyz.quaver.pupil.util.Preferences
 import xyz.quaver.pupil.util.downloader.Cache
 import xyz.quaver.pupil.util.formatDownloadFolder
@@ -37,38 +35,48 @@ import xyz.quaver.pupil.util.formatMap

 class DownloadFolderNameDialogFragment : DialogFragment() {

-    @SuppressLint("InflateParams")
-    private fun build(): View {
+    private var _binding: DownloadFolderNameDialogBinding? = null
+    private val binding get() = _binding!!
+
+    override fun onCreateDialog(savedInstanceState: Bundle?): Dialog {
+        _binding = DownloadFolderNameDialogBinding.inflate(layoutInflater)
+
+        initView()
+
+        return Dialog(requireContext()).apply {
+            setContentView(binding.root)
+            window?.attributes?.width = ViewGroup.LayoutParams.MATCH_PARENT
+        }
+    }
+
+    override fun onDestroy() {
+        super.onDestroy()
+        _binding = null
+    }
+
+    private fun initView() {
        val galleryID = Cache.instances.let { if (it.size == 0) 1199708 else it.keys.elementAt((0 until it.size).random()) }
        val galleryBlock = runBlocking {
            Cache.getInstance(requireContext(), galleryID).getGalleryBlock()
        }

-        return layoutInflater.inflate(R.layout.dialog_download_folder_name, null).apply {
-            message.text = getString(R.string.settings_download_folder_name_message, formatMap.keys.toString(), galleryBlock?.formatDownloadFolder() ?: "")
-            edittext.setText(Preferences["download_folder_name", "[-id-] -title-"])
-            edittext.addTextChangedListener {
-                message.text = getString(R.string.settings_download_folder_name_message, formatMap.keys.toString(), galleryBlock?.formatDownloadFolderTest(it.toString()) ?: "")
+        binding.message.text = getString(R.string.settings_download_folder_name_message, formatMap.keys.toString(), galleryBlock?.formatDownloadFolder() ?: "")
+        binding.edittext.setText(Preferences["download_folder_name", "[-id-] -title-"])
+        binding.edittext.addTextChangedListener {
+            binding.message.text = requireContext().getString(R.string.settings_download_folder_name_message, formatMap.keys.toString(), galleryBlock?.formatDownloadFolderTest(it.toString()) ?: "")
+        }
+        binding.okButton.setOnClickListener {
+            val newValue = binding.edittext.text.toString()
+
+            if ((newValue as? String)?.contains("/") != false) {
+                Snackbar.make(binding.root, R.string.settings_invalid_download_folder_name, Snackbar.LENGTH_SHORT).show()
+                return@setOnClickListener
            }
-            ok_button.setOnClickListener {
-                val newValue = edittext.text.toString()

-                if ((newValue as? String)?.contains("/") != false) {
-                    Snackbar.make(this, R.string.settings_invalid_download_folder_name, Snackbar.LENGTH_SHORT).show()
-                    return@setOnClickListener
-                }
+            Preferences["download_folder_name"] = binding.edittext.text.toString()

-                Preferences["download_folder_name"] = edittext.text.toString()
-
-                dismiss()
-            }
+            dismiss()
        }
    }

-    override fun onCreateDialog(savedInstanceState: Bundle?): Dialog =
-       Dialog(requireContext()).apply {
-           setContentView(build())
-           window?.attributes?.width = ViewGroup.LayoutParams.MATCH_PARENT
-       }
-
 }
--- a/app/src/main/java/xyz/quaver/pupil/ui/dialog/DownloadLocationDialogFragment.kt
+++ b/app/src/main/java/xyz/quaver/pupil/ui/dialog/DownloadLocationDialogFragment.kt
@@ -18,27 +18,24 @@

 package xyz.quaver.pupil.ui.dialog

-import android.annotation.SuppressLint
 import android.app.Activity
 import android.app.Dialog
 import android.content.Intent
 import android.os.Build
 import android.os.Bundle
-import android.view.View
-import android.widget.LinearLayout
 import androidx.activity.result.contract.ActivityResultContracts
 import androidx.appcompat.app.AlertDialog
 import androidx.core.content.ContextCompat
 import androidx.core.net.toUri
 import androidx.fragment.app.DialogFragment
 import com.google.android.material.snackbar.Snackbar
-import kotlinx.android.synthetic.main.dialog_download_folder_name.view.*
-import kotlinx.android.synthetic.main.item_download_folder.view.*
 import net.rdrei.android.dirchooser.DirectoryChooserActivity
 import net.rdrei.android.dirchooser.DirectoryChooserConfig
 import xyz.quaver.io.FileX
 import xyz.quaver.io.util.toFile
 import xyz.quaver.pupil.R
+import xyz.quaver.pupil.databinding.DownloadLocationDialogBinding
+import xyz.quaver.pupil.databinding.DownloadLocationItemBinding
 import xyz.quaver.pupil.util.Preferences
 import xyz.quaver.pupil.util.byteToString
 import xyz.quaver.pupil.util.downloader.DownloadManager
@@ -46,7 +43,11 @@ import xyz.quaver.pupil.util.migrate
 import java.io.File

 class DownloadLocationDialogFragment : DialogFragment() {
-    private val entries = mutableMapOf<File?, View>()
+
+    private var _binding: DownloadLocationDialogBinding? = null
+    private val binding get() = _binding!!
+
+    private val entries = mutableMapOf<File?, DownloadLocationItemBinding>()

    private val requestDownloadFolderLauncher = registerForActivityResult(ActivityResultContracts.StartActivityForResult()) {
        if (it.resultCode == Activity.RESULT_OK) {
@@ -63,7 +64,7 @@ class DownloadLocationDialogFragment : DialogFragment() {
                    context.contentResolver.takePersistableUriPermission(uri, takeFlags)

                if (kotlin.runCatching { FileX(context, uri).canWrite() }.getOrDefault(false)) {
-                    entries[null]?.location_available?.text = uri.toFile(context)?.canonicalPath
+                    entries[null]?.locationAvailable?.text = uri.toFile(context)?.canonicalPath
                    Preferences["download_folder"] = uri.toString()
                } else {
                    Snackbar.make(
@@ -75,7 +76,7 @@ class DownloadLocationDialogFragment : DialogFragment() {
                    val downloadFolder = DownloadManager.getInstance(context).downloadFolder.canonicalPath
                    val key = entries.keys.firstOrNull { it?.canonicalPath == downloadFolder }
                    entries[key]!!.button.isChecked = true
-                    if (key == null) entries[key]!!.location_available.text = downloadFolder
+                    if (key == null) entries[key]!!.locationAvailable.text = downloadFolder
                }
            }
        }
@@ -98,49 +99,44 @@ class DownloadLocationDialogFragment : DialogFragment() {
                val downloadFolder = DownloadManager.getInstance(context).downloadFolder.canonicalPath
                val key = entries.keys.firstOrNull { it?.canonicalPath == downloadFolder }
                entries[key]!!.button.isChecked = true
-                if (key == null) entries[key]!!.location_available.text = downloadFolder
+                if (key == null) entries[key]!!.locationAvailable.text = downloadFolder
            }
            else {
-                entries[null]?.location_available?.text = directory
+                entries[null]?.locationAvailable?.text = directory
                Preferences["download_folder"] = File(directory).toURI().toString()
            }
        }
    }

-    @SuppressLint("InflateParams")
-    private fun build() : View? {
-        val context = context ?: return null
-
-        val view = layoutInflater.inflate(R.layout.dialog_download_folder, null) as LinearLayout
-
-        val externalFilesDirs = ContextCompat.getExternalFilesDirs(context, null)
+    private fun initView() {
+        val externalFilesDirs = ContextCompat.getExternalFilesDirs(requireContext(), null)

        externalFilesDirs.forEachIndexed { index, dir ->
            dir ?: return@forEachIndexed

-            view.addView(layoutInflater.inflate(R.layout.item_download_folder, view, false).apply {
-                location_type.text = context.getString(when (index) {
+            DownloadLocationItemBinding.inflate(layoutInflater, binding.root, true).apply {
+                locationType.text = requireContext().getString(when (index) {
                    0 -> R.string.settings_download_folder_internal
                    else -> R.string.settings_download_folder_removable
                })
-                location_available.text = context.getString(
+                locationAvailable.text = requireContext().getString(
                    R.string.settings_download_folder_available,
                    byteToString(dir.freeSpace)
                )
-                setOnClickListener {
-                    entries.values.forEach {
-                        it.button.isChecked = false
+                root.setOnClickListener {
+                    entries.values.forEach { _ ->
+                        button.isChecked = false
                    }
                    button.performClick()
                    Preferences["download_folder"] = dir.toUri().toString()
                }
                entries[dir] = this
-            })
+            }
        }

-        view.addView(layoutInflater.inflate(R.layout.item_download_folder, view, false).apply {
-            location_type.text = context.getString(R.string.settings_download_folder_custom)
-            setOnClickListener {
+        DownloadLocationItemBinding.inflate(layoutInflater, binding.root, true).apply {
+            locationType.text = requireContext().getString(R.string.settings_download_folder_custom)
+            root.setOnClickListener {
                entries.values.forEach {
                    it.button.isChecked = false
                }
@@ -166,31 +162,35 @@ class DownloadLocationDialogFragment : DialogFragment() {
                }
            }
            entries[null] = this
-        })
+        }

-        val downloadFolder = DownloadManager.getInstance(context).downloadFolder.canonicalPath
+        val downloadFolder = DownloadManager.getInstance(requireContext()).downloadFolder.canonicalPath
        val key = entries.keys.firstOrNull { it?.canonicalPath == downloadFolder }
        entries[key]!!.button.isChecked = true
-        if (key == null) entries[key]!!.location_available.text = downloadFolder
-
-        return view
+        if (key == null) entries[key]!!.locationAvailable.text = downloadFolder
    }

    override fun onCreateDialog(savedInstanceState: Bundle?): Dialog {
-        val builder = AlertDialog.Builder(requireContext())
+        _binding = DownloadLocationDialogBinding.inflate(layoutInflater)

-        builder
-            .setTitle(R.string.settings_download_folder)
-            .setView(build())
-            .setPositiveButton(requireContext().getText(android.R.string.ok)) { _, _ ->
+        initView()
+
+        return AlertDialog.Builder(requireContext()).apply {
+            setTitle(R.string.settings_download_folder)
+            setView(binding.root)
+            setPositiveButton(requireContext().getText(android.R.string.ok)) { _, _ ->
                if (Preferences["download_folder", ""].isEmpty())
-                    Preferences["download_folder"] = context?.getExternalFilesDir(null)?.toUri()?.toString() ?: ""
+                    Preferences["download_folder"] = context.getExternalFilesDir(null)?.toUri()?.toString() ?: ""

                DownloadManager.getInstance(requireContext()).migrate()
            }

-        isCancelable = false
+            isCancelable = false
+        }.create()
+    }

-        return builder.create()
+    override fun onDestroy() {
+        super.onDestroy()
+        _binding = null
    }
 }
--- a/app/src/main/java/xyz/quaver/pupil/ui/dialog/GalleryDialog.kt
+++ b/app/src/main/java/xyz/quaver/pupil/ui/dialog/GalleryDialog.kt
@@ -22,7 +22,6 @@ import android.content.Context
 import android.content.Intent
 import android.net.Uri
 import android.os.Bundle
-import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
 import android.widget.LinearLayout.LayoutParams
@@ -32,10 +31,6 @@ import androidx.recyclerview.widget.LinearLayoutManager
 import androidx.recyclerview.widget.RecyclerView
 import androidx.viewpager2.widget.ViewPager2
 import com.google.android.material.snackbar.Snackbar
-import kotlinx.android.synthetic.main.dialog_gallery.*
-import kotlinx.android.synthetic.main.dialog_gallery_details.view.*
-import kotlinx.android.synthetic.main.dialog_gallery_dotindicator.view.*
-import kotlinx.android.synthetic.main.item_gallery_details.view.*
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.launch
@@ -45,6 +40,7 @@ import xyz.quaver.hitomi.getGallery
 import xyz.quaver.pupil.R
 import xyz.quaver.pupil.adapters.GalleryBlockAdapter
 import xyz.quaver.pupil.adapters.ThumbnailPageAdapter
+import xyz.quaver.pupil.databinding.*
 import xyz.quaver.pupil.favoriteTags
 import xyz.quaver.pupil.types.Tag
 import xyz.quaver.pupil.ui.ReaderActivity
@@ -59,9 +55,12 @@ class GalleryDialog(context: Context, private val galleryID: Int) : AlertDialog(

    val onChipClickedHandler = ArrayList<((Tag) -> (Unit))>()

+    private lateinit var binding: GalleryDialogBinding
+
    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
-        setContentView(R.layout.dialog_gallery)
+        binding = GalleryDialogBinding.inflate(layoutInflater)
+        setContentView(binding.root)

        window?.attributes.apply {
            this ?: return@apply
@@ -70,7 +69,7 @@ class GalleryDialog(context: Context, private val galleryID: Int) : AlertDialog(
            height = LayoutParams.MATCH_PARENT
        }

-        with(gallery_fab) {
+        with(binding.fab) {
            setImageDrawable(ContextCompat.getDrawable(context, R.drawable.arrow_right))
            setOnClickListener {
                context.startActivity(Intent(context, ReaderActivity::class.java).apply {
@@ -83,12 +82,12 @@ class GalleryDialog(context: Context, private val galleryID: Int) : AlertDialog(
            try {
                val gallery = getGallery(galleryID)

-                gallery_cover.post {
-                    gallery_progressbar.visibility = View.GONE
-                    gallery_title.text = gallery.title
-                    gallery_artist.text = gallery.artists.joinToString(", ") { it.wordCapitalize() }
+                launch (Dispatchers.Main) {
+                    binding.progressbar.visibility = View.GONE
+                    binding.title.text = gallery.title
+                    binding.artist.text = gallery.artists.joinToString(", ") { it.wordCapitalize() }

-                    with(gallery_type) {
+                    with(binding.type) {
                        text = gallery.type.wordCapitalize()
                        setOnClickListener {
                            gallery.type.let {
@@ -105,14 +104,14 @@ class GalleryDialog(context: Context, private val galleryID: Int) : AlertDialog(
                        }
                    }

-                    gallery_cover.showImage(Uri.parse(gallery.cover))
+                    binding.cover.showImage(Uri.parse(gallery.cover))

                    addDetails(gallery)
                    addThumbnails(gallery)
                    addRelated(gallery)
                }
            } catch (e: Exception) {
-                Snackbar.make(gallery_layout, R.string.unable_to_connect, Snackbar.LENGTH_INDEFINITE).apply {
+                Snackbar.make(binding.root, R.string.unable_to_connect, Snackbar.LENGTH_INDEFINITE).apply {
                    if (Locale.getDefault().language == "ko")
                        setAction(context.getText(R.string.https_text)) {
                            context.startActivity(Intent(Intent.ACTION_VIEW, Uri.parse(context.getString(R.string.https))))
@@ -123,10 +122,8 @@ class GalleryDialog(context: Context, private val galleryID: Int) : AlertDialog(
    }

    private fun addDetails(gallery: Gallery) {
-        val inflater = LayoutInflater.from(context)
-
-        inflater.inflate(R.layout.dialog_gallery_details, gallery_contents, false).apply {
-            gallery_details.setText(R.string.gallery_details)
+        GalleryDialogDetailsBinding.inflate(layoutInflater, binding.contents, true).apply {
+            type.setText(R.string.gallery_details)

            listOf(
                R.string.gallery_artists,
@@ -163,13 +160,13 @@ class GalleryDialog(context: Context, private val galleryID: Int) : AlertDialog(
                    }
                )
            ).filter {
-                (_, content) -> content.isNotEmpty()
+                    (_, content) -> content.isNotEmpty()
            }.forEach { (title, content) ->
-                inflater.inflate(R.layout.item_gallery_details, gallery_details_contents, false).apply {
-                    gallery_details_type.setText(title)
+                GalleryDialogTagsBinding.inflate(layoutInflater, contents, true).apply {
+                    type.setText(title)

                    content.forEach { tag ->
-                        gallery_details_tags.addView(
+                        tags.addView(
                            TagChip(context, tag).apply {
                                setOnClickListener {
                                    onChipClickedHandler.forEach { handler ->
@@ -179,41 +176,33 @@ class GalleryDialog(context: Context, private val galleryID: Int) : AlertDialog(
                            }
                        )
                    }
-                }.let {
-                    gallery_details_contents.addView(it)
                }
            }
-        }.let {
-            gallery_contents.addView(it)
        }
    }

    private fun addThumbnails(gallery: Gallery) {
-        val inflater = LayoutInflater.from(context)
-
-        inflater.inflate(R.layout.dialog_gallery_details, gallery_contents, false).apply {
-            gallery_details.setText(R.string.gallery_thumbnails)
+        GalleryDialogDetailsBinding.inflate(layoutInflater, binding.contents, true).apply {
+            type.setText(R.string.gallery_thumbnails)

            val pager = ViewPager2(context).apply {
                adapter = ThumbnailPageAdapter(gallery.thumbnails)
                layoutParams = ViewGroup.LayoutParams(ViewGroup.LayoutParams.MATCH_PARENT, LayoutParams.WRAP_CONTENT)
            }

-            gallery_details_contents.addView(
+            contents.addView(
                pager,
                LayoutParams(LayoutParams.MATCH_PARENT, LayoutParams.WRAP_CONTENT)
            )

-            LayoutInflater.from(context).inflate(R.layout.dialog_gallery_dotindicator, gallery_details_contents)
-
-            gallery_dotindicator.setViewPager2(pager)
-        }.let {
-            gallery_contents.addView(it)
+            // TODO: Change to direct allocation
+            GalleryDialogDotindicatorBinding.inflate(layoutInflater, contents, true).apply {
+                dotindicator.setViewPager2(pager)
+            }
        }
    }

    private fun addRelated(gallery: Gallery) {
-        val inflater = LayoutInflater.from(context)
        val galleries = ArrayList<Int>()

        val adapter = GalleryBlockAdapter(galleries).apply {
@@ -224,8 +213,8 @@ class GalleryDialog(context: Context, private val galleryID: Int) : AlertDialog(
            }
        }

-        inflater.inflate(R.layout.dialog_gallery_details, gallery_contents, false).apply {
-            gallery_details.setText(R.string.gallery_related)
+        GalleryDialogDetailsBinding.inflate(layoutInflater, binding.contents, true).apply {
+            type.setText(R.string.gallery_related)

            RecyclerView(context).apply {
                layoutManager = LinearLayoutManager(context)
@@ -247,22 +236,18 @@ class GalleryDialog(context: Context, private val galleryID: Int) : AlertDialog(
                        true
                    }
                }
-            }.let {
-                gallery_details_contents.addView(it, LayoutParams(LayoutParams.MATCH_PARENT, LayoutParams.WRAP_CONTENT))
            }
-        }.let {
-            gallery_contents.addView(it)
-        }

-        CoroutineScope(Dispatchers.IO).launch {
-            gallery.related.forEach { galleryID ->
-                Cache.getInstance(context, galleryID).getGalleryBlock()?.let {
-                    galleries.add(galleryID)
+            CoroutineScope(Dispatchers.IO).launch {
+                gallery.related.forEach { galleryID ->
+                    Cache.getInstance(context, galleryID).getGalleryBlock()?.let {
+                        galleries.add(galleryID)
+                    }
                }
-            }

-            withContext(Dispatchers.Main) {
-                adapter.notifyDataSetChanged()
+                withContext(Dispatchers.Main) {
+                    adapter.notifyDataSetChanged()
+                }
            }
        }
    }
--- a/app/src/main/java/xyz/quaver/pupil/ui/dialog/ProxyDialog.kt
+++ b/app/src/main/java/xyz/quaver/pupil/ui/dialog/ProxyDialog.kt
@@ -18,23 +18,19 @@

 package xyz.quaver.pupil.ui.dialog

-import android.annotation.SuppressLint
-import android.app.Dialog
 import android.content.Context
 import android.os.Bundle
-import android.view.LayoutInflater
 import android.view.View
-import android.view.ViewGroup
 import android.widget.AdapterView
 import android.widget.ArrayAdapter
 import androidx.appcompat.app.AlertDialog
-import kotlinx.android.synthetic.main.dialog_proxy.view.*
 import kotlinx.serialization.encodeToString
 import kotlinx.serialization.json.Json
 import xyz.quaver.pupil.R
 import xyz.quaver.pupil.client
 import xyz.quaver.pupil.clientBuilder
 import xyz.quaver.pupil.clientHolder
+import xyz.quaver.pupil.databinding.ProxyDialogBinding
 import xyz.quaver.pupil.util.Preferences
 import xyz.quaver.pupil.util.ProxyInfo
 import xyz.quaver.pupil.util.getProxyInfo
@@ -43,33 +39,35 @@ import java.net.Proxy

 class ProxyDialog(context: Context) : AlertDialog(context) {

-    override fun onCreate(savedInstanceState: Bundle?) {
-        setView(build())
+    private lateinit var binding: ProxyDialogBinding

+    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
+
+        binding = ProxyDialogBinding.inflate(layoutInflater)
+        setView(binding.root)
+
+        initView()
    }

-    @SuppressLint("InflateParams")
-    private fun build() : View {
+    private fun initView() {
        val proxyInfo = getProxyInfo()

-        val view = LayoutInflater.from(context).inflate(R.layout.dialog_proxy, null)
-
        val enabler = { enable: Boolean ->
-            view?.proxy_addr?.isEnabled = enable
-            view?.proxy_port?.isEnabled = enable
-            view?.proxy_username?.isEnabled = enable
-            view?.proxy_password?.isEnabled = enable
+            binding.addr.isEnabled = enable
+            binding.port.isEnabled = enable
+            binding.username.isEnabled = enable
+            binding.password.isEnabled = enable

            if (!enable) {
-                view?.proxy_addr?.text = null
-                view?.proxy_port?.text = null
-                view?.proxy_username?.text = null
-                view?.proxy_password?.text = null
+                binding.addr.text = null
+                binding.port.text = null
+                binding.username.text = null
+                binding.password.text = null
            }
        }

-        with(view.proxy_type_selector) {
+        with(binding.typeSelector) {
            adapter = ArrayAdapter(
                context,
                android.R.layout.simple_spinner_dropdown_item,
@@ -87,29 +85,29 @@ class ProxyDialog(context: Context) : AlertDialog(context) {
            }
        }

-        view.proxy_addr.setText(proxyInfo.host)
-        view.proxy_port.setText(proxyInfo.port?.toString())
-        view.proxy_username.setText(proxyInfo.username)
-        view.proxy_password.setText(proxyInfo.password)
+        binding.addr.setText(proxyInfo.host)
+        binding.port.setText(proxyInfo.port?.toString())
+        binding.username.setText(proxyInfo.username)
+        binding.password.setText(proxyInfo.password)

        enabler.invoke(proxyInfo.type != Proxy.Type.DIRECT)

-        view.proxy_cancel.setOnClickListener {
+        binding.cancelButton.setOnClickListener {
            dismiss()
        }

-        view.proxy_ok.setOnClickListener {
-            val type = Proxy.Type.values()[view.proxy_type_selector.selectedItemPosition]
-            val addr = view.proxy_addr.text?.toString()
-            val port = view.proxy_port.text?.toString()?.toIntOrNull()
-            val username = view.proxy_username.text?.toString()
-            val password = view.proxy_password.text?.toString()
+        binding.okButton.setOnClickListener {
+            val type = Proxy.Type.values()[binding.typeSelector.selectedItemPosition]
+            val addr = binding.addr.text?.toString()
+            val port = binding.port.text?.toString()?.toIntOrNull()
+            val username = binding.username.text?.toString()
+            val password = binding.password.text?.toString()

            if (type != Proxy.Type.DIRECT) {
                if (addr == null || addr.isEmpty())
-                    view.proxy_addr.error = context.getText(R.string.proxy_dialog_error)
+                    binding.addr.error = context.getText(R.string.proxy_dialog_error)
                if (port == null)
-                    view.proxy_port.error = context.getText(R.string.proxy_dialog_error)
+                    binding.port.error = context.getText(R.string.proxy_dialog_error)

                if (addr == null || addr.isEmpty() || port == null)
                    return@setOnClickListener
@@ -126,8 +124,6 @@ class ProxyDialog(context: Context) : AlertDialog(context) {

            dismiss()
        }
-
-        return view
    }

 }